BUG=aomedia:992

Change-Id: Ibac542608d9abd669d0e8cf871960b2cf0a6da6a

This is the first step towards moving the upscale convolve function
to convolve.c

Change-Id: I916a974a881d104b0b3cde861fa8bb898883af01

BUG=aomedia:938

Change-Id: Ic730ac1136e915d193f3b48f7788baa093e7ff0f

This addresses an inconsistency between the set used
to decode the tx_type in the bitstream and the set used
for the tx_type search. Previously, the set used to
read/write the tx_type was based on the smallest tx_size
in the vartx partitioning, but the search uses a set
based on the largest possible tx_size. This patch
changes the tx_type search to use the transform type
set associated with the tx_size 1 recursive level down from
the max square tx_size to make the search more consistent
with the bitstream syntax. If a tx_size is selected for an
invalid tx_type, DCT_DCT is used for that partition instead.

This patch also adds assertions to all exposed transform
functions to ensure that no illegal transform type/size
combinations occur.

This currently gets a 0.1% drop in performance on lowres.
The drop is due to the reduction of the tx_types available
for 32x16 and 16x32 transform sizes. Before this patch,
32x16 and 16x32 transforms were getting assigned a
set of 12 tx_types, some of which we did not intend to
support for these sizes.

Change-Id: I44aca4876b261c345623cd04ad6235bca4532701

Change-Id: Icbedc16b01adf9b48f0f357ec89143462865d54e

Always at least set the first row and the first col, otherwise will
have unattended entries if we enable 4x16 or 16x4 txs.

Change-Id: I403ea3694ccf8c7ee1584f55bbc3e9b8355d9272

Change-Id: Ie9152c5a631cd53ac69cc09469682505a88b045d

At the frame header level, add the checking on whether an inter-coded
frame allows the use of 'skip_mode'. At the block level, add the
decoding of 'skip_mode' for all the blocks if 'skip_mode' is allowed
for the current frame. If 'skip_mode' is set, no further bit needs to
read out, and the block is set as:
- Inter-coded in compound mode;
- With the nearest forward and backward reference frames;
- In NEAREST_NEARESTMV mode;
- In SIMPLE_TRANSLATION motion mode;
- In COMPOUND_AVERAGE compound type; and
- Skip set for residual.

Change-Id: I50297f63a81135109332c4a51b516bffd7726777

Change-Id: I5b7bb9983e1c613321704a579d459925bd6b9b2b

This would result in certain motion vectors getting
lower weights than they deserve, so putting them in
the wrong position in the stack.

BUG=aomedia:981

Change-Id: I8bd106e97f494f5d3debaf967efcabcd39846726

Change-Id: Ie1751b111ce8b21424e5e7b8c7407163d4c81b99

BUG=aomedia:926

Change-Id: I3ec5ff501e2a6791ed13dcb0a7f4755b86e3910b

This reverts commit 1542157b.

The associated bug (#881) was fixed a couple of weeks ago.

Change-Id: If05627fd32ff9be1c4f425159798cfe46b6b2908

Further reduce the context model size needed for base levels down
to 25 per transform size.

Change-Id: I9df4870d2b027cdb1356de0fc4d5bcc22155319e

Reduce the context model size required to code the base level
syntax values from 42 to 32 per transform size.

Change-Id: I08485fdb563bc5c3323b0e147d69b47c286b9bb5

This loop is wrongly vectorized by the MSVC2017 compiler, this change
is a work-around for the compiler bug.

Change-Id: Ie4c8403965c3e4cd6d70eb3dbc92148f5272f0ab
(cherry picked from commit 5b33d7184bf319d9c10e34ef0fdcdd244d2fdb56)

Int was used but should have been int16_t. This does not alter the
encoder/decoder behavior

Change-Id: I6bfd8a3942e9f9b86cccf10c144fec147e996944

This changes serves to illustrate that DC_PRED does not
need 32 bits. It only needs the specified pixel bit depth.
Which fits inside a signed 16 bit integer.

Change-Id: Ice062c8c4a794cb4f32a3963278f4a99ef326dda

With the previous addition of cfl_build_prediction_lbd and
cfl_build_prediction_hbd there's no need for cfl_build_prediction.

Change-Id: I4246a53378f1e85be40c14433a3084d7120ad060

Change-Id: I97f7d390e580b6e1b2b471a6f1a95082323d39aa

This experiment has been abandonned.

Change-Id: Ifde0a76266af9f8c202c01805410b72d64594b0b

This experiment has been adopted, we can simplify the code
by dropping the associated preprocessor conditionals.

Change-Id: I54fee8a18afaec5333ae852eb6bd9ac0e2550db1

Avoid switch warning regarding fallthrough, add consts.

Change-Id: Ie3a03e60420d962941abc4e144648f29401916b9

When the frame header requires to cut off the motion vector
referencing from prior frames, shut off the use of motion field.

BUG=aomedia:984

Change-Id: Ib47129ea538248f4e67d115be2da3b5dd861693e

Disabling such cases will reduce search time without hurting
coding performance (-0.001%).

Change-Id: Iaa4385053fcf5bd59fb1f94d5583eb19cf792242

This experiment has been adopted, we can simplify the code
by dropping the associated preprocessor conditionals.

Change-Id: I2dce80e1e1b2116708b6ba9feeacaacc12af8fc4

Adopted by AOM WG on 08/17.

Change-Id: I3e5b369e9d8220c7b3f9e6f9d300eb640e2bf3a8

Adopted 08/24.

Change-Id: Ic6ccc766c821f7bba2779c069f00ccc131ff9c10

This patch factors out a function that computes the rd cost for
a given transform type given the transform partition already
computed. This is then used to develop a speed feature where the
transform size search disables trellis optimization but once the
transform sizes are decided, a final search is conducted with
optimization turned back on.
This patch does not change anything in speed 0 yet.

Change-Id: I30acfc5e2dd353d711e5f4260d5b344847b03ade

This experiment was provisionally adopted at the F2F 2017-08-22.

Enabling CFL on Subset1
   PSNR |  PSNR Cb |  PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
-0.5330 | -12.8717 | -10.7454 |  -0.3119 | -0.3409 | -0.3415 |    -4.8720

https://arewecompressedyet.com/?job=no-cfL%402017-10-30T17%3A14%3A33.925Z&job=cfL%402017-10-30T17%3A15%3A02.467Z

Change-Id: I2b35f352366c585887aa4fb77ae5acb159d6819f

Change-Id: I35a5334972b73bdf31d6476d376af982c964a54b

Change-Id: I9f752dedfba29de9a4cfdd285c4b6dc32bd1630d

When 4:2:2 subsampling is used, both horizontal pixels are added and
shifted left by 1 (instead of a right shift of 2 followed by a left
shift of 3).

Change-Id: Ib84c51cafabe0bd0de02dfe7868278e44d76f6db

Reset the frame index tracking to 0 when key frame is inserted in
the frame sequence.

Change-Id: Ib80313004fc000e7127a9797af5afe9029c0cb45

This reverts commit c002bdf6.

Now the issue has been tracked down to what is described in:
https://aomedia-review.googlesource.com/#/c/aom/+/29761/

Change-Id: I49fe8395781e1fea8095dbdc6c00d36b90dc7575

Change-Id: I39cfbb135add0553cadf64481b13786831fbdddd

Change-Id: I9b1351263286041d718a1b54735c17aeb5f8a0a7

I'd got the scaling backwards. This gets it right and adds a comment
explaining the calculation.

Change-Id: Ife2913700cc73996c09b702b394832799c449a8c

The frame marker system supports one to map the reference frame
index into the natural order. It allows direct checking on the
efficacy of the reference frames given their relative locations
with respect to the current coding frame.

This commit uses such property to filter out reference frames
less likely to contribute coding gains from the rate-distortion
optimization process. For example, it takes out the check on
last2 / 3 frames, when their actual location is further away
from the golden frame.

The AWCY results show 0.6% performance regression. The encoding
speed gets doubled.

To use the speed up, one needs to turn on frame-marker experiment
before we turn it on by default, and enable selective_ref_frame
entry in the speed feature.

Change-Id: Ifb03ed90acd980bbc7ff1c2e17982e21e68d2588

This experiment has been adopted, we can simplify the code
by dropping the associated preprocessor conditionals.

Change-Id: I9c9d6ef5317798cbf237307a9754fe7e03bdda47