GitLab

Change-Id: I3f30c35bcd1bc623ad0c34c4b954ff71b2fcfd00

This experiment has been adopted, we can simplify the code
by dropping the associated preprocessor conditionals.

Change-Id: Ic077963f72e8cc2ae9872b58c8a0241988384110

Change-Id: I8a9f634bf9a5776c752cc72a18e0f0eec4d1d58f

Change-Id: Ic3c93a5d2e427ce1ed578389196a265245063821

Change-Id: Iec7969ffd8f53ca2f4eefd1d757cfec7b3bde131

For some reason xd->cur_buf->bit_depth appears to always be 0.
Use xd->bd instead, as this appears to have the correct value.

Along with commit 49bb8f8c, this fixes the HBD internal quality
loss introduced in commit 5d24b6f0.

BUG=aomedia:649

Change-Id: Ie97e9caf3b13f7493f873258f3863e1314466f1d

Added a sample selection process in warped motion.
1. Gather more samples including multiple rows on the top, multiple
columns on the left, and the upper-right block.
2. Sort samples by the MV difference between the neighbour's MV and
the current block's MV. Trim the samples with considerably large MV
difference.

Borg test result:
             avg_psnr ovr_psnr ssim
cam_lowres:  -0.241   -0.243  -0.376
lowres:      -0.104   -0.110  -0.179

The changes are wrapped in WARPED_MOTION_SORT_SAMPLES macro.

Change-Id: I2730bb31a0a3ad28215ccd16fd6da0ea8b2ed404

They do not handle border extension correctly (interpolation and
border extension do not commute unless you upsample into the
border), nor do they handle crop dimensions that are not a multiple
of 8 (the upsampled version is not sufficiently large), in addition
to using massive amounts of memory and being a criminal waste of
cache (1 byte used for every 8 bytes fetched).

This commit reimplements use_upsampled_references by computing the
subpixel samples on the fly. This implementation not only corrects
the border handling, but is also faster, while maintaining the
same quality.

HL AWCY results are basically noise:
    PSNR | PSNR HVS |   SSIM | MS SSIM | CIEDE 2000
  0.0188 |   0.0187 | 0.0045 |  0.0063 |     0.0228

Change-Id: I7527db9f83b87a7bb8b35342f7e6457cd0bef9cd

Now the single ref comp mode should work with WEDGE and
COMPOUND_SEGMENT. For motion_var, the OBMC_CAUSAL mode uses the 2nd
predictor if the neighboring block is single ref comp mode predicted.

This patch removes the mode of SR_NEAREST_NEWMV and leaves four
single ref comp modes in total:

SR_NEAREST_NEARMV
SR_NEAR_NEWMV
SR_ZERO_NEWMV
SR_NEW_NEWMV

Change-Id: If6140455771f0f1a3b947766eccf82f23cc6b67a

Implemented a MV refining search after the warped motion parameters were
found. Only 4 or 8 positions were checked so there was almost no impact
on encoder speed.

Borg test result:
            avg_psnr     ovr_psnr    ssim
cam_lowres: -0.543%      -0.574%     -0.670%
lowres    : -0.222%      -0.230%     -0.285%

Change-Id: Ic2f6c1fe548b089d50e9c33bb365e6b128aabc93

Change-Id: Ib94d57b24d3276dd74abe151f740258d78ff430b

* Rename the 'masked_compound_*' functions to just 'masked_*'.
  The previous names were intended to be temporary, to distinguish
  the old and new masked motion search pipelines. But now that the
  old pipeline has been removed, we can reuse the old names.

* Simplify the new ext-inter compound motion search pipeline
  a bit.

* Harmonize names: Rename
  aom_highbd_masked_compound_sub_pixel_variance* to
  aom_highbd_8_masked_sub_pixel_variance*, to match the naming of
  the corresponding non-masked functions

Change-Id: I988768ffe2f42a942405b7d8e93a2757a012dca3

Patches https://aomedia-review.googlesource.com/c/11987/
and https://aomedia-review.googlesource.com/c/11988/
replaced the old masked motion search pipeline with
a new one which uses different SAD/SSE functions.
This resulted in a lot of dead code.

This patch removes the now-dead code. Note that this
includes vectorized SAD/SSE functions, which will need
to be rewritten at some point for the new pipeline. It
also includes the masked_compound_variance_* functions
since these turned out not to be used by the new pipeline.

To help with the later addition of vectorized functions, the
masked_sad/variance_test.cc files are kept but are modified
to work with the new functions. The tests are then disabled
until we actually have the vectorized functions.

Change-Id: I61b686abd14bba5280bed94e1be62eb74ea23d89

Add functions which take both components of a masked compound and
compute the resulting SAD/SSE. Extend joint_motion_search to understand
masked compounds, and use it to evaluate NEW_NEWMV modes.

Change-Id: I782199a20d119a6c61c6567df157508125ac7ce7

This fixes a warning about unused computed values when
CONFIG_HIGHBITDEPTH is 1.

Change-Id: Ibf1076c4838f750da4a1b940b550ef8ecac6ba02

BUG=aomedia:518

Change-Id: Ia88b50b084c6370073ac4916e00a019963cf0254

This reverts commit 9395b34e, because it
did not have any effect in eliminate ubsan warnings as intended.

Change-Id: I9221385217f062a0356fe0c68643b12751048f69

Change-Id: I64c523a34b4d69450759433e125a79e63d928037

Offset the buffer pointers of sub8x8 chroma components to support
the coding process at bottom right 8x8 block.

Change-Id: Ide17ee31ce064484371194cbbade88603d114a2e

This unit test was ported from VP9. To prevent the motion vector out of
range bug, added a motion vector unit test. In the 4k video encoding,
always forced to use extreme motion vectors and also encouraged to use
INTER modes. In the decoding, checked if the motion vector was valid,
and also checked the encoder/decoder mismatch.

Change-Id: I1c72ea7c32a3cec9c67f1bbdc168e60507e57516

BUG=aomedia:448

Change-Id: Ieff977fca8a5033ddef2871a194870f59301ad8f

It isn't used outside of its source file.

BUG=aomedia:442

Change-Id: I7f9f62b3a8e0e965878fc21af6c64b91883686fc

cherry pick of libvpx commit 6554333b59cf773983c7cacbd832d754f75139e8

BUG=aomedia:443

Change-Id: Ifebdc9ef37850508eb4b8e572fd0f6026ab04987

Ported an out of range MV bug fix from VP9.
(https://chromium-review.googlesource.com/c/458180/)

Change-Id: Id2a7636f3c78547f8ae2081c4bcba709910b1650

Ported a bug fix from VP9.
(https://bugs.chromium.org/p/webm/issues/detail?id=1354)

Change-Id: Ib712b6dfb6aa86631f4b2a403c8364dbe1104f21

Ported a bug fix from VP9.
(https://chromium-review.googlesource.com/c/473566/)

Change-Id: I5669c3878b34a5fda4ce1aabb8c653ea823d5e42

Also use int instead of int64_t since sf->exhaustive_searches_thresh is
an int and we only make it smaller.

Change-Id: I38c9ebd97f085cb7ce5094dfc98942bb2171ee0f

Rename '--enable-aom-highbitdepth' to '--enable-highbitdepth'

Change-Id: I1de13c3508c30c552532993419d8ace326142ab6

Change-Id: Ib1b5dde5d4c6479c968cd7d7a4a1d01abae1fcf6

Replace the computation of block size in pixels with lookup table
directly.

Change-Id: I39589b2bc1d20372969ff5ad0f60639e64a19b41

It always returns true since the related misc_fix[1] was merged.

[1] 23e83574

Change-Id: Ie3af685572a2f0a42d2b9fb9903c1abeea225dfd

While we are at it:
- Rename some variables to more meaningful names
- Reuse some common consts from a header instead of redefining them.

Cherry-picked from aomedia/master: 863b0499

Change-Id: Ida5de713156dc0126a27f90fdd36d29a398a3c88

- Const correctness
- Refactoring
- Make variables local when possible etc
- Remove -Wcast-qual to allow explicitly casting away const.

Cherry-picked from aomedia/master: c27fcccc
And then a number of more const correctness changes to make sure other
experiments build OK.

Change-Id: I77c18d99d21218fbdc9b186d7ed3792dc401a0a0

To get ready for pulling AV1 to nextgenv2. Refactoring is done to
make the code structures similar, especially for the motion search
part.

Change-Id: I5d7636394408d97de55394d668540f5627827983

To get ready for pulling AV1 to nextgenv2
Replace the experimental flag by MOTION_VAR. Rename major variables.

Change-Id: If6cf4f37b9319c46d8f90df551cc7295d66ca205

It always returns true since the related misc_fix[1] was merged.

[1] 23e83574

Change-Id: Ie3af685572a2f0a42d2b9fb9903c1abeea225dfd

Change-Id: I8efb64eac3438484e7a77a8a1db198223fc52bfa

Change-Id: I863fc85c7dc1b4f4e5740ac086fe1a852c62d26e

Change-Id: If22018f8911d9d7ee99c2127bdfcc56e42b0e2d7

Change-Id: I2b2b70e756b7eb9611b7b33b7d5f19b3b30e0a50