GitLab

This commit has no impact on metrics.

Change-Id: I2dabe2ab5f2050af87f82666faac4f8d8d2eb507

This commit has no impact on metrics.

Change-Id: I4e2c66d9082e1f2bdbe8851492e91c653f5da6f1

This commit has no impact on metrics.

Change-Id: I9fae08410da95dd851e33515289f9d878c43e736

This commit has no impact on metrics.

Change-Id: I58d85dc22627849657c88c082db940baff921f8d

This commit has no impact on metrics.

Change-Id: I85007ef966b9aab4545499016ed68ab5c96a417a

This commit has no impact on metrics.

Change-Id: I218f2a95542ae68491d2844becf6018eda529a1f

This allows a mask for mrc-tx to be sent in the bitstream for
inter or intra 32x32 transform blocks. The option to send the mask
vs build it from the prediction signal is currently controlled with
a macro. In the future, it is likely the macro will be removed and it
will be possible for a block to select either method. The mask building
functions are still placeholders and will be filled in in a followup.

Change-Id: Ie27643ff172cc2b1a9b389fd503fe6bf7c9e21e3

Make it 0 to run at higher precision

Change-Id: I51decbf9179efa18a1a06dcc3f0e939d9895a5cd

Change get_lgt in order to integrate a later experiment
lgt_from_pred with lgt. There are two main changes.

The main purpose for this change is to unify get_fwd_lgt and
get_inv_lgt functions into a get_lgt function so the lgt basis
functions can always be selected through the same function in
both forward and inverse transform paths. The structure of those
functions will also be consistent with the get_lgt_from_pred
functions that will be added in the lgt-from-pred experiment.

These changes have no impact on the bitstream.

Change-Id: Ifd3dfc1a9e1a250495830ddbf42c201e80aa913e

Coding gain becomes tiny on top of other experiments.

Change-Id: Ia89b1c2a2653f3833dff8ac8bb612eaa3ba18446

CONFIG_DAALA_DCT4 currently force-enables CONFIG_DCT_ONLY due to a
missing 4-point DST.  The DST had not been included because it was a
significant coding performance loss; this turned out to be a bug that
has since been corrected.

This patch adds a 4-point type IV DST to the DAALA_DCT4 experiment.
There is a small coding performance loss in using the type IV over
AV1's current type VII.

subset-1:
   monty-newdst4test-baseline-s1-F@2017-07-29T04:58:43.976Z ->
      monty-newdst4test-daala-s1-F@2017-07-29T04:59:56.094Z

   PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
-0.0336 |  0.1393 |  0.0491 |   0.4118 | -0.0439 |  0.2084 |     0.0476

objective-1-fast:
   monty-newdst4test-baseline-o1f-F@2017-07-29T04:58:10.439Z ->
      monty-newdst4test-daala-o1f-F@2017-07-29T04:59:04.678Z

  PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
0.0064 |  0.1071 | -0.0108 |   0.1133 | -0.0035 |  0.0765 |     0.0502

Change-Id: Ie29835edbe0e41bc86f4b09457e88d924cc9bf7e

This experiment replaces the 64-point Type-II DCT and related
scaling vp9 transforms with the 64-point orthonormal
Daala transforms.

subset-1:

    monty-square-baseline-s1-F2@2017-07-28T03:35:45.962Z ->
      monty-square-dct64-s1-F2@2017-07-29T04:50:58.412Z

       PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
    -0.1930 | -0.2037 | -0.0643 |  -0.1917 | -0.2331 | -0.3510 |    -0.1810

objective-1-fast:

    monty-square-baseline-o1f-F2@2017-07-28T03:35:35.533Z ->
      monty-square-dct64-o1f-F2@2017-07-29T04:50:28.542Z

       PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
    -0.2557 | -0.1743 | -0.4900 |  -0.3028 | -0.4147 | -0.5764 |    -0.2864

Change-Id: I1f944df29e44d2e350c42555af274f2d75a62a92

This experiment replaces the 32-point Type-II DCT and 32-point
Type-IV DST scaling vp9 transforms with the 32-point orthonormal
Daala transforms.

subset-1:

    monty-square-baseline-s1-F3@2017-08-02T11:50:51.375Z ->
      monty-square-dct32-s1-F3@2017-08-02T11:50:18.859Z

      PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
    0.0000 |  0.0115 | -0.1044 |  -0.0185 | -0.0069 | -0.0603 |     0.0555

objective-1-fast (4 frames):

    monty-square-baseline-o1f-F3-l4-fine@2017-08-12T02:18:05.560Z ->
      monty-square-dct32-o1f-F3-l4-fine@2017-08-12T02:19:44.461Z

      PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
   -0.0269 | -0.0715 |     N/A |  -0.0547 | -0.0268 | -0.0590 |        N/A

Change-Id: Ib1bad991d82eb67956e94a6216298a84e908b169

This allows inter and intra modes to use different mask functions.
The mask functions checked in are still place holders to allow for
easy experimentation.

Change-Id: Ic20d88200676df81dffee8c43555d0ff0c7bfc28

This commit de-duplicates C reference quantization code
and unifies quantization matrix (QM) and non-QM code
paths when there is no SIMD.

The reorganisation also will facilitate re-using SIMD quant
functions for QM when the matrix is flat, as is the
default when AOM_QM is enabled.

Change-Id: Idbfdac9eb9a31adcffe734aac1877d58b86fab77

If the mask is invalid, do not allow the encoder to select MRC_DCT.
Currently the mask is invalid if it is all 1 or all 0, but these
criteria will likely expand in a future patch.

Change-Id: I77230ea8357bfdb2bf1e6338903d44bbf1db22d1

This experiment replaces the 16-point Type-II DCT and 16-point Type-IV
DST scaling vp9 transforms with the 16-point orthonormal Daala
transforms.  These have reduced complexity and are perfect
reconstruction.  There is currently no net coding performance impact.

subset-1:

  monty-square-baseline-s1-F@2017-07-23T03:43:45.042Z ->
     monty-square-dct16-s1-F@2017-07-23T03:42:29.805Z

   PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
-0.0152 | -0.0028 | -0.0929 |  -0.0432 | -0.0457 | -0.0425 |    -0.0237

  objective-1-fast:

  monty-square-baseline-o1f-F@2017-07-23T03:44:19.973Z ->
     monty-square-dct16-o1f-F@2017-07-23T03:43:22.549Z

  PSNR | PSNR Cb | PSNR Cr | PSNR HVS |   SSIM | MS SSIM | CIEDE 2000
0.0305 |  0.0926 | -0.1600 |   0.0471 | 0.0219 | -0.0075 |     0.0135

Change-Id: I54fed26d65fd8450693334bb400b1fafd7e0dacb

MRC_DCT uses a mask based on the prediction signal to modify the
residual before applying DCT_DCT. This adds all necessary functions
to perform this transform and makes the prediction signal available
to the 32x32 txfm functions so the mask can be created. I am still
experimenting with different types of mask generation functions and
so this patch contains a placeholder. This patch has no impact on
performance.

Change-Id: Ie3772f528e82103187a85c91cf00bb291dba328a

This experiment replaces the 8-point Type-II DCT and 8-point Type-IV DST
 scaling vp9 transforms with the 8-point orthonormal Daala transforms.
These have reduced complexity and are perfect reconstruction at the cost
 of a slightly worse coding performance.
This is because the Daala transforms expect the input to be shifted by 4
 bits but the output scale of the vp9 transforms is only 3 bits.

subset-1:

monty-square-baseline-subset1 ->
  monty-square-dct8-subset1@2017-07-17T21:37:44.281Z

  PSNR | PSNR Cb | PSNR Cr | PSNR HVS |   SSIM | MS SSIM | CIEDE 2000
0.0019 | -0.0011 | -0.0585 |  -0.0111 | 0.0305 |  0.0317 |     0.0187

objective-1-fast:

monty-square-baseline-o1f ->
  monty-square-dct8-o1f@2017-07-17T21:37:15.735Z

  PSNR | PSNR Cb | PSNR Cr | PSNR HVS |   SSIM | MS SSIM | CIEDE 2000
0.0285 |  0.0129 | -0.5080 |   0.0529 | 0.0345 |  0.0441 |     0.0054

Change-Id: I2b775495398fb717204a295397c3c5e3ca938183

This adds the new transform to the list of possible transforms.
The impact on performance is in the noise range because the transform
implementation currently performs DCT as a placeholder. This transform
will initially only have an implementation for TX_32X32 and it is
skipped in the tx search for smaller transform sizes.

Change-Id: Iab2faddc525b478ca06972a753428a4f4ef53ac6

Change two similar structs, FWD_TXFM_PARAM and INV_TXFM_PARAM,
into a common struct: TxfmParam. Its definition is moved to
aom_dsp/txfm_common.h to simplify dependency.

This change is made so that, in later changes of the LGT
experiment, functions requiring FWD_TXFM_PARAM and
INV_TXFM_PARAM, such as get_fwd_lgt4 and get_inv_lgt4, can
also be unified.

Change-Id: I756b0176a02314005060adbf8e62386f10eeb344

This experiment replaces the 4-point Type-II scaled-output vp9 DCT
 transform with the 4-point Type-II orthonormal Daala DCT transform.
Right now the CONFIG_DAALA_DCT4 experiment depends on CONFIG_DCT_ONLY
 as it does not add an orthonormal 4-point DST.

subset-1:

monty-baseline-dctonly-squaretx-subset1 ->
  monty-dct4-dctonly-squaretx-subset1-rerun

  PSNR | PSNR Cb | PSNR Cr | PSNR HVS |   SSIM | MS SSIM | CIEDE 2000
0.0055 | -0.0132 | -0.0405 |   0.0261 | 0.0005 |  0.0246 |     0.0226

objective-1-fast:

monty-baseline-dctonly-squaretx-o1f ->
  monty-dct4-dctonly-squaretx-o1f

   PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
-0.0215 | -0.1573 |     N/A |  -0.0131 | -0.0347 | -0.0390 |    -0.1121

Change-Id: Idef8f6e5525037d5bbb2d0927675c21d1922d69a

Building with --enable-dct_only will force the encoder to use only
 tx_type == DCT_DCT.
This experiment gives a loss and is only added for testing.

subset-1:

master@2017-02-21T01:23:58.825Z ->
 master-dct_only@2017-02-21T02:57:28.585Z

  PSNR | PSNR Cb | PSNR Cr | PSNR HVS |   SSIM | MS SSIM | CIEDE 2000
2.5467 |  1.0524 |  0.9171 |   1.8849 | 2.6626 |  2.4995 |     1.8402

objective-1-fast:

master@2017-02-21T01:47:43.790Z ->
 master-dct_only@2017-02-20T16:54:03.578Z

  PSNR | PSNR Cb | PSNR Cr | PSNR HVS |   SSIM | MS SSIM | CIEDE 2000
1.6625 |  0.3948 |  0.3368 |   1.5268 | 1.7142 |  1.7097 |     1.0743

Change-Id: I19b738f3d1a450bc50422149ac42bc184bfae08a

Here we have an LGT to replace ADST for intra residual blocks, and
another LGT to replace ADST for inter residual blocks. The changes
are only applied to transform length 4 and 8, and only for the
lowbitdepth path.

lowres: -0.18%

Change-Id: Iadc1e02b53e3756b44f74ca648cfa8b0e8ca7af4

The input arguments of av1_fht* and av1_iht* functions (and their
HBD versions) are slightly changed. Input arguments tx_type and
bd are carried by a struct fwd_txfm_param/inv_txfm_param. This
struct is meant to later on carry other prediction information,
such as intra top/left boundaries to the transform level, so
that the choice of transforms can be more adaptive to the
prediction mode and local video content.

Change-Id: Ia42544248a51845be64b72855b642ef1fe5910a9

Change-Id: Iaae46d0735539b8b8daf9faac81c2a3434838020

In previous ADSTs, DST-7 and DST-4 are used for length 4 and length
8/16/32, respectively. In this LGT experiment we explore transforms
between DST-4 and DST-7. When CONFIG_LGT flag is on, adst4 and adst8
are replaced by lgt4 and lgt8, the intermediate transforms with
pre-chosen parameters.

The LGTs applied here are lgt4_160 and lgt8_170, where the numbers
mean the self-loop weights times 100. The associated values for DST-7
and DST-4 are 100 and 200.

ovr_psnr:
lowres: -0.140
midres: -0.131
hdres: -0.078

These changes are not applied to the highbd scenario in the
current version.

Change-Id: I20600456da8766528b2b6b11aa28801e70af498e

Responding to some left over cosmetic comments from
2b5cdb1cf87c933331a16cc0221455d0a8c255e1

Change-Id: I42e126593526cedd6675adf35b9c1df78e1ddf54

This unifies the codepath for high-bitdepth transforms and deletes
all calls to the old deprecated versions. This required reworking
the way 1d configurations are combined in order to support rectangular
transforms.

There is one remaining codepath that calls the deprecated 4x4 hbd
transform from encoder/encodemb.c. I need to take a closer look
at what is happening there and will leave that for a followup
since this change has already gotten so large.

lowres 10 bit: -0.035%
lowres 12 bit: 0.021%

BUG=aomedia:524

Change-Id: I34cdeaed2461ed7942364147cef10d7d21e3779c

Encode a block line by line, horizontally or vertically. In the vertical
mode, each row is predicted by the reconsturcted row above;
in the horizontal mode, each column is predicted by the reconstructed
column to the left.

The DPCM modes are enabled automatically for blocks with horizontal or
vertical prediction mode, and 1D transform types (ext-tx).

Change-Id: I133ab6b537fa24a6e314ee1ef1d2fe9bd9d56c13

This adds the proper cfgs to av1_{inv/fwd}_txfm1d_cfg for
the identity transform so all hbd transforms can use
the same codepath. This has no impact on performance
since the new identity transforms that correspond with
the cfgs are not yet being called. Once this is checked in,
we should be able to delete all deprecated transform functions
and have a single code flow for all hbd transforms.

BUG=aomedia:524

Change-Id: I3d1bfbc8bc29b367e8ddf7dcd27525af0bd31067

The hbd transform configurations were originally written for all possible
2d transforms. Now that there are many more possible 2d transforms
due to EXT_TX and RECT_TX, it is simpler to write the cfg for the
4 1D transform types and compose them to make all new possible transform
types. This will allow for an easier integration of the identity transform
for EXT_TX and rectangular transforms for RECT_TX into the current
hbd transform codepath and facilitate the removal of obsolete transforms.
This has no impact on performance.

BUG=aomedia:524

Change-Id: I1e217bcd217fd637b1df94fae62d9c59a0523c1a

Rename '--enable-aom-highbitdepth' to '--enable-highbitdepth'

Change-Id: I1de13c3508c30c552532993419d8ace326142ab6

only expose the static functions needed in the test file to avoid link
errors for e.g., av1_fht4x4_c

Change-Id: I35111d322f30bc2bfc57b32c11f691f0717cfaba

Change-Id: I487995f51737be882d4f2a4c7bbd6b87297b4f55

Performance drop with ext_tx and rect_tx on
       BDRate
lowres -0.028
midres -0.075
hdres  -0.054

Change-Id: I50f89b9e9785d82ab05c3276a3c8b22b4dcfd408

Change-Id: Ic4775ed7e9470230deda2d8f656d94e3f81df99a

Modifies the C fwd txfms to have correct scaling. Rectangular
transforms now are always implemented in a way that the samller
side is transformed first.

The SSE2 tests are temporarily disabled until the SSSE2 code
is modified to be consistent with the C code.

Also includes a fdct32 fix.

borgtest results show a slight improvement.

Change-Id: I9417fd0b833d79e0ab13c85d3210d9ea8f2029a4

By adjusting the internal scaling and rounding in the transforms,
we can adjust the maximum round-trip errors to:
* 8x16 and 16x8: 0 pixel values (ie, transforms are exact)
* 16x32: 1 pixel value
* 32x16: 2 pixel values

Change-Id: I0ba691a8d27042dcf1dd5ae81568d07a92d68781

- Add 16-bit saturation in fdct_round_shift().
- Add extreme value tests and round trip error tests.
- Fix inv 4x8 txfm calculation accuracy.
- Fix 4x8, 8x4, 8x16, 16x8, 16x32, 32x16 extreme value tests.
- BDRate: lowres: -0.034
          midres: -0.036
          hdres:  -0.013
BUG=webm:1340

Change-Id: I48365c1e50a03a7b1aa69b8856b732b483299fb5