1. 07 Dec, 2011 7 commits
  2. 06 Dec, 2011 4 commits
    • Ronald S. Bultje's avatar
      Fix for RD thresholds if both I8X8 and DUALPRED are enabled. · 0072b8bc
      Ronald S. Bultje authored
      Change-Id: I5f9fc894e6a332d9be6d7336c7c5fe11e65b8498
      0072b8bc
    • Ronald S. Bultje's avatar
      Dual 16x16 inter prediction. · 60cb39da
      Ronald S. Bultje authored
      This patch introduces the concept of dual inter16x16 prediction. A
      16x16 inter-predicted macroblock can use 2 references instead of 1,
      where both references use the same mvmode (new, near/est, zero). In the
      case of newmv, this means that two MVs are coded instead of one. The
      frame can be encoded in 3 ways: all MBs single-prediction, all MBs dual
      prediction, or per-MB single/dual prediction selection ("hybrid"), in
      which case a single bit is coded per-MB to indicate whether the MB uses
      single or dual inter prediction.
      
      In the future, we can (maybe?) get further gains by mixing this with
      Adrian's 32x32 work, per-segment dual prediction settings, or adding
      support for dual splitmv/8x8mv inter prediction.
      
      Gain (on derf-set, CQ mode) is ~2.8% (SSIM) or ~3.6% (glb PSNR). Most
      gain is at medium/high bitrates, but there's minor gains at low bitrates
      also. Output was confirmed to match between encoder and decoder.
      
      Note for optimization people: this patch introduces a 2nd version of
      16x16/8x8 sixtap/bilin functions, which does an avg instead of a
      store. They may want to look and make sure this is implemented to
      their satisfaction so we can optimize it best in the future.
      
      Change-ID: I59dc84b07cbb3ccf073ac0f756d03d294cb19281
      60cb39da
    • Paul Wilkins's avatar
      Some further QIndex issues with extended Q · b4ad9b5d
      Paul Wilkins authored
      Resolved or factored out some further issues with Q index.
      Put in a 3rd order polynomial instead of less accurate power function
      as the best fit on gf and kf boost adjustment.
      Added avg_q value to use instead of ni_av_qi.
      Compute segment delta Q values based on avg_q.
      Fixed bug in adjust_maxq_qrange().
      
      The extended range Q on the derf set, using standard data rates
      (which do not extend high enough to get big benefits) still show
      a shortfall of between 0.5 and 1% though so there would appear to
      be further issues that need to be tracked down.
      
      Change-Id: Icfd49b9f401906ba487ef1bef7d397048295d959
      b4ad9b5d
    • Yaowu Xu's avatar
      corrected an enum name · 0404a5a7
      Yaowu Xu authored
      CNT_INTRA has been used for counting (0,0) motion vectos, this commit
      renames it to CNT_ZEROMV
      
      Change-Id: I8f67c5468370090525faf84ba5b3f780d302443f
      0404a5a7
  3. 05 Dec, 2011 1 commit
  4. 02 Dec, 2011 5 commits
    • Yaowu Xu's avatar
      changed configure script to enable new experimental options · 8a40d2f5
      Yaowu Xu authored
      Added two experimental options to the configure script:
      1. newnear:
         new scheme of doing mv encoding that include a motion vector from
         last frame in nearest and near mv search
      2. mulcontext:
         tracks entropy context separately for regular frames and alt ref
         frames.
      
      Change-Id: If6e0d5d593351707b497a26eb6a763e080f77e6f
      8a40d2f5
    • Yaowu Xu's avatar
      added separate entropy context for alt_ref · acf5d20c
      Yaowu Xu authored
      This commit added code to keep track of separate entropy contexts for
      normal frames and alt ref frames. The underly assumption was that the
      two type of frames have different entropy characteristics given they
      typically have quite different quantization levels. By keeping entropy
      contexts separate, it helps the entropy context distribution to be more
      closely adapted to each frame type.
      
      Tests on derf set showed a good and very consistent gain on all clips
      on all metrics, avg psnr: 0.89%, overall psnr: 0.84% and ssim 0.93%.
      
      http://www.corp.google.com/~yaowu/no_crawl/mulcontext.html
      
      Change-Id: I15bc9697f6ff7829042911fe0c62930585d7e65d
      acf5d20c
    • Yaowu Xu's avatar
      enabled 8x8 intra prediction modes on inter frames · a8fbab86
      Yaowu Xu authored
      This commit enabled the usage of 8x8 intra prediction modes on inter
      frames. There are a few TODO items related to this: 1)baseline entropy
      need be calibrated; 2)cost of UV need to be done more properly rather
      than using decision only relying on Y; 3)Threshold for allowing picking
      8x8 intra prediction should be lowered to lower than the B_PRED.
      
      Even with all the TODOs, tests showed consistent gain on derf set ~0.1%
      (PSNR:0.08% and SSIM:0.14%). It is assumed that 8x8 intra prediction
      will help more on large resolution clips, especially with above TODOs
      addressed.
      
      Change-Id: I398ada49dfc32575cfab962a569c2885111ae3ba
      a8fbab86
    • Paul Wilkins's avatar
      Further work on extended Q range. · 8487a68b
      Paul Wilkins authored
      Fixed some further QIndex related issues and replaced some tables
      (eg zbin and rounding)
      
      Also Added function (currently disabled by default) to populate the
      main AC and DC quantizer tables. Using the original AC range the
      resulting computed DC values give behavior broadly comparable
      on the DERF set. That is not to say that the equations will hold good
      over a more extended range. The purpose of this code is to make it
      easier to experiment with further alterations to the Q range and distribution
      of Q values plus the relative weights given to AC and DC.
      
      The function find_fp_qindex() ensures that changes to the Q tables
      are reflected in the value passed in to the first pass code.
      
      Slight experimental adjustment to static segment Q offset.
      
      Change-Id: I36186267d55dfc2a3d565d0cff7218ef300d1cd5
      8487a68b
    • Paul Wilkins's avatar
      CR/LF issue. · 2b307b38
      Paul Wilkins authored
      Change-Id: I95fab6f51967008acf1bc9e98fdb7bb56974807f
      2b307b38
  5. 01 Dec, 2011 1 commit
    • Yaowu Xu's avatar
      added transform type to MB_MODE_INFO · bba710fc
      Yaowu Xu authored
      this commit is to add an variable in the macroblock level mode
      info structure to track the transform size used in each MB, so
      the information can be used later in the loop filter to change
      how loop filter works on MBs with different transform sizes.
      
      Change-Id: Id0eeaba6cc854c6d1be00ed8d237b3d9e250e447
      bba710fc
  6. 29 Nov, 2011 3 commits
    • Paul Wilkins's avatar
      MinQ equations. · a917afab
      Paul Wilkins authored
      Slight tweaks to the new minq equations to bring results more into line with
      original lookup tables.
      
      Change-Id: I969fc87d95912df549b6775e83ee2345e84d4da0
      a917afab
    • Paul Wilkins's avatar
      Extended Q Range: · b9ce9bcb
      Paul Wilkins authored
      Addressed a couple of other QIndex dependencies.
      
      Change-Id: I15b224bffd0210d3c7065cb6905156f2ca8e9ea9
      b9ce9bcb
    • Paul Wilkins's avatar
      Further work on extended Q range. · 99df6bb6
      Paul Wilkins authored
      Fixed bug in firspass.c call to vp8_initialize_rd_consts()
      
      This was passing in vp8_dc_quant(cm->base_qindex, cm->y1dc_delta_q)
       instead of (cm->base_qindex + cm->y1dc_delta_q).
      
      It just so happens that for the value 26 used for cm->base_qindex in the
      unextended Q case,  the two give similar results. However, when using
      the extended Q range the two are very different.
      
      Also added more stats output and partly disabled another broken feature.
      
      Change-Id: Iddf6cf5ea8467c44b7c133f38e629f6ba6f2581e
      99df6bb6
  7. 28 Nov, 2011 2 commits
  8. 23 Nov, 2011 2 commits
    • Paul Wilkins's avatar
      Two pass rate control code changes. · ee2051f6
      Paul Wilkins authored
      This comitt brings accross changes from the public branch
      commit number Icf74d13af77437c08602571dc7a97e747cce5066.
      
      The main puurpose of this comit relates to CQ mode but it
      also includes some refactoring of the two pass code which
      I hope will make tuning the experimental branch for the new
      quantizer range a little less painfull.
      
      Change-Id: I278e989436a928fc1fe7761068960048f9d7a376
      ee2051f6
    • Paul Wilkins's avatar
      Further resolution of QIndex LUTS; · a0b7db22
      Paul Wilkins authored
      This commit resolves further QIndex look up tables to facilitate
      experimentation with the quantizer range.
      
      In some cases  rather than remove the look up tables completely
      I have created functions that are called once  to populate them
      using a formulaic approach base on the actual quantizer.
      
      The use of these functions based on best fit of data from the original
      tables does affect the results on some clips but across the derf test
      set the effect was broadly neutral.
      
      Change-Id: I8baa61c97ce87dc09a6340d56fdeb681b9345793
      a0b7db22
  9. 22 Nov, 2011 2 commits
    • Adrian Grange's avatar
      Remove redundant code (lf_or_gf and frame_lf_or_gf) · 08491b86
      Adrian Grange authored
      Removed unused variables lf_or_gf and frame_lf_or_gf.
      
      Change-Id: I88692cd7d53e532d303c4525ee4667c1ecea3026
      08491b86
    • Paul Wilkins's avatar
      Removal of Qindex LUTS. · d39b5d05
      Paul Wilkins authored
      One of the problems arising when tweaking or adjusting the quantizer
      tables is that there are a lot of look up tables that depend on the QINDEX.
      Any adjustment to the link between QINDEX and real quantizer therefore tends
      to break aspects of for example the rate control.
      
      In this check in I have replaced several of the look up tables with functions that
      approximate the same results as the old Q luts but use a formulaic approach
      based on real Q values rather than QIndex. This should hopefully make it easier
      to experiment with changes to the Q tables without always having to go through
      and hand optimize a set of look up tables. Once things stabilize we may choose
      to re-instate luts for the sake of performance.
      
      Patch 2:
          Addressed Ronald's comments.
          vp8_init_me_luts() Added so luts only initialized once.
      
      Change-Id: Ic80db2212d2fd01e08e8cb5c7dca1fda1102be57
      d39b5d05
  10. 21 Nov, 2011 4 commits
    • Paul Wilkins's avatar
      Extended Q range Experiment. · 9bac509a
      Paul Wilkins authored
      Corrected dc lookup table to maintain ac/dc balance
      close to what it was previously.
      
      Firstpass not being passed the adjusted Q index for
      the extended range.
      
      Change-Id: Ic0200dabda445fea03bf81067999cb2670e99b77
      9bac509a
    • Paul Wilkins's avatar
      Cosmetic clean up. · 54f090b1
      Paul Wilkins authored
      Clean up of vp8_kfread_modes().
      Remove unnecessary indentation and enforce line length.
      
      Change-Id: I0864d1aff55368126db01bb23efa815786b5245d
      54f090b1
    • Paul Wilkins's avatar
      Decoder segmentation bug. · 19d87e8e
      Paul Wilkins authored
      Fix decoder segmentation bug for temporal coding where the segment map
      was first initialized on a key frame.
      
      in vp8_kfread_modes() after reading the segment id it must be written to
      the  pbi->segmentation_map[] for use in temporal coding on subsequent frames.
      
      Change-Id: I1489305efc376564e734a216f69c2844646ee3d3
      19d87e8e
    • Paul Wilkins's avatar
      CONFIG_T8X8 experiment.: · 4f792921
      Paul Wilkins authored
      Block the selection of 4x4 modes in key frames if 8x8 is selected.
      
      Change-Id: Ie5729ec22a999d9a1996f020bd4b941e29514992
      4f792921
  11. 17 Nov, 2011 2 commits
  12. 16 Nov, 2011 2 commits
    • Yaowu Xu's avatar
      fixed the scaling in 8x8 trellis quant · 7f33be9e
      Yaowu Xu authored
      This commit has a few minor fixes to the 8x8 trellis quant, so to
      make it work regardless if extend_qrange is enabled or not. It also
      borrowed adaptive RDMULT constants from 4x4 trellis that was missed
      in the 8x8 trellis quant.
      
      Change-Id: I60d7769071f102c699b5084597e62bca87a1f759
      7f33be9e
    • Paul Wilkins's avatar
      Header inclusion for Unix build · cee3d222
      Paul Wilkins authored
      Explicit inclusion of limits.h to satisfy unix build for definition of INT_MAX.
      Some commented out code removed.
      
      Change-Id: I5b5980dfaa9b4d2d12bfd729cfd35bd982106908
      cee3d222
  13. 15 Nov, 2011 3 commits
    • Paul Wilkins's avatar
      Merge CONFIGURE_SEGMENTATION experiment. · 3cdfdb55
      Paul Wilkins authored
      Removal of CONFIGURE_SEGMENTATION ifdefs.
      
      Removal of legacy support code fo the old coding mechanism.
      
      Use local reference "xd" for MACROBLOCKD structure in
      encode_frame_to_data_rate()
      
      Moved call to choose_segmap_coding_method() out of encode
      loop as the cost of segmentation is not properly accounted
      in the loop anyway. If this is desirable in the future it
      can be moved back. The use of this function to do all the
      analysis and set the probabilities also removes the need
      to track segment useage in threading code.
      
      Change-Id: I85bc8fd63440e7176c73d26cb742698f9b70cade
      3cdfdb55
    • Paul Wilkins's avatar
      Further clean up of Segmentation experiment code · 6394ef28
      Paul Wilkins authored
      Changed name and sense of segment_flag to "seg_id_predicted"
      Added some additional comments and retested.
      
      I also did some experimentation with a spatial prediction option
      using a similar strategy to the temporal mode implemented.
      This helps in some cases where temporal prediction is bad but
      I suspect there is more overlap here with work on a larger scale
      block structure and spatial correlation will likely be better
      handled through that mechanism.
      
      Next check in will remove #ifdefs and legacy mode code.
      
      Change-Id: I3b382b65ed2a57bd7775ac0f3a01a9508a209cbc
      6394ef28
    • Paul Wilkins's avatar
      Further work on Segmentation Experiment: · 661b2c2d
      Paul Wilkins authored
      This check in includes quite a lot of clean up and refactoring.
      
      Most of the analysis and set up for the different coding options for the
      segment map (currently simple distribution based coding or temporaly
      predicted coding), has been moved to one location (the function
      choose_segmap_coding_method() in segmenation.c). This code was previously
      scattered around in various locations making integration with other
      experiments and modification / debug more difficult.
      
      Currently the functionality is as it was with the exception that the
      prediction probabilities are now only transmitted when the temporal
      prediction mode is selected.
      
      There is still quite a bit more clean up work that will be possible
      when the #ifdef is removed. Also at that time I may rename and alter
      the sense of macroblock based variable "segment_flag" which indicates
      (1 that the segmnet id is not predicted vs 0 that it is predicted).
      
      I also intend to experiment with a spatial prediction mode that can be
      used when coding a key frame segment map or in cases where temporal
      prediction does not work well but there is spatial correlation.
      
      In a later check in when the ifdefs have gone I may also move the call
      to choose_segmap_coding_method() to just before where the bitsream is
      packed (currently it is in vp8_encode_frame()) to further reduce the
      possibility of clashes with other experiments and prevent it being called
      on each itteration of the recode loop.
      
      Change-Id: I3d4aba2a2826ec21f367678d5b07c1d1c36db168
      661b2c2d
  14. 11 Nov, 2011 2 commits
    • Paul Wilkins's avatar
      Segmentation experiment: · c9130bdb
      Paul Wilkins authored
      Added last_segmentation_map[] structure
      to keep track of what we had before when
      doing temporal prediction. With this change
      the existing code does once again appear to
      be giving a decodable bitstream for both
      temporal and standard prediction modes.
      However, it is still somewhat messy and
      confused and there is no option to take
      advantage of spatial prediction so it could
      do with further work.
      
      Some housekeeping / clean out.
      
      Change-Id: I368258243f82127b81d8dffa7ada615208513b47
      c9130bdb
    • Paul Wilkins's avatar
      SEGMENTATION experiment: · bf25d4ad
      Paul Wilkins authored
      Some initial cleanup to aid testing and debug.
      
      Pull code to choose temporal or spatial encoding
      out of encodeframe.c into a dedicated function
      in segmentation.c.
      
      For now disable broken temporal mode.
      
      Move the coding of "temporal_update" flag and
      only transmit if segment map update is indicated.
      
      Rename the functions read_mb_features() and
      write_mb_features() to read_mb_segid() and
      read_mb_segid() as they only read and write
      the macroblock segment id not any of the
      features.
      
      Change-Id: Ib75118520b1144c24d35fdfc6ce46106803cabcf
      bf25d4ad