The memset to 0 wasn't required because the temporary variable is only
written to, before being read in the next function call.

Tested:
./test_libaom --gtest_filter=*SelfguidedFilterTest*

Change-Id: Ie1628d43b050744ae97a8be55f551edb602b018b

Change-Id: I2888bd8905253e02e3ac74597275cf56e5142d29

Always let the encoder decide if "allow_screen_content_tools" should be set.

-The screen content detector(is_screen_content()) works fairly well.

-Keeping the config control may lead to mismatches. For example, user
may encode the 1st frame with the flag on, then turn the flag off for
the 2nd frame via config control. On the decoder side, the flag is on
for both frames, because the flag is only transmitted in the header of
all-intra frame, i.e. the 1st frame in this example.

BUT=aomedia:656

Change-Id: I0652fe2b9f8df19bfbf7ed7d3513205c80ea9c61

Change-Id: Ib245b059f1c1aa450b0755b437eab15c362d3aee

Files that contain a simd flavor in their name are only instrinsics
sources when the simd flavor is the suffix of the basename.

BUG=aomedia:657

Change-Id: I87d47c77750730171817f38fe3877226e7c09c10

Avoid consuming error messages like "Illegal instruction".

BUG=aomedia:657

Change-Id: Ia7983389ad3519f795f85d0c94a2a3787614a28d

Change-Id: Ie52ce24ca9eca272dfacfb17483ec7b7f2c126d4

This is a partial fix of the HBD upsampled pred quality loss
introduced in commit 5d24b6f0.

BUG=aomedia:649

Change-Id: I114dab1c8aac285071c5910dff40d48beea8c2ed

This simplifies the path from rd_pick_intra_sbuv_mode()

Results on Subset1 (compared to  dff41923

 with CfL enabled)

  PSNR | PSNR Cb | PSNR Cr | PSNR HVS |   SSIM | MS SSIM | CIEDE 2000
0.0000 |  0.0000 |  0.0000 |   0.0000 | 0.0000 |  0.0000 |     0.0000

Change-Id: I0bade9d347c626a78ba7077b960afdb318ecca69
Signed-off-by: David Michael Barr <b@rr-dav.id.au>

Added a 1-bit flag 'large_scale_tile'. If it is 0 that is the default value,
use normal tile coding in TILE_GROUPS. If it is 1, use large-scale tile
coding in EXT_TILE.

At large_scale_tile=1 case, if single-tile-decoding is required, then the
loopfilter is disabled.

Related API and unit tests were modified.

Change-Id: I3ba12dc3d80ccf1ab21543ab3b16c02282c34e3b

Change-Id: If878c33bb46c13216bd958c906f69d977066a144

Change-Id: I2d688d21de4a1d180f8ac36bb0363b57be55c0af

Transmit ncobmc modes only when the motion mode,
ncobmc_adapt_weight, is selected.

Change-Id: I19d6dd83278457b1867f8e2e5cd94d25f535fcaf

Change-Id: Iac17a7069749f10842dec75d5791aeadfa18f0f5

Before this, this function was copied-and-edited from
av1_build_inter_predictors_sby() and av1_build_inter_predictors_sbuv().
Also, some places used sb() one directly (like rdopt.c), while others used
sby() and sbuv() separately (like encodeframe.c --> encode_superblock()).

This was prone to errors, if someone mistakenly modified only one/two of
the 3 functions.

Now, we just reuse sby() and sbuv() functions in sb().

Verified that there's no change in output.

Change-Id: If81d78e767cc3fa09f06094d4db36ff1eaea3e4f

Change-Id: Iffc8e04bb5fa5c63542d5f85e838e6bc60405099

BUG=aomedia:654

Change-Id: Ic77a456246f87acb59ae95ddd4c421e741a99789

With aq-mode=1 (which forces segmentation), AWCY
gives -0.12% (objective-1-fast, cpu-used=4,
NEW_MULTISYMBOL on for reference and tested).

No change to baseline metrics, with or without
NEW_MULTISYMBOL.

Change-Id: I841a9e8978598402dacfbca9265269163f7440c0

Use row and column indexes to fetch the txk_type value.

Change-Id: I881d500c030e322d8aca9dccb6ff2870c9e1e392

Change-Id: Id89b613a227867782f9feba16d87eca4b5a86369

The goal is:
1) to provide a tool allowing to diagnose
and fix mismatches between LBD/HBD coding paths.

2) once all mismatches are fixed, this test
should be enabled so new ones can't be introduced.

Change-Id: I71c1db4c2cb142e9e3a7a4b02dd0d61f35b77178

- Decoder convolve rounding cycle percentage drops from
  2.75% to 0.91% by using avx2 function on i7-6700.

Change-Id: I34ae48f45c0b4073f8962647d2181365ffe3325b

Due to rounding the variance can become negative.
Similar behaviour has been fixed in commit b7e7c044.
I have made the corresponding changes to the masked_variance code.

BUG=aomedia:646

Change-Id: I21ed5a3f58080def08ac7ab9a77cbcad90318c99

Change-Id: Ia75a5160fc11df5d5dcbcb1bcf767de9925f811e

This commit resolves the compression performance regression when
both compound rounding and compound segment are enabled.

Change-Id: I831b4e44d2b054aa74922eb0c541eaa2ac355e0e

Use multi-symbol CDF coding instead.

Change-Id: I8a69364c8672474021d2ea5933e344d493186967

The frame marked as last_bipred at the encoder side is the frame right
before the source frame of BWDREF_FRAME, which was not used as a
reference. This CL is to add this type of frames to the reference frame
buffer and use them as reference for the coding of future frames. This
is a non-normative change.

A tiny gain is observed (lowres BDRate -0.016% in avg psnr). The main
target of this CL is to make it possible to have more flexible gf group
structure. For instance, LAST_BIPRED_UPDATE can be replaced by
LAST_UPDATE followed by an extra alt ref frame.

Change-Id: If3dbce0959bb468e95d01a1feca1dac6bfb91d36

Add a new default motion_mode_cdf supporting this
experiment.
Also define the costs for the ncobmc mode tokens.

Change-Id: Iebab044e4a34e3d2a94c18893107d82055cc9c77

Change-Id: I89035a64414f9511789022704ad9343bc2937666

To make it compatible with frame_superres

Change-Id: Id1560e1477a09cfd27a4b4f17468be9c76d09013

Turn "allow_screen_content_tools" on when the source video has many blocks
with only few different colors. The automatic detection is enabled by
defualt (or with command line flag "--tune-content=default"). With
"--tune-content=screen", the screen content tools are always turned on.

On the screen_content test set, the "default" setting is less than 0.3%
worse than the "screen" setting on keyframe encoding.

Change-Id: Iac7ab8952c96531d1fae84da1823291f5987519c

This patch adds support for 4:1 rectangular blocks to various common
data arrays, and adds new partition types to the EXT_PARTITION_TYPES
experiment which will use them.

This patch has the following restrictions, which can be lifted in
future patches:

  * ext-partition-types is incompatible with fp_mb_stats and supertx
    for the moment

  * Currently only 32x32 superblocks can use the new partition types

There's a slightly odd restriction about when we allow
PARTITION_HORZ_4 or PARTITION_VERT_4. Since these both live in the
EXT_PARTITION_TYPES CDF, read_partition() can only return them if both
has_rows and has_cols is true. This means that at least half of the
width and height of the block must be visible. It might be nice to
relax that restriction but that would imply a change to how we encode
partition types, which seems already to be in a state of flux, so
maybe it's better to wait until that has settled down.

Change-Id: Id7fc3fd0f762f35f63b3d3e3bf4e07c245c7b4fa

Fix the chroma component boundary context update in the inter
residual rd search.

Change-Id: Ice8028386a8b3bf921e2bf523ad0d2dcea707c7a

This experiment replaces the 4-point Type-II scaled-output vp9 DCT
 transform with the 4-point Type-II orthonormal Daala DCT transform.
Right now the CONFIG_DAALA_DCT4 experiment depends on CONFIG_DCT_ONLY
 as it does not add an orthonormal 4-point DST.

subset-1:

monty-baseline-dctonly-squaretx-subset1 ->
  monty-dct4-dctonly-squaretx-subset1-rerun

  PSNR | PSNR Cb | PSNR Cr | PSNR HVS |   SSIM | MS SSIM | CIEDE 2000
0.0055 | -0.0132 | -0.0405 |   0.0261 | 0.0005 |  0.0246 |     0.0226

objective-1-fast:

monty-baseline-dctonly-squaretx-o1f ->
  monty-dct4-dctonly-squaretx-o1f

   PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
-0.0215 | -0.1573 |     N/A |  -0.0131 | -0.0347 | -0.0390 |    -0.1121

Change-Id: Idef8f6e5525037d5bbb2d0927675c21d1922d69a

BUG=aomedia:652

Change-Id: I5d178fd101ac5c163249a82dfeacbf64091e8333

Also:
- Tidy up the BUILD_SHARED_LIBS section.
- Tidy up testing basics section.
- Make code block style consistent: always use fence style.

Change-Id: Iaa3bfd1895c38210e228d02cef41212d1e157427

Support override of the LIBAOM_TEST_DATA_PATH variable via
the CMake command line:

$ cmake path/to/aom -DAOM_TEST_DATA_PATH=path/to/test/data

Change-Id: Idb0f3394584c0d0dfab221b42c539f0ffb15dc65

Recently, sub8x8 inter mode decition functions have been
removed from the av1 codebase, so codebase does not allow
disabling cb4x4 anymore.

This makes pvq not working simply crashing
because we had disabled cb4x4 if pvq is enabled.
Hence, pvq has been fixed for cb4x4.

Also, if pvq is enabled, disable lgt and highbitdepth in the configure.

Change-Id: I2cb675c0dbc12bce60ed6a66c34ea3e907cc35b3

Change-Id: Ib5337dfa78b73059ad169ca98a07119aa991864b

WebM is the intended container here. The recent rollup
of libwebm regressed the output doctype.

Change-Id: I6e9e41bb59abf20f451e5576a4822fe06eb80478