1. 15 Sep, 2017 5 commits
    • Yushin Cho's avatar
      Fix a static analyzer warning · ee810273
      Yushin Cho authored
      Also fix asan warnings.
      
      Change-Id: I21fe3150635540abacb5b1b8928c6470db605035
      ee810273
    • Angie Chiang's avatar
      register_state_check: simplify Check() methods · 74acf004
      Angie Chiang authored
      - make Check() void as the EXPECT's are sufficient to document failure
      
      cumulatively this has the effect of avoiding reporting incorrect Check()
      failures due to earlier test failures.
      
      This CL is ported over from
      f8c27d164 register_state_check: simplify Check() methods
      
      Change-Id: I1b65aa769c69c2a52b2e0b363f1c4432965ee89f
      74acf004
    • Yi Luo's avatar
      Enhance intra pred unit test to verify rectangular pred · da9e4afe
      Yi Luo authored
      Add a macro to improve the readibility of test case. The
      coming test cases varying on mode/size would expand the
      list too large.
      
      Change-Id: I74171344098820b21090dd9b857229bdf2e77248
      da9e4afe
    • Zoe Liu's avatar
      Add encoder support for multi-layer GF 16 · 8dd1c980
      Zoe Liu authored
      Currently the use of the new multi-layer GF group of 16 is guarded by
      the macro USE_GF16_MULTI_LAYER, which is turned off. Hence this CL
      does not change any of the encoder behavior.
      
      Change-Id: I588cd34e19388337a2ecb0a0cb3f796a37647e24
      8dd1c980
    • Yunqing Wang's avatar
      Further refactor setup_ref_mv_list · d1121fa3
      Yunqing Wang authored
      This patch follows the previous refactoring patch, and further reduces
      the number of calls made to scan_row_mbmi and scan_col_mbmi by going
      through partition blocks instead of mi blocks. This patch doesn't change
      bitstream, which was proven by Borg test result.
      
      The baseline decoder speed test on 1080p clip showed that the average
      decoder speedup was 1.1%.(fps: 32.626 --> 32.994)
      
      Change-Id: Ic375ae5d682c7454e2f2a2fcf8baa6b4b438d9a6
      d1121fa3
  2. 14 Sep, 2017 1 commit
  3. 13 Sep, 2017 9 commits
    • Sarah Parker's avatar
      Use default reference gm params in error resilient mode · f289f9f5
      Sarah Parker authored
      This allows gm parameters to be written when error resilient mode
      is enabled but avoids depending on stored parameters from the
      previous frame.
      
      BUG=aomedia:741
      
      Change-Id: Iae455a346e0eebb18e2bcfadc8826c75aedfee99
      f289f9f5
    • David Michael Barr's avatar
      [CFL] Fix typedef-redefinition compiler warnings · 5b2021ea
      David Michael Barr authored
      Instead of forward-declaring AV1_COMMON and MACROBLOCKD,
      move the dependent struct and function prototype closer
      to where they are used and after these types are defined.
      
      Change-Id: I75f005b46ef322a6fcbc01377b8dded1637c5f73
      5b2021ea
    • Rupert Swarbrick's avatar
      Teach inspector about 4:1 block sizes · a5263757
      Rupert Swarbrick authored
      Change-Id: I5d60cc74233bf7ddf56bcd0c3e8b8d012a6e5a63
      a5263757
    • Rupert Swarbrick's avatar
      Hide repeated arguments in calls to count_segs in count_segs_sb · 114e81a3
      Rupert Swarbrick authored
      The calls to count_segs appear very different from each other, but
      this is really just because of line wrapping (enforced by the
      clang-format linter). This patch produces equivalent code but the
      results are far easier to read.
      
      Change-Id: I9d548a4988d4ef23f71fbd8afc855eb8a43f7bd5
      114e81a3
    • Rupert Swarbrick's avatar
      Simplify get_partition() implementation · 136d5c17
      Rupert Swarbrick authored
      This function is given a bsize and an mi array and has to figure out
      what partition to use to divide the given bsize in the direction of
      the sizes it finds in the mi array. (Since each block size can be
      reached by only one sequence of partitions, this can be done
      unambiguously)
      
      The previous version was correct, working by looking up entries in the
      partition_lookup array. Unfortunately, that lookup isn't quite enough
      when CONFIG_EXT_PARTITION_TYPES is true, so it then had to do some
      slightly confusing computations to fix things up after the fact.
      
      The new version should be more self-explanatory and doesn't work by
      looking things up in a magic array. It looks up the width and height
      corresponding to bsize and compares them with the width and height
      corresponding to the sb_type at mi_row,mi_col in the mi array. When
      CONFIG_EXT_PARTITION_TYPES is false, this is all you need, and the
      four corresponding cases can be found by a lookup in an array of 4
      elements.
      
      With extended partition types and a sufficiently large block, you have
      to do a bit more searching. For example, if bsize is BLOCK_16X16 and
      the subsize is BLOCK_8X8, the partition might be PARTITION_SPLIT, but
      it might be one of PARTITION_HORZ_A or PARTITION_VERT_A instead. The
      new code adds some comments to explain what's going on.
      
      A nice side-effect of rewriting get_partition in this way is that it
      lets us completely dispense with the partition_lookup array.
      
      The patch also fixes comments for the A/B extended partitions in
      enums.h, which were slightly backwards (a "horizontal split means two
      blocks vertically above one another)
      
      Change-Id: I4b48189103aa63e1859f25a15d7690d53ca7baf5
      136d5c17
    • David Barker's avatar
      aom-qm: Fix overflow in quantizer calculation · 568b7c7e
      David Barker authored
      By using a combination of a small qmlevel and large qindex,
      it is possible for the quantizer 'dqv' to end up > 2^15.
      This currently causes dqv to overflow, so widen its type
      to avoid that.
      
      Note that this is certainly an extreme case, but not entirely
      useless - if using a 32x32 transform, the dequantized value
      can be as small as dqv/2, which may still fit in 16 bits.
      
      Change-Id: I0451e70ba6b17620d94386a98d873f0a8c615635
      568b7c7e
    • Rupert Swarbrick's avatar
      Report a proper error when bitstream wrongly requests prev_frame_mvs · bdfb4a6f
      Rupert Swarbrick authored
      Using an assert (which was compiled out) meant we got to a
      use-after-free in bug 729.
      
      BUG=aomedia:729
      
      Change-Id: I4d0fa5e80322c395f94565c76e2285782c328505
      bdfb4a6f
    • Debargha Mukherjee's avatar
      Change/refactor compound mode handling for sub8x8 · 0f248c46
      Debargha Mukherjee authored
      Turn off compound modes as long as one of the dimensions
      is less than 8.
      
      Imapct on AWCY (0.05% increase in BDRATE)
      https://arewecompressedyet.com/?job=debargha-nocdef-sub8c8nc-0907%402017-09-07T20%3A28%3A38.251Z&job=debargha-nocdef-0907%402017-09-07T14%3A42%3A17.170Z
      
      Change-Id: I4a70890c04149246a50e60990dede21cb8052fad
      0f248c46
    • Yushin Cho's avatar
      Fix compile error when both of dist_8x8 and pvq are enabled · 39086c0b
      Yushin Cho authored
      Remove mistakenly leftover code from commit
      e30a47ca.
      
      Note that this change force-disables activity masking in PVQ until we can add some
      bitstream signaling for it.
      
      Change-Id: I5279f82e7977733ebc40f5aed844ecec1279992a
      39086c0b
  4. 12 Sep, 2017 7 commits
    • Zoe Liu's avatar
      Remove duplicate line of code · 10a051fc
      Zoe Liu authored
      Change-Id: Ie92a17d6c530bdd65464fbc599ce92561b8c0428
      10a051fc
    • Jingning Han's avatar
      Remove unnecessary rate cost setup in lv-map encoding · ba42e749
      Jingning Han authored
      This won't change the coding statistics.
      
      Change-Id: Ibe3790836c59462f830029528d88a6e615efa493
      ba42e749
    • Debargha Mukherjee's avatar
      Ensure consistent border extension before LR · fc9f3ccd
      Debargha Mukherjee authored
      Before LR the border extension needs to be consistent.
      Otherwise there will be inconsistency at the frame boundaries
      causing mismatches.
      
      BUG=aomedia:742
      BUG=aomedia:744
      BUG=aomedia:745
      
      Change-Id: I5b0c51aa1493c58f7acc706bf686ce711eadd75d
      fc9f3ccd
    • Nathan Egge's avatar
      Revert "Add an orthonormal 4-point Type-VII DST." · 5a5e1adb
      Nathan Egge authored
      This reverts commit 72c99e1a.
      
      No metrics on this commit.
      
      Change-Id: I9fc350b25e710c3d5d6d8299ab5348e8b31b39ea
      5a5e1adb
    • Nathan E. Egge's avatar
      Add an orthonormal 4-point Type-VII DST. · 72c99e1a
      Nathan E. Egge authored
      Replaces the orthonormal Type-IV DST with an orthonormal Type-VII DST
       in od_bin_fdst4() and od_bin_idst4()
      
      Change-Id: I4ff0888e740d8cc063a2e5deaeceef7cb0d80485
      72c99e1a
    • David Barker's avatar
      Clarify comment in av1_set_mb_mi() · ee0fd929
      David Barker authored
      The code currently pads the decoded frame width and height to a
      multiple of 8 luma pixels, but there is a TODO suggesting that
      this may be changed to only require a multiple of 4 in future.
      
      But, as per the comments on the linked bug, there are good reasons
      to keep the decoded width and height as multiples of 8. So delete
      the outdated TODO and instead outline the reasons why the current
      behaviour is helpful.
      
      BUG=aomedia:727
      
      Change-Id: I2340bbcd740afe74c2e6fb3cf2e7a420db2b4f40
      ee0fd929
    • Luc Trudeau's avatar
      Chroma Fix for Superblock CDF update · d7150530
      Luc Trudeau authored
      UV_INTRA_MODES must be used for chroma modes
      
      Change-Id: I3e72d16204d11062a850fd00fb6272358dd61aac
      d7150530
  5. 11 Sep, 2017 9 commits
    • Sarah Parker's avatar
      Tokenize and write mrc mask · 99e7daa2
      Sarah Parker authored
      This allows a mask for mrc-tx to be sent in the bitstream for
      inter or intra 32x32 transform blocks. The option to send the mask
      vs build it from the prediction signal is currently controlled with
      a macro. In the future, it is likely the macro will be removed and it
      will be possible for a block to select either method. The mask building
      functions are still placeholders and will be filled in in a followup.
      
      Change-Id: Ie27643ff172cc2b1a9b389fd503fe6bf7c9e21e3
      99e7daa2
    • Jingning Han's avatar
      Use per tile model update for coeff_br coding · e29c9260
      Jingning Han authored
      Change-Id: Ie52d52bc25e3fdfdea877349215431d8edc064a3
      e29c9260
    • Jingning Han's avatar
      Fix base range counter index in lv-map decoding · 2e40574e
      Jingning Han authored
      Fix the index order of br_idx.
      
      Change-Id: I55acda816d1ec33c25ca4c31b09976f5e6f9c562
      2e40574e
    • Soo-Chul Han's avatar
      add SEG_LVL_ZEROMV · a752d1d5
      Soo-Chul Han authored
      Change-Id: Icd04302886a4d12890d04f9f15563169a91e3a0d
      a752d1d5
    • Zoe Liu's avatar
      Add support of multi-layer GF group 16 to bit allocation · c3903ff2
      Zoe Liu authored
      Change-Id: I52a7ae7404f15f29a0a0b892884cf0edea619507
      c3903ff2
    • Zoe Liu's avatar
      Define coding parameters for GF group of 16 · 8679f417
      Zoe Liu authored
      Propose the coding structure for GF Group of 16 to use the following
      multi-layer design:
        1st Layer: Frame 0 and Frame 16 (ALTREF)
        2nd Layer: Frame 8 (ALTREF2)
        3rd Layer: Frame 4 and 12 (ALTREF2)
        4th Layer: Frame 2, 6, 10, and 14 (BWDREF)
        5th Layer: Frame 1, 3, 5, 7, 9, 11, 13, and 15
      
      This CL implements the reference frame update for a GF group of 16
      using a look-up table, which is different from the current
      implementation. The motivation behind is to try out various GF group
      coding structures simply through manipulating the look-up table,
      instead of making changes on swapping the reference indexes and
      associated flags throughout the codebase.
      
      Change-Id: I823edae1c26263e0e0642a580685a25e81caa0a9
      8679f417
    • Debargha Mukherjee's avatar
      Change vertical border to 1 (2-line buffer) · da46da8e
      Debargha Mukherjee authored
      Changes the macros SGRPROJ_BORDER_VERT and
      SGRPROJ_BORDER_VERT to 1 to use a single line border
      vertically - which will be equivalent to a 2-line buffer.
      
      Change-Id: I788d9dca53d3d492058914215acf61e9d3d3880d
      da46da8e
    • Steinar Midtskogen's avatar
      CDEF: Do not filter chroma if subsampling_x != subsampling_y · 1c1161f1
      Steinar Midtskogen authored
      Since CDEF looks uses the luma direction for chroma, CDEF would have
      to change significantly to support formats like 4:2:2.  The limited
      use of such formats does not justify the complexity to support this,
      so the simple solution is to mandate that the chroma planes aren't
      filtered if subsampling_x != subsampling_y.  Most of the visual gain
      is in luma, anyway.
      
      This also means that the chroma strengths and chroma skip condition
      shall not be sent if subsampling_x != subsampling_y.
      
      BUG=aomedia:720
      
      Change-Id: I35c184a6fe0908ae0fee1e74494b6904fa9a3c82
      1c1161f1
    • David Barker's avatar
      cdef-singlepass: Fix integer overflow · 0123bc7d
      David Barker authored
      When cdef-singlepass is enabled, it is possible to signal the
      CDEF parameters in such a way that we end up with unsigned
      integer overflow in constrain().
      
      Fix this by i) using signed instead of unsigned values,
      and ii) clamping the result to avoid going on to shift
      by a negative amount.
      
      Change-Id: Ib677b2d644e44000c54959f7280e646bf02054da
      0123bc7d
  6. 10 Sep, 2017 5 commits
    • Jingning Han's avatar
      Rework base range entropy coding in level map system · 87b01b5a
      Jingning Han authored
      Replace the truncated geometric distribution model with the grouped
      leaves structure for more efficient probability modeling.
      Each group has its own Geometric distribution
      
      This give us 0.2% gain on lowres
      
      Change-Id: If5c73dd429bd5183a8aa81042f8f56937b1d8a6a
      87b01b5a
    • Angie Chiang's avatar
      Re train nz_map prob · 698a6185
      Angie Chiang authored
      We got 0.07% gain on lowres
      
      Change-Id: I0aef14d16025d9933ec3d3b71086f3f55c81df66
      698a6185
    • Debargha Mukherjee's avatar
      Refactoring/simplification of buffers used for sgr · 1330dfd1
      Debargha Mukherjee authored
      Inlcudes miscellaneous cleanups, test fixes, and code reorganization
      for loop-restoration components.
      
      Change-Id: I5b2e6419234d945e6f4344b22636119b50df4054
      1330dfd1
    • Debargha Mukherjee's avatar
      Reduce/Eliminate line buffer for loop-restoration. · e168a783
      Debargha Mukherjee authored
      This patch forces the vertical filtering for the top and bottom
      rows of a processing unit for the Wiener filter to not use border
      more than what is set in the WIENER_BORDER_VERT macro.
      This macro is currently set at 0 to eliminate line buffer completely,
      but it could be increased to 1 or 2 to use limited line buffers
      if the coding efficiency is affected too much with a 0 line-buffer.
      
      Also, for the sgr filter we added the option of using overlapping
      windows horizonttally and vertically to improve coding efficiency.
      The vertical border used is set by the SGRPROJ_BORDER_VERT
      macro, while the horizontal border can be set by the
      SGRPROJ_BORDER_HORZ macro set at 2, the max needed. Currently we do not
      recommend changing SGRPROJ_BORDER_HORZ below 2.
      
      The overall line buffer requirement for LR is twice the max of
      WIENER_BORDER_VERT and SGRPROJ_BORDER_VERT.
      Currently both are set as 0, eliminating line buffers completely.
      
      Also this patch extends borders consistently before CDEF / LR.
      
      Change-Id: Ie58a98c784a0db547627b9cfcf55f018c30e8e79
      e168a783
    • Luc Trudeau's avatar
      Remove useless (void)s · db4ccd42
      Luc Trudeau authored
      Change-Id: I70a4dd8095276eb53050eacca2ee33ba39e7cc74
      db4ccd42
  7. 09 Sep, 2017 4 commits