1. 19 Oct, 2012 1 commit
    • Deb Mukherjee's avatar
      Some cleanups and fixes. · f3208f36
      Deb Mukherjee authored
      Separates the logic on transform type selection previously spread out
      over a number of files into a separate function. Currently the tx_type
      field in b_mode_info is not used, but still left in there to eventually
      use for signaling the transform type in the bitstream.
      
      Also, now for tx_type = DCT_DCT, the regular integer DCT is used, as
      opposed to the floating point DCT used in conjuction with hybrid
      transform.
      
      Results change somewhat due to the transform change, but are within
      reasonable limits. The hd/std-hd sets are slightly up, while derf/yt
      are slightly down.
      
      Change-Id: I5776840c2239ca2da31ca6cfd7fd1148dc5f9e0f
      f3208f36
  2. 17 Oct, 2012 3 commits
    • John Koleszar's avatar
      cosmetic: fix '= & ' construct · 3883dab0
      John Koleszar authored
      remove useless space after address-of operator.
      
      Change-Id: I1fb9e82e8d6cf87558fbd454fb5c0f87599ca2ab
      3883dab0
    • John Koleszar's avatar
      Move remaining per-frame data into partition 0 · 47a2154c
      John Koleszar authored
      This commit moves a bit of data that ended up packed with the
      modes/mv/residual partition during the change to interleaved encoding
      into partition 0 where it belongs.
      
      Change-Id: Ic711a378c58d9d6a17254384f492c213a15bad92
      47a2154c
    • John Koleszar's avatar
      Interleave modes/residual per macroblock · 6ef5a005
      John Koleszar authored
      Packs the bitstream with each mb's residual following its mode/mv
      information.
      
      TODO: There are still a few fields that should be packed into partition
      0 but are included in partition 1, due to them being serialized from
      write_kfmodes/pack_inter_mode_mvs, which execute after the first
      partition is finalized. These need to be separated out into a separate
      function, similar to mb_mode_mv_init() in decodemv.c.
      
      Change-Id: I43a46c363601ab36954d07ebe498760e1e2e3af4
      6ef5a005
  3. 12 Oct, 2012 1 commit
    • John Koleszar's avatar
      consolidate update_mb_segmentation_map data · 17fd972a
      John Koleszar authored
      The update_mb_segmentation_map flag was being signalled earlier than
      other data dependent on that flag. Consolidate this data so it's
      parsed within the same if-scope as the flag is originally parsed in.
      
      Change-Id: I10e90b4f511856445ef75a85a44ff441e1e5e672
      17fd972a
  4. 11 Oct, 2012 2 commits
  5. 09 Oct, 2012 2 commits
    • John Koleszar's avatar
      write_kfmodes: use update_skip_probs() · d94d2b75
      John Koleszar authored
      Use the common update_skip_probs() function rather than duplicating its
      logic in write_kf_modes().
      
      Change-Id: I2890a28f6907cb79ffe0fb21d20f0ef98b85cdd9
      d94d2b75
    • Ronald S. Bultje's avatar
      Selectable transform size try 2. · 9ca3c8b2
      Ronald S. Bultje authored
      Results: derf (vanilla or +hybridtx) +0.2% and (+hybrid16x16
      or +tx16x16) +0.7%-0.8%; HD (vanilla or +hybridtx) +0.1-0.2%
      and (+hybrid16x16 or +tx16x16) +1.4%, STD/HD (vanilla or +hybridtx)
      about even, and (+hybrid16x16 or +tx16x16) +0.8-1.0%.
      
      Change-Id: I03899e2f7a64e725a863f32e55366035ba77aa62
      9ca3c8b2
  6. 27 Sep, 2012 1 commit
    • Deb Mukherjee's avatar
      Entropy coding for hybrid transform · 3f5d60b3
      Deb Mukherjee authored
      Separates the entropy coding context models for 4x4, 8x8 and 16x16
      ADST variants.
      
      There is a small improvement for HD (hd/std-hd) by about 0.1-0.2%.
      Results on derf/yt are about the same, probably because there is not
      enough statistics.
      
      Results may improve somewhat once the initial probability tables are
      updated for the hybrid transforms which is coming soon.
      
      Change-Id: Ic7c0c62dacc68ef551054fdb575be8b8507d32a8
      3f5d60b3
  7. 07 Sep, 2012 2 commits
    • Paul Wilkins's avatar
      Partial merge of NEWBESTREFMV and NEW_MVREF. · 778ec421
      Paul Wilkins authored
      This commit merges those parts of the CONFIG_NEW_MVREF
      that specifically relate to choosing a better set of candidate
      MV references into the NEWBESTREFMV experiment.
      
      CONFIG_NEW_MVREF will then be used for changes relating
      to the explicit coding of a cost optimized MV reference in the
      bitstream as part of MV coding.
      
      Change-Id: Ied982c0ad72093eab29e38b8cd74d5c3d7458b10
      778ec421
    • Paul Wilkins's avatar
      MV reference changes · 38e1c791
      Paul Wilkins authored
      Extend experiment to use both vectors from MBs
      coded using compound prediction as candidates.
      
      In final sort only consider best 4 candidates
      for now but make sure 0,0 is always one of them.
      
      Other minor changes to new MV reference code.
      Pass in Mv list to vp8_find_best_ref_mvs().
      
      Change-Id: Ib96220c33c6b80bd1d5e0fbe8b68121be7997095
      38e1c791
  8. 06 Sep, 2012 1 commit
    • Deb Mukherjee's avatar
      New motion vector entropy coding · 00f9eb65
      Deb Mukherjee authored
      Adds a new experiment with redesigned/refactored motion vector entropy
      coding. The patch also takes a first step towards separating the
      integer and fractional pel components of a MV. However the fractional
      pel encoding still depends on the integer pel part and so they are
      not fully independent. Further experiments are in progress to see
      how much they can be decoupled without affecting performance.
      All components including entropy coding/decoding, costing for MV
      search, forward updates and backward updates to probability tables,
      have been implemented.
      
      Results so far:
      derf: +0.19%
      std-hd: +0.28%
      yt: +0.80%
      hd: +1.15%
      
      Patch: Simplifies the fractional pel models:
      derf: +0.284%
      std-hd: +0.289%
      yt: +0.849%
      hd: +1.254%
      
      Patch: Some changes in the models, rebased.
      derf: +0.330%
      std-hd: +0.306%
      yt: +0.816%
      hd: +1.225%
      
      Change-Id: I646b3c48f3587f4cc909639b78c3798da6402678
      00f9eb65
  9. 30 Aug, 2012 1 commit
    • Jingning Han's avatar
      hybrid transform of 16x16 dimension · de6dfa6b
      Jingning Han authored
      Enable ADST/DCT of dimension 16x16 for I16X16 modes. This change provides
      benefits mostly for hd sequences.
      
      Set up the framework for selectable transform dimension.
      
      Also allowing quantization parameter threshold to control the use
      of hybrid transform (This is currently disabled by setting threshold
      always above the quantization parameter. Adaptive thresholding can
      be built upon this, which will further improve the coding performance.)
      
      The coding performance gains (with respect to the codec that has all
      other configuration settings turned on) are
      
      derf:   0.013
      yt:     0.086
      hd:     0.198
      std-hd: 0.501
      
      Change-Id: Ibb4263a61fc74e0b3c345f54d73e8c73552bf926
      de6dfa6b
  10. 24 Aug, 2012 1 commit
    • Paul Wilkins's avatar
      New Motion Reference Search · 2d60bee1
      Paul Wilkins authored
      Alternative strategy for finding a list of candidate motion
      vectors to use as reference values in mv coding and as
      nearest and near.
      
      Sort by sad in vp8_find_best_ref_mvs() rather than just
      pick the best. Allow 0,0 as a best ref option but not a
      nearest or near unless there are no alternatives.
      
      Encode/Decode verified on at least some clips.
      
      Some commented out experimental and stats code still in place.
      
      Gain over existing code averages about 1% on derf (alll metrics)
      with improvement on all clips. Other test results pending.
      
      The entropy coding of the mode (nearest/near etc) still
      depends upon and requires the old "findnear" code so
      this needs looking at and may provide room for further gains.
      
      Change-Id: I871d7cba1d1c379c4bad9bcccce1fb19c46b8247
      2d60bee1
  11. 20 Aug, 2012 1 commit
    • Ronald S. Bultje's avatar
      Superblock coding. · 5d4cffb3
      Ronald S. Bultje authored
      This commit adds a pick_sb_mode() function which selects the best 32x32
      superblock coding mode. Then it selects the best per-MB modes, compares
      the two and encodes that in the bitstream.
      
      The bitstream coding is rather simplistic right now. At the SB level,
      we code a bit to indicate whether this block uses SB-coding (32x32
      prediction) or MB-coding (anything else), and then we follow with the
      actual modes. This could and should be modified in the future, but is
      omitted from this commit because it will likely involve reorganizing
      much more code rather than just adding SB coding, so it's better to let
      that be judged on its own merits.
      
      Gains on derf: about even, YT/HD: +0.75%, STD/HD: +1.5%.
      
      Change-Id: Iae313a7cbd8f75b3c66d04a68b991cb096eaaba6
      5d4cffb3
  12. 15 Aug, 2012 1 commit
    • Paul Wilkins's avatar
      Code clean up. · 77dc5c65
      Paul Wilkins authored
      Further cases of inconsistent naming convention.
      
      Change-Id: Id3411ecec6f01a4c889268a00f0c9fd5a92ea143
      77dc5c65
  13. 10 Aug, 2012 1 commit
  14. 07 Aug, 2012 1 commit
    • Yaowu Xu's avatar
      a new way of determining reference motion vector · 8b2f57d0
      Yaowu Xu authored
      Using surrounding reconstructed pixels from left and above to select
      best matching mv to use as reference motion vector for mv encoding.
      
      Test results:
             AVGPSNR  GLBPSNR VPXSSIM
      Derf:  1.107%   1.062%  0.992%
      Std-hd:1.209%   1.176%  1.029%
      
      Change-Id: I8f10e09ee6538c05df2fb9f069abcaf1edb3fca6
      8b2f57d0
  15. 06 Aug, 2012 1 commit
    • Christian Duvivier's avatar
      Add x86_64-darwin11-gcc target. · 82edabce
      Christian Duvivier authored
      This allows building on MountainLion as the 10.6 SDK has been
      removed from the latest Xcode version (4.4 4F250). Also fix
      all warnings for that build.
      
      Change-Id: Ib70bca4a25295f13595f0d10ea9f0229631de5a4
      82edabce
  16. 03 Aug, 2012 2 commits
    • Deb Mukherjee's avatar
      Merging in high_precision_mv experiment · 2af5473a
      Deb Mukherjee authored
      Merged in the high_precision_mv experiment to make it easier
      to work on new mv encoding strategies. Also removed
      coef_update_probs3().
      
      Change-Id: I82d3b0bb642419fe05dba82528bc9ba010e90924
      2af5473a
    • Daniel Kang's avatar
      16x16 DCT blocks. · fed8a183
      Daniel Kang authored
      Set on all 16x16 intra/inter modes
      
      Features:
      - Butterfly fDCT/iDCT
      - Loop filter does not filter internal edges with 16x16
      - Optimize coefficient function
      - Update coefficient probability function
      - RD
      - Entropy stats
      - 16x16 is a config option
      
      Have not tested with experiments.
      
      hd:     2.60%
      std-hd: 2.43%
      yt:     1.32%
      derf:   0.60%
      
      Change-Id: I96fb090517c30c5da84bad4fae602c3ec0c58b1c
      fed8a183
  17. 31 Jul, 2012 1 commit
    • Deb Mukherjee's avatar
      Merging and bug-fix in enhanced_interp experiment · 0ebf548c
      Deb Mukherjee authored
      Merged the enhanced_interp experiment.
      Found and fixed a bug in the include files framework, whereby
      certain encoder files were still using the old INTERP_EXTEND
      value of 3 instead of 4. The thresholds for mv range mcomp.c
      need a small adjustment to prevent crashes.
      
      The results are more or less unchanged.
      
      Change-Id: Iac5008390f1efc97ce1102fbb5f8989c847fb579
      0ebf548c
  18. 30 Jul, 2012 1 commit
    • Deb Mukherjee's avatar
      Adds support for switchable interpolation filters. · 52597441
      Deb Mukherjee authored
      Allows for swtiching/setting interpolation filters at the MB
      level. A frame level flag indicates whether to use a specifc
      filter for the entire frame or to signal the interpolation
      filter for each MB. When switchable filters are used, the
      encoder chooses between 8-tap and 8-tap sharp filters. The
      code currently has options to explore other variations as well,
      which will be cleaned up subsequently.
      
      One issue with the framework is that encoding is slow. I
      tried to do some tricks to speed things up but it is still slow.
      Decoding speed should not be affected since the number of
      filter taps remain unchanged.
      
      With the current version, we are up 0.5% on derf on average but
      some videos city/mobile improve by close to 4 and 2% respectively.
      If we did a full-search by turning the SEARCH_BEST_FILTER flag
      on, the results are somewhat better.
      
      The framework can be combined with filtered prediction, and I
      seek feedback regarding that.
      
      Rebased.
      
      Change-Id: I8f632cb2c111e76284140a2bd480945d6d42b77a
      52597441
  19. 27 Jul, 2012 1 commit
    • Deb Mukherjee's avatar
      Merges several experiments · 9984a155
      Deb Mukherjee authored
      The following five experiments are merged:
      
      newentropy
      newupdate
      adaptive_entropy (also includes a couple of parameter changes
                        that improves results a little
                        in common/entropymode.c and encoder/modecosts.c
                        that were not merged from the internal branch)
      newintramodes
      expanded_coef_context
      
      Change-Id: I8a142a831786ee9dc936f22be1d42a8bced7d270
      9984a155
  20. 17 Jul, 2012 1 commit
  21. 27 Jun, 2012 1 commit
    • Adrian Grange's avatar
      Added Prediction Filter to Mode Selection · bbc926dc
      Adrian Grange authored
      Added the ability to optionally filter the prediction data
      when inter modes are selected (excludes SPLITMV, for now).
      
      The mode selection loop considers both the filtered and
      non-filtered prediction data when choosing mode. The filter
      can be turned on/off at the frame-level, or signaled for
      each MB.
      
      Change-Id: I1b783c71d95a361ab36c761b07e8a6b06bc36822
      bbc926dc
  22. 26 Jun, 2012 1 commit
    • Deb Mukherjee's avatar
      Continued adaptive entropy coding · f3dff402
      Deb Mukherjee authored
      Incorporates mv_ref, mbsplit and second_mv into the adaptive
      entropy framework. The mv_ref framework has been modified from
      before.
      
      Adds some clean-ups and fixes.
      
      Results with the adaptive entropy experiment are currently up by
      +1.93% on derf; +2.33% std-hd and +1.87% yt-hd.
      
      Fixed a nasty intermittent bug.
      
      Change-Id: I4b1ac9f9483b48432597595195bfec05f31d1e39
      f3dff402
  23. 19 Jun, 2012 1 commit
  24. 15 Jun, 2012 1 commit
    • Deb Mukherjee's avatar
      Adaptive entropy coding of coefficients, modes, mv. · 1fe85a35
      Deb Mukherjee authored
      This patch incorporates adaptive entropy coding of coefficient tokens,
      and mode/mv information based on distributions encountered in a frame.
      Specifically, there is an initial forward update to the probabilities
      in the bitstream as before for coding the symbols in the frame, however
      at the end of decoding each frame, the forward update to the
      probabilities is reverted and instead the probabilities are updated
      towards the actual distributions encountered within the frame.
      The amount of update is weighted by the number of hits within each
      context.
      
      Results on derf/hd/std-hd are all up by 1.6%.
      
      On derf, the most of the gains come from coefficients, however for the
      hd and std-hd sets, the most of the gains come from the mode/mv
      information updates.
      
      Change-Id: I708c0e11fdacafee04940fe7ae159ba6844005fd
      1fe85a35
  25. 12 Jun, 2012 2 commits
    • Yaowu Xu's avatar
      changed to use a fixed number for update probabity · 074a38b1
      Yaowu Xu authored
      This commit is to remove two arrays, which contain the probabilities
      of how likely each probability in coef_probs table is updated. The
      commit changed to use a fixed number "252".
      
      Surprisedly, the overall impact on quality is close to zero, which
      basically says the two big static arrays are not helpful at all.
      derf: -0.016%, -0.020%
      std-hd: 0.000%, -0.013%
      yt: -0.022%, +0.007%
      yt-hd: -0.038%, +0.034%
      
      Change-Id: Ifee94d28a37dcab4f1d2b994bd5b07575be42b72
      074a38b1
    • Yaowu Xu's avatar
      Added the ability to accumulate coef stats across encodings · bb25083d
      Yaowu Xu authored
      This commit added the ability to accumulate the coef stats across
      different encodings using an intermediate binary stats files. The
      accumulation happens only the binary stats file exists in current
      directory. The encoder needs to be built with "ENTROPY_STATS" to
      allow the output. The commit also fixed a few formating issues in
      output stats file.
      
      Change-Id: Ib1a41180aa554845cf51e4421a230b128a3a82b4
      bb25083d
  26. 31 May, 2012 1 commit
    • Adrian Grange's avatar
      Fixed bug where invalid pointer is dereferenced · 04fa2ecd
      Adrian Grange authored
      Variables m & mi were being dereferenced when they might
      hold invalid values.
      
      The fix is simply to move these dereferences to after the
      point at which mb_row and mb_col are tested for validity.
      
      Change-Id: Ib16561efa9792dc469759936189ea379d374ad20
      04fa2ecd
  27. 26 May, 2012 1 commit
    • Yaowu Xu's avatar
      fixed one more compiling issue with VC · 2722cfb4
      Yaowu Xu authored
      One more compiling issue, only happened in Visual C under a specific
      combination of experiments.
      
      Change-Id: Iba0775dc0ea7342b556348a9cdf60a05a59e0241
      2722cfb4
  28. 25 May, 2012 1 commit
    • Yaowu Xu's avatar
      fixed a number of compiling issues · ea0e4f17
      Yaowu Xu authored
      the commit fixed a number of compiling issues when some epxeriments
      are turned on at the same time.
      
      Change-Id: Idb15b215e2d2a7d25f2707f99ef55a34e7301ce7
      ea0e4f17
  29. 23 May, 2012 1 commit
    • Yaowu Xu's avatar
      changed the way that default probs for 8x8 is set. · e9818bb6
      Yaowu Xu authored
      The commit changed how baseline 8x8 coefficient probabilities are
      initialized, to be consistent with the initialization of baseline
      4x4 coefficient probabilities.
      
      The commit does not have any effect on compression.
      
      Change-Id: Ifb3902b5dc0b0c2e6dc3aa5d4a6589d528e58355
      e9818bb6
  30. 15 May, 2012 2 commits
    • Ronald S. Bultje's avatar
      Rewrite reference frame costing in the RD loop. · 0b8a95a0
      Ronald S. Bultje authored
      I now see I didn't write a very long description, so let's do it
      here then. We took a pretty big quality hit (0.1-0.2%) from my
      recent fix of the inversion of arguments to vp8_cost_bit() in the
      RD reference frame costing. I looked into it and basically the
      costing prevented us from switching reference frames. This is of
      course silly, since each frame codes its own prob_intra_coded, so
      using last frame cost indications as a limiting factor can never
      be right.
      
      Here, I've rewritten that code to estimate costings based partially
      on statistics from progress on current frame encoding. Overall,
      this gives us a ~0.2%-0.3% improvement over what we had previously
      before my argument-inversion-fix, and thus about ~0.4% over current
      git (on derf-set), and a little more (0.5-1.0%) on HD/STD-HD/YT.
      
      Change-Id: I79ebd4ccec4d6edbf0e152d9590d103ba2747775
      0b8a95a0
    • Deb Mukherjee's avatar
      Adds new Directional Intra prediction modes. · c5ddb7f0
      Deb Mukherjee authored
      Adds 6 directional intra predictiom modes for 16x16 and 8x8 blocks.
      
      Change-Id: I25eccc0836f28d8d74922e4e9231568a648b47d1
      c5ddb7f0
  31. 09 May, 2012 1 commit
  32. 08 May, 2012 1 commit
    • Yaowu Xu's avatar
      a number of fixes to entropy stats collection · 54cf1d9a
      Yaowu Xu authored
      1. block types
      There are only three types of blocks for 8x8 transformed MBs, i.e. Y
      block with DC does not exist for 8x8 transformed MBs as all MB using
      8x8 transform have 2nd order haar transform. This commit introduced
      a new macro BLOCK_TYPES_8X8 to reflect such fact.
      
      2. context counters
      This commit also fixed the mixed of context_counters between 4x4 and
      8x8 transformed MBs. The mixed use of the counters leads me to think
      the existing the context probabilities were not properly generated
      from 8x8 transformed MBs.
      
      3. redundant collecting in recoding
      The commit also corrected the code that accumulates entropy stats by
      making sure stats only collected for final packing, not during the
      recode loop
      
      Change-Id: I029f09f8f60bd0c3240cc392ff5c6d05435e322c
      54cf1d9a