Icecast-IceS issueshttps://gitlab.xiph.org/xiph/icecast-ices/-/issues2017-11-05T22:14:59Zhttps://gitlab.xiph.org/xiph/icecast-ices/-/issues/2005[log.c:233]: (warning) Logical conjunction always evaluates to false: log_id ...2017-11-05T22:14:59ZDavid Binderman[log.c:233]: (warning) Logical conjunction always evaluates to false: log_id < 0 && log_id >= 25.Source code is
```
if (log_id < 0 && log_id >= LOG_MAXLOGS)
return;
```
Suggest swap `&&` for `||`
Source code is
```
if (log_id < 0 && log_id >= LOG_MAXLOGS)
return;
```
Suggest swap `&&` for `||`
Thomas B. RückerThomas B. Rückerhttps://gitlab.xiph.org/xiph/icecast-ices/-/issues/1901issue compiling ices from svn2017-11-05T22:14:59ZWaitman Gobbleissue compiling ices from svnon CentOS GNU/Linux 5.8, I am receiving an error building ices from svn trunk
```
# svn co http://svn.xiph.org/icecast/trunk/ices/ ices
# cd ices
# ./autogen.sh
# ./configure
# make
make[3]: Entering directory `/home/wgobble/software/xi...on CentOS GNU/Linux 5.8, I am receiving an error building ices from svn trunk
```
# svn co http://svn.xiph.org/icecast/trunk/ices/ ices
# cd ices
# ./autogen.sh
# ./configure
# make
make[3]: Entering directory `/home/wgobble/software/xiph/ices/src/log'
source='log.c' object='log.lo' libtool=yes \
depfile='.deps/log.Plo' tmpdepfile='.deps/log.TPlo' \
depmode=gcc3 /bin/sh ../../depcomp \
/bin/sh ../../libtool --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I/usr/include/libxml2 -pthread -g -O2 -c -o log.lo `test -f 'log.c' || echo './'`log.c
../../libtool: line 481: CDPATH: command not found
libtool: Version mismatch error. This is libtool 2.4.2, but the
libtool: definition of this LT_INIT comes from an older release.
libtool: You should recreate aclocal.m4 with macros from libtool 2.4.2
libtool: and run autoconf again.
make[3]: *** [log.lo] Error 63
```
using autoreconf to replace aclocal.m4 appears to fail with errors mentioning Roar.
I have not yet taken the time to track the issue down, but a *quick solution seems to work: copy /usr/local/bin/libtool into ices path (replace libtool in Ices path), then 'make' (and make install) continues without any issue.
Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/icecast-ices/-/issues/742stack-smashing crash with ices2 (or libshout)2019-04-19T11:32:52Zgtgbrstack-smashing crash with ices2 (or libshout)Hi,
another ices2 crash to report. This is ices-2.0.1 and libshout-2.1 on OpenBSD 3.8-stable/i386. The former has the patch for the re-fixed (ticket 720) applied.
Even though it seems to crash while being on the way to shut down anyway...Hi,
another ices2 crash to report. This is ices-2.0.1 and libshout-2.1 on OpenBSD 3.8-stable/i386. The former has the patch for the re-fixed (ticket 720) applied.
Even though it seems to crash while being on the way to shut down anyways, it might also be interesting to find out why it does that in the first place. Two other ices2 instances keep on streaming fine ... which also means that the computer (Athlon TB 1GHz) is rather busy anyways -- the cause could be related to being temporarily out of resources (CPU or I/O).
The stack is clobbered, making the backtrace on the (unfortunately unthreaded) coredump rather useless:
```
Program terminated with signal 6, Aborted.
#0 0x03eab559 in kill () from /usr/lib/libc.so.38.2
#1 0x03ee7463 in abort () from /usr/lib/libc.so.38.2
#2 0x03ecaf12 in recvmsg () from /usr/lib/libc.so.38.2
#3 0x4e524157 in ?? ()
#4 0x72747320 in ?? ()
#5 0x2f6d6165 in ?? ()
#6 0x73656369 in ?? ()
#7 0x736e695f in ?? ()
#8 0x636e6174 in ?? ()
#9 0x74735f65 in ?? ()
#10 0x6d616572 in ?? ()
#11 0x00000000 in ?? ()
#12 0x000003fc in ?? ()
#13 0x7e2a3db8 in ?? ()
#14 0x23e7bab9 in _C_tolower_ () from /usr/lib/libc.so.38.2
#15 0x3c005ac0 in environ ()
#16 0x00000005 in ?? ()
#17 0x23e7a27e in _C_toupper_ () from /usr/lib/libc.so.38.2
#18 0x0000000b in ?? ()
#19 0x23e7bab9 in _C_tolower_ () from /usr/lib/libc.so.38.2
#20 0x00000008 in ?? ()
#21 0x23e7a20f in _C_toupper_ () from /usr/lib/libc.so.38.2
#22 0x00000016 in ?? ()
#23 0x8624d0b0 in ?? ()
#24 0x7e2a3e28 in ?? ()
#25 0x8624d800 in ?? ()
#26 0x23e80c04 in ?? () from /usr/lib/libc.so.38.2
#27 0x00000002 in ?? ()
#28 0x7f3d7700 in ?? ()
#29 0x7e2a3e28 in ?? ()
#30 0x03ecafbf in recvmsg () from /usr/lib/libc.so.38.2
#31 0x23e7a20f in _C_toupper_ () from /usr/lib/libc.so.38.2
#32 0x83421000 in ?? ()
#33 0x00000005 in ?? ()
#34 0x03ecaf22 in recvmsg () from /usr/lib/libc.so.38.2
#35 0x00000014 in ?? ()
#36 0x000003fc in ?? ()
#37 0x7e2a3e18 in ?? ()
#38 0x23e7a18c in _C_toupper_ () from /usr/lib/libc.so.38.2
#39 0x00000014 in ?? ()
#40 0x000003fc in ?? ()
#41 0x2a4d1b6c in _thread_sigstack () from /usr/lib/libpthread.so.6.1
#42 0x03ecb9b2 in recvmsg () from /usr/lib/libc.so.38.2
#43 0x00000000 in ?? ()
#44 0x8624d800 in ?? ()
#45 0x00000000 in ?? ()
#46 0x23e80c04 in ?? () from /usr/lib/libc.so.38.2
#47 0x00002000 in ?? ()
#48 0x000003fc in ?? ()
#49 0x7e2a3e88 in ?? ()
#50 0x23e80c04 in ?? () from /usr/lib/libc.so.38.2
#51 0x00000016 in ?? ()
#52 0x7f3d7700 in ?? ()
#53 0x7e2a3e68 in ?? ()
#54 0x03eccde3 in realloc () from /usr/lib/libc.so.38.2
Previous frame inner to this frame (corrupt stack?)
```
Ices2's logs show this:
```
[2005-11-16 20:03:02] EROR stream/ices_instance_stream Send error: Socket error (Broken pipe)
[2005-11-16 20:03:02] DBUG input/input_flush_queue Input queue flush requested
[2005-11-16 20:03:02] WARN stream/ices_instance_stream Trying reconnect after server socket error
[2005-11-16 20:03:02] INFO signals/signal_hup_handler Flushing logs
[2005-11-16 20:03:02] INFO playlist-builtin/event_handler Moving to next file in playlist.
[2005-11-16 20:03:02] INFO playlist-builtin/playlist_read Currently playing "/home/maxx/streams/schrabbel/Plaid_-_Rest_Proof_Clockwork_Bonus_Track.ogg"
[2005-11-16 20:03:03] EROR stream/ices_instance_stream Failed to reconnect to localhost:8000 (Socket error)
[2005-11-16 20:03:05] WARN stream/ices_instance_stream Trying reconnect after server socket error
[2005-11-16 20:03:05] EROR stream/ices_instance_stream Failed to reconnect to localhost:8000 (Socket error)
[2005-11-16 20:03:07] WARN stream/ices_instance_stream Trying reconnect after server socket error
[2005-11-16 20:03:07] EROR stream/ices_instance_stream Failed to reconnect to localhost:8000 (Socket error)
[2005-11-16 20:03:09] WARN stream/ices_instance_stream Trying reconnect after server socket error
[2005-11-16 20:03:09] EROR stream/ices_instance_stream Failed to reconnect to localhost:8000 (Socket error)
[2005-11-16 20:03:11] WARN stream/ices_instance_stream Trying reconnect after server socket error
[2005-11-16 20:03:11] EROR stream/ices_instance_stream Failed to reconnect to localhost:8000 (Socket error)
[2005-11-16 20:03:11] EROR stream/ices_instance_stream Reconnect failed too many times, giving up.
[2005-11-16 20:03:11] WARN stream/ices_instance_stream Too many errors, shutting down
```
During the crash, Icecast logged the following:
```
[2005-11-16 20:03:02] INFO connection/_handle_source_request Source logging in at mountpoint "/schrabbelator.ogg"
[2005-11-16 20:03:02] WARN connection/_handle_source_request Mountpoint /schrabbelator.ogg in use
[2005-11-16 20:03:12] WARN source/get_next_buffer Disconnecting source due to socket timeout
[2005-11-16 20:03:12] INFO source/source_shutdown Source "/schrabbelator.ogg" exiting
[2005-11-16 20:03:19] INFO source/source_main listener count on /kolaradio.ogg now 1
```
I'm willing to test patches, even those that simply add debugging messages for further testing -- _mx on FreeNode/#icecast.
Moritz
Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/icecast-ices/-/issues/510metadata truncated at high ascii chars2019-04-19T11:32:52ZThomasmetadata truncated at high ascii chars```
Metadata containing high ascii chars (> 127) such german umlaute (ü ä ö) is not
sent to the icecast server correctly. The metadata-entry is truncated at the
position of the first special char.
For example "Soylent Grün" becomes "S...```
Metadata containing high ascii chars (> 127) such german umlaute (ü ä ö) is not
sent to the icecast server correctly. The metadata-entry is truncated at the
position of the first special char.
For example "Soylent Grün" becomes "Soylent Gr", "L'amé Immortelle"
becomes "L'am".
I saw this effect in ices2-beta4.
```Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/icecast-ices/-/issues/277resampling problems2019-04-19T11:32:53Zjstrawresampling problems```
ices seg faults every time we try to run it with resampling. Vakor suggested
that it is a config problem, so I am going to paste configs here.
we don't know if it is an ices or icecast problem, if this is the wrong place,
sorry, ple...```
ices seg faults every time we try to run it with resampling. Vakor suggested
that it is a config problem, so I am going to paste configs here.
we don't know if it is an ices or icecast problem, if this is the wrong place,
sorry, please put it where it should reside.
--ices resample--
<?xml version="1.0"?>
<ices>
<background>0</background> <!-- run in background? (unimplemented) -->
<logpath>/tmp</logpath> <!-- where logs, etc go. -->
<logfile>ices.log</logfile>
<loglevel>4</loglevel> <!-- 1=error,2=warn,3=info,4=debug -->
<consolelog>0</consolelog> <!-- logfile is ignored if this is set to 1 -->
<stream>
<metadata>
<name>Freenode Radio</name>
<genre>Various</genre>
<description></description>
</metadata>
<input>
<module>oss</module>
<param name="rate">44100</param> <!-- samplerate -->
<param name="channels">2</param> <!-- number of channels -->
<param name="device">/dev/dsp</param> <!-- audio device -->
<param name="metadata">1</param>
</input>
<instance>
<hostname>marconi.wopn.org</hostname>
<port>*****</port>
<password>*************</password>
<mount>/wopn-verylowbitrate.ogg</mount>
<encode>
<quality>-1</quality>
<samplerate>44100</samplerate>
<channels>2</channels>
</encode>
<downmix>1</downmix>
<resample>
<in-rate>44100</in-rate>
<out-rate>11025</out-rate>
</resample>
</instance>
<instance>
<hostname>marconi.wopn.org</hostname>
<port>*****</port>
<password>************</password>
<mount>/wopn-modem.ogg</mount>
<encode>
<quality>-1</quality>
<samplerate>44100</samplerate>
<channels>2</channels>
</encode>
<downmix>1</downmix>
<resample>
<in-rate>44100</in-rate>
<out-rate>22050</out-rate>
</resample>
</instance>
<instance>
<hostname>marconi.wopn.org</hostname>
<port>*****</port>
<password>*****************</password>
<mount>/wopn-broadband.ogg</mount>
<encode>
<quality>2</quality>
<samplerate>44100</samplerate>
<channels>2</channels>
</encode>
<downmix>0</downmix>
</instance>
</stream>
</ices>
-- icecast config --
<icecast>
<location>Freenode Radio</location>
<admin>staff@wopn.org</admin>
<limits>
<clients>50</clients>
<sources>4</sources>
<threadpool>5</threadpool>
<client-timeout>60</client-timeout>
<header-timeout>30</header-timeout>
<source-timeout>30</source-timeout>
</limits>
<source-password>****</source-password>
<relay-password>****</relay-password>
<directory>
<touch-freq>5</touch-freq>
<server>
<host>yp.icecast.org</host>
<touch-freq>15</touch-freq>
</server>
</directory>
<hostname>marconi.wopn.org</hostname>
<port>*****</port>
<!--<bind-address>127.0.0.1</bind-address>-->
<!--<master-server>127.0.0.1</master-server>-->
<!--<master-server-port>8001</master-server-port>-->
<!--<master-update-interval>120</master-update-interval>-->
<!--<master-password>hackme</master-password>-->
<fileserve>1</fileserve>
<paths>
<basedir>/home/wopn</basedir>
<logdir>/home/wopn/icecast_logs</logdir>
<webroot>/home/wopn/public_html</webroot>
</paths>
<logging>
<accesslog>access.log</accesslog>
<errorlog>error.log</errorlog>
<loglevel>4</loglevel> <!-- 4 Debug, 3 Info, 2 Warn, 1 Error -->
</logging>
<security>
<chroot>0</chroot>
<!-- <changeowner>
<user>nobody</user>
<group>nogroup</group>
</changeowner> -->
</security>
</icecast>
```Michael SmithMichael Smith