Icecast-IceS issueshttps://gitlab.xiph.org/xiph/icecast-ices/-/issues2023-11-09T23:51:22Zhttps://gitlab.xiph.org/xiph/icecast-ices/-/issues/2327Ices2 glitch between songs2023-11-09T23:51:22ZJhs JdfkIces2 glitch between songsI have a simple playlist of 2 opus small files,
when one ends and second drops I hear a long delay between the two,
and in Potplayer stops playing, as if it detected end of stream.
If I reconnect it plays the next song.
I believe data ...I have a simple playlist of 2 opus small files,
when one ends and second drops I hear a long delay between the two,
and in Potplayer stops playing, as if it detected end of stream.
If I reconnect it plays the next song.
I believe data is not sent back to back, otherwise it would be continuous, and client wouldn't notice anything.
in icecast2 I have tried setting 1MB buffer but still no luck.
Any idea?https://gitlab.xiph.org/xiph/icecast-ices/-/issues/2326reserved identifier violation2023-08-15T11:10:22ZMarkus Elfringreserved identifier violation:eyes: I would like to point out that identifiers like “[`__CONFIG_H__`](https://gitlab.xiph.org/xiph/icecast-ices/-/blob/2ccd03ac2ad984919bfe98e0c43a576c0317a943/src/cfgparse.h#L15 "Update candidate")” and “[`__INPUT_H__`](https://gitla...:eyes: I would like to point out that identifiers like “[`__CONFIG_H__`](https://gitlab.xiph.org/xiph/icecast-ices/-/blob/2ccd03ac2ad984919bfe98e0c43a576c0317a943/src/cfgparse.h#L15 "Update candidate")” and “[`__INPUT_H__`](https://gitlab.xiph.org/xiph/icecast-ices/-/blob/2ccd03ac2ad984919bfe98e0c43a576c0317a943/src/input.h#L14 "Another update candidate")” [do not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the compiler implementation.") to the expected naming convention of the C++ language standard.
:thought_balloon: Would you like to adjust your selection for unique names?https://gitlab.xiph.org/xiph/icecast-ices/-/issues/2325Git tag missing for 2.0.3 release2022-11-21T10:47:44ZtvogelGit tag missing for 2.0.3 releaseHi! It seems, there is no git tag for the 2.0.3 release, yet. Comparing the tar.bz2 contents, I think
git tag v2.0.3 58d89b5d135e07826f5777c6bf62645061dbae5c
should be the correct one. Would you mind to add that?Hi! It seems, there is no git tag for the 2.0.3 release, yet. Comparing the tar.bz2 contents, I think
git tag v2.0.3 58d89b5d135e07826f5777c6bf62645061dbae5c
should be the correct one. Would you mind to add that?Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/icecast-ices/-/issues/2324Allow building even if libxml2 doesn't ship /usr/bin/xml2-config2022-07-11T00:17:22ZUnit 193Allow building even if libxml2 doesn't ship /usr/bin/xml2-configHowdy,
It seems to be common practice to use pkg-config for these options, but currently if libxml2-dev doesn't contain xml2-config, the package fails to build. The patch below moves to using pkg-config directly.
```
Description: Migr...Howdy,
It seems to be common practice to use pkg-config for these options, but currently if libxml2-dev doesn't contain xml2-config, the package fails to build. The patch below moves to using pkg-config directly.
```
Description: Migrate from using xml2-config to pkg-config
Author: Unit 193 <unit193@debian.org>
---
configure.ac | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
--- a/configure.ac 2020-10-07 20:29:12.654454622 -0400
+++ b/configure.ac 2020-10-07 20:29:12.646454694 -0400
@@ -166,9 +166,12 @@
AC_CHECK_FUNCS([gettimeofday ftime])
-XIPH_PATH_XML
-XIPH_VAR_APPEND([XIPH_CFLAGS], [$XML_CFLAGS])
-XIPH_VAR_PREPEND([XIPH_LIBS], [$XML_LIBS])
+PKG_CHECK_MODULES([LIBXML2], [libxml-2.0], [], [
+ AC_MSG_ERROR([${LIBXML2_PKG_ERRORS}. libxml2 is required.])
+])
+
+CFLAGS="${CFLAGS} ${LIBXML2_CFLAGS}"
+LIBS="${LIBS} ${LIBXML2_LIBS}"
XIPH_PATH_SHOUT(, AC_MSG_ERROR([must have libshout installed!]))
if test "$SHOUT_THREADSAFE" != "yes"
```https://gitlab.xiph.org/xiph/icecast-ices/-/issues/2323Ignores 'allow-repeats' setting when checking ogg serial2021-12-17T22:18:42ZUnit 193Ignores 'allow-repeats' setting when checking ogg serialOriginally reported in Debian bug [463351](https://bugs.debian.org/463351):
> I currently have a playlist that contains one file, so obviously I need
> to set 'allow-repeats'. However, even with that setting enabled, it
> won't repeat ...Originally reported in Debian bug [463351](https://bugs.debian.org/463351):
> I currently have a playlist that contains one file, so obviously I need
> to set 'allow-repeats'. However, even with that setting enabled, it
> won't repeat the one file because the serial matches (even if I make a
> copy of the file and add the copy to the playlist).
>
> I've changed im_playlist.c so that it checks pl->allow_repeat before
> checking the serial (patch attached).
And as such, it seems we've carried the following patch for the past 10(!) years:
```
Description: allow 'allow-repeats' setting when checking ogg serial
Author: C. Chad Wallace <cwallace@lodgingcompany.com>
Origin: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=463351#10
Bug-Debian: http://bugs.debian.org/463351
Forwarded: not-needed
---
src/im_playlist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/src/im_playlist.c 2020-10-07 20:28:50.166655764 -0400
+++ b/src/im_playlist.c 2020-10-07 20:28:50.158655836 -0400
@@ -174,7 +174,7 @@
{
if (ogg_page_bos (&og))
{
- if (ogg_page_serialno (&og) == pl->current_serial)
+ if (!pl->allow_repeat && ogg_page_serialno (&og) == pl->current_serial)
LOG_WARN1 ("detected duplicate serial number reading \"%s\"", pl->filename);
pl->current_serial = ogg_page_serialno (&og);
```https://gitlab.xiph.org/xiph/icecast-ices/-/issues/2322SIGUSR1 triggers resample & encoder initialising2020-03-25T23:20:09ZJonas LiljestrandSIGUSR1 triggers resample & encoder initialisingHi,
I'm having a bit of trouble with glitching audio when the metadata is updated
which I suspect is caused by using the encode feature.
In the logfile I see this
```
[2020-03-25 23:11:43] INFO signals/signal_usr1_handler Metadata u...Hi,
I'm having a bit of trouble with glitching audio when the metadata is updated
which I suspect is caused by using the encode feature.
In the logfile I see this
```
[2020-03-25 23:11:43] INFO signals/signal_usr1_handler Metadata update requested
[2020-03-25 23:11:43] INFO metadata/metadata_thread_signal tag 1 is artist=Some artist
[2020-03-25 23:11:43] INFO metadata/metadata_thread_signal tag 2 is title=Some title
[2020-03-25 23:11:43] INFO metadata/metadata_thread_signal Updating metadata
[2020-03-25 23:11:43] INFO audio/resample_initialise Initialised resampler for 2 channels, from 48000 Hz to 44100 Hz
[2020-03-25 23:11:43] INFO encode/encode_initialise Encoder initialising in VBR mode: 2 channel(s), 44100 Hz, quality
```
Here is my full `ices.xml`
```
<ices>
<background>0</background>
<logpath>/home/pi/ices/</logpath>
<logfile>ices.log</logfile>
<logsize>2048</logsize>
<loglevel>3</loglevel>
<consolelog>0</consolelog>
<pidfile>/home/pi/ices/ices.pid</pidfile>
<stream>
<instance>
<hostname></hostname>
<port>8000</port>
<password></password>
<mount>/radio.ogg</mount>
<reconnectdelay>2</reconnectdelay>
<reconnectattempts>5</reconnectattempts>
<maxqueuelength>80</maxqueuelength>
<encode>
<samplerate>44100</samplerate>
<channels>2</channels>
</encode>
<resample>
<in-rate>48000</in-rate>
<out-rate>44100</out-rate>
</resample>
</instance>
<input>
<module>stdinpcm</module>
<param name="rate">48000</param>
<param name="channels">2</param>
<param name="metadata">1</param>
<param name="metadatafilename">/var/ices2/tmp/metadata</param>
</input>
</stream>
</ices>
```
I start ices2 with the following command.
```
arecord -D plughw:1 --channels 2 --format dat -t raw | ices2 ices/ices.xml
```
Which logs
```
Recording raw data 'stdin' : Signed 16 bit Little Endian, Rate 48000 Hz, Stereo
```https://gitlab.xiph.org/xiph/icecast-ices/-/issues/1891fix autoconf so configure --enable/--disable-foo is tri-state2017-11-05T22:14:58ZThomas B. Rückerfix autoconf so configure --enable/--disable-foo is tri-stateCurrently you can --enable-foo, but if foo headers are not there it will just switch off 'foo', instead of failing due to 'foo headers missing'.Currently you can --enable-foo, but if foo headers are not there it will just switch off 'foo', instead of failing due to 'foo headers missing'.Thomas B. RückerThomas B. Rücker