Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • I Icecast-IceS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 7
    • Issues 7
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Xiph.OrgXiph.Org
  • Icecast-IceS
  • Issues
  • #621
Closed
Open
Issue created Feb 27, 2005 by simeng@simeng

File descriptor leak. Ices 0.4.

When ices-0.4 is compiled with HAVE_LIBFAAD there is a leak when files are not handled by FAAD.


diff -ru ices-0.4-orig/src/in_mp4.c ices-0.4/src/in_mp4.c
--- ices-0.4-orig/src/in_mp4.c  Sat Jul 31 04:35:29 2004
+++ ices-0.4/src/in_mp4.c       Sun Feb 27 02:38:41 2005
@@ -68,8 +68,10 @@
   if (! self->filesize)
     return 1;
 
-  if ((mp4file = MP4Read(self->path, 0)) == MP4_INVALID_FILE_HANDLE)
+  if ((mp4file = MP4Read(self->path, 0)) == MP4_INVALID_FILE_HANDLE) {
+    MP4Close(mp4file);
     return 1;
+  }
 
   /* find audio stream */
   track = MP4_INVALID_TRACK_ID;
Assignee
Assign to
Time tracking