GitLab

This fixes a invalid pointer that will cause a double-unref
on the internal connection object.

Thanks to Jordan Erickson for supporthing this fix.

Closes: #2302

Thanks to Matthew Paradis for spotting it.

Fixes: #2304

This fixes the detection of end of response for XAudioCast and ICY.
In addition to better error reporting this also fixes libshout trying
TLS on password error.

This fixes the use of shout_set_metadata() in case TLS Mode is set to
AUTO or AUTO_NO_PLAIN and the server will accept our poke request.

This is normally the case for RoarAudio and XAudioCast and Shoutcast.
While for RoarAudio shout_set_metadata() is not implemented anyway it
is a core requirement for Shoutcast.

Closes: #2298

Thise adds a internal variable to store the actually used TLS mode
in contrast to the requested mode. This is important for AUTO mode
detection requests and error states as they will be different from
the request.

Closes: #2244

Prior to this commit mountpoint names were sent to the server as-is
both as part of the SOURCE (or eq.) request as well as part of out-
of-band meta data updates (ICY workaround). This was a source for a
potential problem e.g. if the mountpoint's name contains characters
from the reserved space. This commit fixes this by always doing the
escaping step before sending this to the server. This may only be a
problem in case GET parameters were included in the mountpoint URI.
However this was never part of the concept and was supported by the
main line Icecast2 server. Please test this and feel free to reopen
the ticket in case of any problems. Thank you for reporting and for
your work.

Closes: #2233

This adds super basic RoarAudio protocol support.
Some cleanup should be done before work is continued.

This adds a new error code SHOUTERR_RETRY.
This error code is used to tell the caller to re-enter the given call
again (possibly in future) to complete the operation.
The internal statemachine will re-enter the given call automatically
if possible or pass it to the calling instance.

This moves protocol specific code into proto_*.c.
It also adds a new queue.c which contains some queue helper functions.

This changes all references to ca_certificate into ca_file.
It also aligns them to ca_directory.

Note that this breaks the ABI and ABI to older revisions of this
development version. None of the affected calls are part of earlier
versions so no SONAME change is needed.

This adds support to metadata updates for TLS. This includes
both RFC2818 and RFC2817 support.

This also corrects the return value of shout_get_tls() which
falsely returned RFC2818 when RFC2817 mode was used and object
was already sucessfully connected (after 101 Switching Protocols).