Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • I Icecast-libshout
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 20
    • Issues 20
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Xiph.OrgXiph.Org
  • Icecast-libshout
  • Issues
  • #2330
Closed
Open
Issue created Feb 19, 2021 by Niko Dittmann@niko_d

URL-escaping ?=& in the mountpoint prevents mountpoints with query strings

#11b83da8 breaks connecting to mountpoints with a query string.

We are running a libshout compatible streaming server (at least we try ;) ) which uses a query string parameter to set a priority for a source client. This way a newly connecting source client can auto-kick an existing source client by providing a higher priority. I only now realized that by updating from my old libshout 2.3.1 on debian to 2.4.3 on ubuntu query string get now escaped:

SOURCE /m1?prio=3     HTTP/1.0  "ices/0.4 libshout/2.3.1"
SOURCE /m1%3fprio%3d3 HTTP/1.0  "ices/0.4 libshout/2.4.3"

I realize that the exact semantics of "mountpoints" aren't formaly specified (or are they?) but this completely broke my expectation of a mount point basically just being the path of a URL.

I opened an issue on github before I found the repo here. I'm gonna close over there and refer to this issue here.

Assignee
Assign to
Time tracking