Icecast-libshout issueshttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues2022-04-12T11:02:02Zhttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2328libshout 2.4.5 mp3 song metadata not updating2022-04-12T11:02:02ZStephen Fairchildlibshout 2.4.5 mp3 song metadata not updatingCalls to shout_set_metadata() are not updating the song metadata on the connected Icecast server when libshout 2.4.5 is streaming in mp3 format. My testing indicates the issue is not present in libshout version 2.4.4.
[libshout_mp3_met...Calls to shout_set_metadata() are not updating the song metadata on the connected Icecast server when libshout 2.4.5 is streaming in mp3 format. My testing indicates the issue is not present in libshout version 2.4.4.
[libshout_mp3_metadata.c](/uploads/d163d9fcbb3757b333b1ac2bb5d999e6/libshout_mp3_metadata.c)https://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2305Support for XAudioCast should be marked deprecated2019-05-14T16:44:29ZPhilipp SchafftSupport for XAudioCast should be marked deprecatedThe support should be for XAudioCast (Icecast 1.x) should be marked deprecated in libshout. Support for it may be removed with the next ABI change.
Related constants (grep for this in your source code): SHOUT_PROTOCOL_XAUDIOCASTThe support should be for XAudioCast (Icecast 1.x) should be marked deprecated in libshout. Support for it may be removed with the next ABI change.
Related constants (grep for this in your source code): SHOUT_PROTOCOL_XAUDIOCASTPhilipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2301libshout does hang in shout_open().2019-05-14T16:44:28ZPhilipp Schafftlibshout does hang in shout_open().libshout in 062373684bdeedf72d5432b0d247f459cb7fc285 hangs in calls to shout_open() in somecases.
In state SHOUT_STATE_RESP_PENDING it passes retry via (rc == SHOUTERR_SOCKET && self->retry). self->retry does not reach 0.
libshout is in...libshout in 062373684bdeedf72d5432b0d247f459cb7fc285 hangs in calls to shout_open() in somecases.
In state SHOUT_STATE_RESP_PENDING it passes retry via (rc == SHOUTERR_SOCKET && self->retry). self->retry does not reach 0.
libshout is in blocking mode with TLS in RFC2818 mode. Server is Icecast 2.4.1. The reply in question is 401 to a probe request. The non-probe request is sent but the socket is closed by the server.
Maybe related to HTTP keep-alive.Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2321In non-blocking mode login errors are not correctly reported2020-12-19T13:51:45ZPhilipp SchafftIn non-blocking mode login errors are not correctly reportedWhen libshout is configured in non-blocking mode fatal authentication errors are not forwarded correctly to the application. Instead retry is signalled.When libshout is configured in non-blocking mode fatal authentication errors are not forwarded correctly to the application. Instead retry is signalled.Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2310libshout connects to the same port for ICY data and metadata connections2020-10-21T08:50:27ZPhilipp Schafftlibshout connects to the same port for ICY data and metadata connectionslibshout does the port increment for ICY data connections unconditionally and therefore also for metadata connections.
This is part of the multi-topic ticket #2308.libshout does the port increment for ICY data connections unconditionally and therefore also for metadata connections.
This is part of the multi-topic ticket #2308.Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2309libshout's connection state maschine does not honor connection specific block...2020-10-21T08:50:27ZPhilipp Schafftlibshout's connection state maschine does not honor connection specific blocking settingCurrently libshout's connection state machine overrides it's own blocking setting in `shout_connection_connect()`:
```c
shout_connection_set_nonblocking(con, shout_get_nonblocking(shout));
```
Using the setting from the parent objec...Currently libshout's connection state machine overrides it's own blocking setting in `shout_connection_connect()`:
```c
shout_connection_set_nonblocking(con, shout_get_nonblocking(shout));
```
Using the setting from the parent object should only be the default if no specific value was set.
See also: #2308Philipp SchafftPhilipp Schafft2019-06-28https://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2306[PATCH] Fix build failure due to incorrect include ordering2020-10-21T08:50:27ZJoshua Root[PATCH] Fix build failure due to incorrect include orderingCommit 627da3d8 made an incorrect change: INCLUDES should have been changed to AM_CPPFLAGS rather than its contents being moved to AM_CFLAGS. Putting preprocessor flags in AM_CFLAGS results in them being passed in the wrong order relativ...Commit 627da3d8 made an incorrect change: INCLUDES should have been changed to AM_CPPFLAGS rather than its contents being moved to AM_CFLAGS. Putting preprocessor flags in AM_CFLAGS results in them being passed in the wrong order relative to CPPFLAGS, which results in build failure when a previous version of libshout is installed and its headers are in the same place as those of its dependencies.
Downstream bug: https://trac.macports.org/ticket/58466
[Makefile.am.patch](/uploads/bf297f2da070f02f791e49f0800e6205/Makefile.am.patch)Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2304libshout does not encode mount and password correctly in deprecated meta data...2018-12-14T13:53:20ZPhilipp Schafftlibshout does not encode mount and password correctly in deprecated meta data APIThe deprecated metadata API does not encode the mount point name (HTTP protocol) and the password (if ICY style password is used) correctly.The deprecated metadata API does not encode the mount point name (HTTP protocol) and the password (if ICY style password is used) correctly.Philipp SchafftPhilipp Schafft2018-12-14https://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2303libshout's state machine should be rewritten2019-05-14T16:44:28ZPhilipp Schafftlibshout's state machine should be rewrittenThe current state machine was designed without "modern" extensions (such as TLS and PUT) already around. For those extensions and modes it does not support full support and is error-prone.
Therefore the state machine should be rewritte...The current state machine was designed without "modern" extensions (such as TLS and PUT) already around. For those extensions and modes it does not support full support and is error-prone.
Therefore the state machine should be rewritten.
See also: #2301, #2153, and #2298.Philipp SchafftPhilipp Schafft2018-12-12https://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2302libshout allows setting ice*-headers with \n2019-05-14T16:44:29ZPhilipp Schafftlibshout allows setting ice*-headers with \nCurrently libshout allows setting ice* headers with \n. This allows the user to send any header they want.
This has likely **no security implications**. However it may result in unexpected behaviour.
libshout should reject invalid data...Currently libshout allows setting ice* headers with \n. This allows the user to send any header they want.
This has likely **no security implications**. However it may result in unexpected behaviour.
libshout should reject invalid data as those headers do not support any kind of escaping.https://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2299libshout with OpenSSL 1.1.02020-11-15T04:54:25Zmark burdettlibshout with OpenSSL 1.1.0tlschenkjr wrote @ https://github.com/xiph/Icecast-libshout/issues/7
> libshout contains calls to deprecated functions in openssl 1.1.0 and fails to build correctly. Any chance of that getting updated?
The error is: undefined reference...tlschenkjr wrote @ https://github.com/xiph/Icecast-libshout/issues/7
> libshout contains calls to deprecated functions in openssl 1.1.0 and fails to build correctly. Any chance of that getting updated?
The error is: undefined reference to `SSLeay_add_all_algorithms'https://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2153libshout should support PUT2019-05-14T16:44:29ZThomas B. Rückerlibshout should support PUTIcecast supports it since 2.4.0
Bonus points for implementing chunked and non-chunked mode, as 2.4-series doesn't support chunked, sadly.Icecast supports it since 2.4.0
Bonus points for implementing chunked and non-chunked mode, as 2.4-series doesn't support chunked, sadly.Philipp SchafftPhilipp Schafft