auth.c 35 KB
Newer Older
1 2 3 4 5
/* Icecast
 *
 * This program is distributed under the GNU General Public License, version 2.
 * A copy of this license is included with this source.
 *
6
 * Copyright 2000-2004, Jack Moffitt <jack@xiph.org,
7 8 9 10
 *                      Michael Smith <msmith@xiph.org>,
 *                      oddsock <oddsock@xiph.org>,
 *                      Karl Heyes <karl@xiph.org>
 *                      and others (see AUTHORS for details).
11
 * Copyright 2013-2018, Philipp "ph3-der-loewe" Schafft <lion@lion.leolix.org>,
12 13
 */

14
/**
Michael Smith's avatar
Michael Smith committed
15 16 17 18 19 20 21 22 23 24 25 26 27 28 29
 * Client authentication functions
 */

#ifdef HAVE_CONFIG_H
#include <config.h>
#endif

#include <stdlib.h>
#include <string.h>
#include <errno.h>
#include <stdio.h>

#include "auth.h"
#include "source.h"
#include "client.h"
30
#include "errors.h"
Michael Smith's avatar
Michael Smith committed
31
#include "cfgfile.h"
32
#include "stats.h"
Marvin Scholz's avatar
Marvin Scholz committed
33
#include "common/httpp/httpp.h"
34
#include "fserve.h"
35
#include "admin.h"
Philipp Schafft's avatar
Philipp Schafft committed
36
#include "acl.h"
Michael Smith's avatar
Michael Smith committed
37 38 39

#include "logging.h"
#define CATMODULE "auth"
40

Philipp Schafft's avatar
Philipp Schafft committed
41 42 43 44 45 46 47
/* data structures */
struct auth_stack_tag {
    size_t refcount;
    auth_t *auth;
    mutex_t lock;
    auth_stack_t *next;
};
48

Philipp Schafft's avatar
Philipp Schafft committed
49
/* code */
Marvin Scholz's avatar
Marvin Scholz committed
50
static void __handle_auth_client(auth_t *auth, auth_client *auth_user);
51

52 53 54 55 56 57 58 59 60 61 62 63 64
static mutex_t _auth_lock; /* protects _current_id */
static volatile unsigned long _current_id = 0;

static unsigned long _next_auth_id(void) {
    unsigned long id;

    thread_mutex_lock(&_auth_lock);
    id = _current_id++;
    thread_mutex_unlock(&_auth_lock);

    return id;
}

65 66 67 68 69 70 71 72 73 74 75 76 77 78 79
static const struct {
    auth_result result;
    const char *string;
} __auth_results[] = {
    {.result = AUTH_UNDEFINED,      .string = "undefined"},
    {.result = AUTH_OK,             .string = "ok"},
    {.result = AUTH_FAILED,         .string = "failed"},
    {.result = AUTH_RELEASED,       .string = "released"},
    {.result = AUTH_FORBIDDEN,      .string = "forbidden"},
    {.result = AUTH_NOMATCH,        .string = "no match"},
    {.result = AUTH_USERADDED,      .string = "user added"},
    {.result = AUTH_USEREXISTS,     .string = "user exists"},
    {.result = AUTH_USERDELETED,    .string = "user deleted"}
};

80 81
static const char *auth_result2str(auth_result res)
{
82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98
    size_t i;

    for (i = 0; i < (sizeof(__auth_results)/sizeof(*__auth_results)); i++) {
        if (__auth_results[i].result == res)
            return __auth_results[i].string;
    }

    return "(unknown)";
}

auth_result auth_str2result(const char *str)
{
    size_t i;

    for (i = 0; i < (sizeof(__auth_results)/sizeof(*__auth_results)); i++) {
        if (strcasecmp(__auth_results[i].string, str) == 0)
            return __auth_results[i].result;
99
    }
100 101

    return AUTH_FAILED;
102 103
}

Philipp Schafft's avatar
Philipp Schafft committed
104
static auth_client *auth_client_setup (client_t *client)
105
{
106
    /* This will look something like "Basic QWxhZGRpbjpvcGVuIHNlc2FtZQ==" */
107
    auth_client *auth_user;
108

Philipp Schafft's avatar
Philipp Schafft committed
109 110 111 112 113 114 115 116 117 118 119
    do {
        const char *header;
        char *userpass, *tmp;
        char *username, *password;

        /* check if we already have auth infos */
        if (client->username || client->password)
            break;

        header = httpp_getvar(client->parser, "authorization");

120 121 122
        if (header == NULL)
            break;

Philipp Schafft's avatar
Philipp Schafft committed
123
        if (strncmp(header, "Basic ", 6) == 0) {
124
            userpass = util_base64_decode (header+6);
Philipp Schafft's avatar
Philipp Schafft committed
125
            if (userpass == NULL) {
126
                ICECAST_LOG_WARN("Base64 decode of Authorization header \"%s\" failed",
127 128 129 130 131
                        header+6);
                break;
            }

            tmp = strchr(userpass, ':');
132
            if (tmp == NULL) {
Philipp Schafft's avatar
Philipp Schafft committed
133
                free(userpass);
134
                break;
135
            }
136 137 138 139

            *tmp = 0;
            username = userpass;
            password = tmp+1;
Philipp Schafft's avatar
Philipp Schafft committed
140 141
            client->username = strdup(username);
            client->password = strdup(password);
142 143
            free (userpass);
            break;
144
        }
145
        ICECAST_LOG_INFO("unhandled authorization header: %s", header);
146
    } while (0);
147

Philipp Schafft's avatar
Philipp Schafft committed
148
    auth_user = calloc(1, sizeof(auth_client));
149 150
    auth_user->client = client;
    return auth_user;
151 152
}

Michael Smith's avatar
Michael Smith committed
153

Philipp Schafft's avatar
Philipp Schafft committed
154
static void queue_auth_client (auth_client *auth_user)
155
{
156 157
    auth_t *auth;

158
    if (auth_user == NULL)
159 160
        return;
    auth_user->next = NULL;
Philipp Schafft's avatar
Philipp Schafft committed
161
    if (auth_user->client == NULL || auth_user->client->auth == NULL)
162
    {
Philipp Schafft's avatar
Philipp Schafft committed
163 164
        ICECAST_LOG_WARN("internal state is incorrect for %p", auth_user->client);
        return;
165
    }
Philipp Schafft's avatar
Philipp Schafft committed
166 167
    auth = auth_user->client->auth;
    ICECAST_LOG_DEBUG("...refcount on auth_t %s is now %d", auth->mount, (int)auth->refcount);
168 169 170 171 172 173 174 175 176 177
    if (auth->immediate) {
        __handle_auth_client(auth, auth_user);
    } else {
        thread_mutex_lock (&auth->lock);
        *auth->tailp = auth_user;
        auth->tailp = &auth_user->next;
        auth->pending_count++;
        ICECAST_LOG_INFO("auth on %s has %d pending", auth->mount, auth->pending_count);
        thread_mutex_unlock (&auth->lock);
    }
178
}
Michael Smith's avatar
Michael Smith committed
179 180


181 182 183
/* release the auth. It is referred to by multiple structures so this is
 * refcounted and only actual freed after the last use
 */
Philipp Schafft's avatar
Philipp Schafft committed
184
void auth_release (auth_t *authenticator) {
185 186
    size_t i;

187 188
    if (authenticator == NULL)
        return;
Michael Smith's avatar
Michael Smith committed
189

Philipp Schafft's avatar
Philipp Schafft committed
190
    thread_mutex_lock(&authenticator->lock);
191
    authenticator->refcount--;
Philipp Schafft's avatar
Philipp Schafft committed
192
    ICECAST_LOG_DEBUG("...refcount on auth_t %s is now %d", authenticator->mount, (int)authenticator->refcount);
193
    if (authenticator->refcount)
194
    {
Philipp Schafft's avatar
Philipp Schafft committed
195
        thread_mutex_unlock(&authenticator->lock);
196
        return;
197
    }
Michael Smith's avatar
Michael Smith committed
198

199
    /* cleanup auth thread attached to this auth */
Philipp Schafft's avatar
Philipp Schafft committed
200 201
    if (authenticator->running) {
        authenticator->running = 0;
202
        thread_mutex_unlock(&authenticator->lock);
Philipp Schafft's avatar
Philipp Schafft committed
203
        thread_join(authenticator->thread);
204
        thread_mutex_lock(&authenticator->lock);
Philipp Schafft's avatar
Philipp Schafft committed
205
    }
206

207
    if (authenticator->free)
Philipp Schafft's avatar
Philipp Schafft committed
208 209 210 211 212
        authenticator->free(authenticator);
    if (authenticator->type)
        xmlFree (authenticator->type);
    if (authenticator->role)
        xmlFree (authenticator->role);
213 214
    if (authenticator->management_url)
        xmlFree (authenticator->management_url);
Philipp Schafft's avatar
Philipp Schafft committed
215 216
    thread_mutex_unlock(&authenticator->lock);
    thread_mutex_destroy(&authenticator->lock);
217
    if (authenticator->mount)
Philipp Schafft's avatar
Philipp Schafft committed
218 219
        free(authenticator->mount);
    acl_release(authenticator->acl);
220
    config_clear_http_header(authenticator->http_headers);
221 222 223 224 225 226

    for (i = 0; i < authenticator->filter_origin_len; i++) {
        free(authenticator->filter_origin[i].origin);
    }
    free(authenticator->filter_origin);

Philipp Schafft's avatar
Philipp Schafft committed
227
    free(authenticator);
Michael Smith's avatar
Michael Smith committed
228 229
}

Philipp Schafft's avatar
Philipp Schafft committed
230 231 232 233 234 235 236 237 238 239 240
/* increment refcount on the auth.
 */
void    auth_addref (auth_t *authenticator) {
    if (authenticator == NULL)
        return;

    thread_mutex_lock (&authenticator->lock);
    authenticator->refcount++;
    ICECAST_LOG_DEBUG("...refcount on auth_t %s is now %d", authenticator->mount, (int)authenticator->refcount);
    thread_mutex_unlock (&authenticator->lock);
}
Michael Smith's avatar
Michael Smith committed
241

242
static void auth_client_free (auth_client *auth_user)
Michael Smith's avatar
Michael Smith committed
243
{
244
    if (!auth_user)
245
        return;
246 247 248

    free(auth_user->alter_client_arg);
    free(auth_user);
Michael Smith's avatar
Michael Smith committed
249 250 251
}


252
/* verify that the client is still connected. */
253 254 255
static int is_client_connected (client_t *client) {
/* As long as sock_active() is broken we need to disable this:

256 257
    int ret = 1;
    if (client)
Philipp Schafft's avatar
Philipp Schafft committed
258
        if (sock_active(client->con->sock) == 0)
259 260
            ret = 0;
    return ret;
261 262
*/
    return 1;
263 264
}

Philipp Schafft's avatar
Philipp Schafft committed
265
static auth_result auth_new_client (auth_t *auth, auth_client *auth_user) {
266
    client_t *client = auth_user->client;
Philipp Schafft's avatar
Philipp Schafft committed
267
    auth_result ret = AUTH_FAILED;
268

269 270
    /* make sure there is still a client at this point, a slow backend request
     * can be avoided if client has disconnected */
Philipp Schafft's avatar
Philipp Schafft committed
271
    if (is_client_connected(client) == 0) {
272
        ICECAST_LOG_DEBUG("client is no longer connected");
273
        client->respcode = 400;
274 275
        auth_release (client->auth);
        client->auth = NULL;
Philipp Schafft's avatar
Philipp Schafft committed
276
        return AUTH_FAILED;
277
    }
Philipp Schafft's avatar
Philipp Schafft committed
278 279 280 281

    if (auth->authenticate_client) {
        ret = auth->authenticate_client(auth_user);
        if (ret != AUTH_OK)
282 283 284
        {
            auth_release (client->auth);
            client->auth = NULL;
Philipp Schafft's avatar
Philipp Schafft committed
285
            return ret;
286
        }
Michael Smith's avatar
Michael Smith committed
287
    }
Philipp Schafft's avatar
Philipp Schafft committed
288
    return ret;
Michael Smith's avatar
Michael Smith committed
289 290
}

291

292
/* wrapper function for auth thread to drop client connections
293
 */
Philipp Schafft's avatar
Philipp Schafft committed
294
static auth_result auth_remove_client(auth_t *auth, auth_client *auth_user)
Michael Smith's avatar
Michael Smith committed
295
{
296
    client_t *client = auth_user->client;
Philipp Schafft's avatar
Philipp Schafft committed
297
    auth_result ret = AUTH_RELEASED;
298

299 300
    (void)auth;

Philipp Schafft's avatar
Philipp Schafft committed
301 302
    if (client->auth->release_client)
        ret = client->auth->release_client(auth_user);
303

Philipp Schafft's avatar
Philipp Schafft committed
304
    auth_release(client->auth);
305
    client->auth = NULL;
306

Philipp Schafft's avatar
Philipp Schafft committed
307 308 309
    /* client is going, so auth is not an issue at this point */
    acl_release(client->acl);
    client->acl = NULL;
310

Philipp Schafft's avatar
Philipp Schafft committed
311
    return ret;
312
}
Michael Smith's avatar
Michael Smith committed
313

314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362
static inline int __handle_auth_client_alter(auth_t *auth, auth_client *auth_user)
{
    client_t *client = auth_user->client;
    const char *uuid = NULL;
    const char *location = NULL;
    int http_status = 0;

    void client_send_redirect(client_t *client, const char *uuid, int status, const char *location);

    switch (auth_user->alter_client_action) {
        case AUTH_ALTER_NOOP:
            return 0;
        break;
        case AUTH_ALTER_REWRITE:
            free(client->uri);
            client->uri = auth_user->alter_client_arg;
            auth_user->alter_client_arg = NULL;
            return 0;
        break;
        case AUTH_ALTER_REDIRECT:
        /* fall through */
        case AUTH_ALTER_REDIRECT_SEE_OTHER:
            uuid = "be7fac90-54fb-4673-9e0d-d15d6a4963a2";
            http_status = 303;
            location = auth_user->alter_client_arg;
        break;
        case AUTH_ALTER_REDIRECT_TEMPORARY:
            uuid = "4b08a03a-ecce-4981-badf-26b0bb6c9d9c";
            http_status = 307;
            location = auth_user->alter_client_arg;
        break;
        case AUTH_ALTER_REDIRECT_PERMANENT:
            uuid = "36bf6815-95cb-4cc8-a7b0-6b4b0c82ac5d";
            http_status = 308;
            location = auth_user->alter_client_arg;
        break;
        case AUTH_ALTER_SEND_ERROR:
            client_send_error_by_uuid(client, auth_user->alter_client_arg);
            return 1;
        break;
    }

    if (uuid && location && http_status) {
        client_send_redirect(client, uuid, http_status, location);
        return 1;
    }

    return -1;
}
363 364 365 366 367 368 369 370 371 372
static void __handle_auth_client (auth_t *auth, auth_client *auth_user) {
    auth_result result;

    if (auth_user->process) {
        result = auth_user->process(auth, auth_user);
    } else {
        ICECAST_LOG_ERROR("client auth process not set");
        result = AUTH_FAILED;
    }

373 374
    ICECAST_LOG_DEBUG("client %p on auth %p role %s processed: %s", auth_user->client, auth, auth->role, auth_result2str(result));

375 376 377 378
    if (result == AUTH_OK) {
        if (auth_user->client->acl)
            acl_release(auth_user->client->acl);
        acl_addref(auth_user->client->acl = auth->acl);
379
        if (auth->role && !auth_user->client->role) /* TODO: Handle errors here */
380 381 382
            auth_user->client->role = strdup(auth->role);
    }

383 384 385 386 387
    if (result != AUTH_NOMATCH) {
        if (__handle_auth_client_alter(auth, auth_user) == 1)
            return;
    }

388 389 390 391 392 393 394 395
    if (result == AUTH_NOMATCH && auth_user->on_no_match) {
        auth_user->on_no_match(auth_user->client, auth_user->on_result, auth_user->userdata);
    } else if (auth_user->on_result) {
        auth_user->on_result(auth_user->client, auth_user->userdata, result);
    }

    auth_client_free (auth_user);
}
Michael Smith's avatar
Michael Smith committed
396

397 398 399
/* The auth thread main loop. */
static void *auth_run_thread (void *arg)
{
400 401
    auth_t *auth = arg;

402
    ICECAST_LOG_INFO("Authentication thread started");
403 404 405 406 407 408 409 410 411
    while (1) {
        thread_mutex_lock(&auth->lock);

        if (!auth->running) {
            thread_mutex_unlock(&auth->lock);
            break;
        }

        if (auth->head) {
412
            auth_client *auth_user;
Michael Smith's avatar
Michael Smith committed
413

414 415 416 417 418 419 420
            /* may become NULL before lock taken */
            auth_user = (auth_client*)auth->head;
            if (auth_user == NULL)
            {
                thread_mutex_unlock (&auth->lock);
                continue;
            }
421
            ICECAST_LOG_DEBUG("%d client(s) pending on %s (role %s)", auth->pending_count, auth->mount, auth->role);
422 423 424 425
            auth->head = auth_user->next;
            if (auth->head == NULL)
                auth->tailp = &auth->head;
            auth->pending_count--;
426
            thread_mutex_unlock(&auth->lock);
427
            auth_user->next = NULL;
Michael Smith's avatar
Michael Smith committed
428

429
            __handle_auth_client(auth, auth_user);
Philipp Schafft's avatar
Philipp Schafft committed
430

431
            continue;
432 433
        } else {
            thread_mutex_unlock(&auth->lock);
434
        }
Philipp Schafft's avatar
Philipp Schafft committed
435
        thread_sleep (150000);
Michael Smith's avatar
Michael Smith committed
436
    }
437
    ICECAST_LOG_INFO("Authentication thread shutting down");
Philipp Schafft's avatar
Philipp Schafft committed
438
    return NULL;
439
}
Michael Smith's avatar
Michael Smith committed
440 441


Philipp Schafft's avatar
Philipp Schafft committed
442
/* Add a client.
443
 */
Philipp Schafft's avatar
Philipp Schafft committed
444 445
static void auth_add_client(auth_t *auth, client_t *client, void (*on_no_match)(client_t *client, void (*on_result)(client_t *client, void *userdata, auth_result result), void *userdata), void (*on_result)(client_t *client, void *userdata, auth_result result), void *userdata) {
    auth_client *auth_user;
446
    auth_matchtype_t matchtype;
447 448
    const char *origin;
    size_t i;
449

450 451
    ICECAST_LOG_DEBUG("Trying to add client %p to auth %p's (role %s) queue.", client, auth, auth->role);

Philipp Schafft's avatar
Philipp Schafft committed
452 453
    /* TODO: replace that magic number */
    if (auth->pending_count > 100) {
454
        ICECAST_LOG_WARN("too many clients awaiting authentication on auth %p", auth);
455
        client_send_error_by_id(client, ICECAST_ERROR_AUTH_BUSY);
Philipp Schafft's avatar
Philipp Schafft committed
456
        return;
457 458
    }

459
    if (auth->filter_method[client->parser->req_type] == AUTH_MATCHTYPE_NOMATCH) {
Philipp Schafft's avatar
Philipp Schafft committed
460 461 462 463
        if (on_no_match) {
           on_no_match(client, on_result, userdata);
        } else if (on_result) {
           on_result(client, userdata, AUTH_NOMATCH);
464
        }
465 466 467
        return;
    }

468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492
    /* Filter for CORS "Origin".
     *
     * CORS actually knows about non-CORS requests and assigned the "null"
     * location to them.
     */
    origin = httpp_getvar(client->parser, "origin");
    if (!origin)
        origin = "null";

    matchtype = auth->filter_origin_policy;
    for (i = 0; i < auth->filter_origin_len; i++) {
        if (strcmp(auth->filter_origin[i].origin, origin) == 0) {
            matchtype = auth->filter_origin[i].type;
            break;
        }
    }
    if (matchtype == AUTH_MATCHTYPE_NOMATCH) {
        if (on_no_match) {
            on_no_match(client, on_result, userdata);
        } else if (on_result) {
            on_result(client, userdata, AUTH_NOMATCH);
        }
        return;
    }

493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520
    if (client->admin_command == ADMIN_COMMAND_ERROR) {
        /* this is a web/ client */
        matchtype = auth->filter_web_policy;
    } else {
        /* this is a admin/ client */
        size_t i;

        matchtype = AUTH_MATCHTYPE_UNUSED;

        for (i = 0; i < (sizeof(auth->filter_admin)/sizeof(*(auth->filter_admin))); i++) {
            if (auth->filter_admin[i].type != AUTH_MATCHTYPE_UNUSED && auth->filter_admin[i].command == client->admin_command) {
                matchtype = auth->filter_admin[i].type;
                break;
            }
        }

        if (matchtype == AUTH_MATCHTYPE_UNUSED)
            matchtype = auth->filter_admin_policy;
    }
    if (matchtype == AUTH_MATCHTYPE_NOMATCH) {
        if (on_no_match) {
           on_no_match(client, on_result, userdata);
        } else if (on_result) {
           on_result(client, userdata, AUTH_NOMATCH);
        }
        return;
    }

Philipp Schafft's avatar
Philipp Schafft committed
521 522 523 524 525 526 527
    auth_release(client->auth);
    auth_addref(client->auth = auth);
    auth_user = auth_client_setup(client);
    auth_user->process = auth_new_client;
    auth_user->on_no_match = on_no_match;
    auth_user->on_result = on_result;
    auth_user->userdata = userdata;
528
    ICECAST_LOG_DEBUG("adding client %p for authentication on %p", client, auth);
Philipp Schafft's avatar
Philipp Schafft committed
529
    queue_auth_client(auth_user);
530 531
}

532 533 534 535 536 537 538
static void __auth_on_result_destroy_client(client_t *client, void *userdata, auth_result result)
{
    (void)userdata, (void)result;

    client_destroy(client);
}

539 540 541
/* determine whether we need to process this client further. This
 * involves any auth exit, typically for external auth servers.
 */
Philipp Schafft's avatar
Philipp Schafft committed
542 543 544
int auth_release_client (client_t *client) {
    if (!client->acl)
        return 0;
545

Philipp Schafft's avatar
Philipp Schafft committed
546 547 548
    if (client->auth && client->auth->release_client) {
        auth_client *auth_user = auth_client_setup(client);
        auth_user->process = auth_remove_client;
549
        auth_user->on_result = __auth_on_result_destroy_client;
Philipp Schafft's avatar
Philipp Schafft committed
550 551 552 553 554
        queue_auth_client(auth_user);
        return 1;
    } else if (client->auth) {
        auth_release(client->auth);
        client->auth = NULL;
555
    }
Philipp Schafft's avatar
Philipp Schafft committed
556 557 558

    acl_release(client->acl);
    client->acl = NULL;
559 560
    return 0;
}
561 562


Karl Heyes's avatar
Karl Heyes committed
563
static int get_authenticator (auth_t *auth, config_options_t *options)
564
{
565 566
    if (auth->type == NULL)
    {
567
        ICECAST_LOG_WARN("no authentication type defined");
568 569
        return -1;
    }
570 571
    do
    {
572
        ICECAST_LOG_DEBUG("type is %s", auth->type);
573

Philipp Schafft's avatar
Philipp Schafft committed
574
        if (strcmp(auth->type, AUTH_TYPE_URL) == 0) {
575
#ifdef HAVE_CURL
Philipp Schafft's avatar
Philipp Schafft committed
576
            if (auth_get_url_auth(auth, options) < 0)
Karl Heyes's avatar
Karl Heyes committed
577
                return -1;
578
            break;
579
#else
580
            ICECAST_LOG_ERROR("Auth URL disabled");
Karl Heyes's avatar
Karl Heyes committed
581
            return -1;
582
#endif
Philipp Schafft's avatar
Philipp Schafft committed
583 584 585 586 587 588 589 590 591 592 593 594 595 596
        } else if (strcmp(auth->type, AUTH_TYPE_HTPASSWD) == 0) {
            if (auth_get_htpasswd_auth(auth, options) < 0)
                return -1;
            break;
        } else if (strcmp(auth->type, AUTH_TYPE_ANONYMOUS) == 0) {
            if (auth_get_anonymous_auth(auth, options) < 0)
                return -1;
            break;
        } else if (strcmp(auth->type, AUTH_TYPE_STATIC) == 0) {
            if (auth_get_static_auth(auth, options) < 0)
                return -1;
            break;
        } else if (strcmp(auth->type, AUTH_TYPE_LEGACY_PASSWORD) == 0) {
            if (auth_get_static_auth(auth, options) < 0)
Karl Heyes's avatar
Karl Heyes committed
597
                return -1;
598
            break;
599
        }
Karl Heyes's avatar
Karl Heyes committed
600

601
        ICECAST_LOG_ERROR("Unrecognised authenticator type: \"%s\"", auth->type);
Karl Heyes's avatar
Karl Heyes committed
602
        return -1;
603 604
    } while (0);

Karl Heyes's avatar
Karl Heyes committed
605
    return 0;
606
}
607 608


609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649
static inline void auth_get_authenticator__filter_admin(auth_t *auth, xmlNodePtr node, size_t *filter_admin_index, const char *name, auth_matchtype_t matchtype)
{
    char * tmp = (char*)xmlGetProp(node, XMLSTR(name));

    if (tmp) {
        char *cur = tmp;
        char *next;

        while (cur) {
            next = strstr(cur, ",");
            if (next) {
                *next = 0;
                next++;
                for (; *next == ' '; next++);
            }

            if (*filter_admin_index < (sizeof(auth->filter_admin)/sizeof(*(auth->filter_admin)))) {
                auth->filter_admin[*filter_admin_index].command = admin_get_command(cur);
                switch (auth->filter_admin[*filter_admin_index].command) {
                    case ADMIN_COMMAND_ERROR:
                        ICECAST_LOG_ERROR("Can not add unknown %s command to role.", name);
                    break;
                    case ADMIN_COMMAND_ANY:
                        auth->filter_admin_policy = matchtype;
                    break;
                    default:
                        auth->filter_admin[*filter_admin_index].type = matchtype;
                        (*filter_admin_index)++;
                    break;
                }
            } else {
                ICECAST_LOG_ERROR("Can not add more %s commands to role.", name);
            }

            cur = next;
        }

        free(tmp);
    }
}

650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692
static inline void auth_get_authenticator__filter_origin(auth_t *auth, xmlNodePtr node, const char *name, auth_matchtype_t matchtype)
{
    char * tmp = (char*)xmlGetProp(node, XMLSTR(name));

    if (tmp) {
        char *cur = tmp;
        char *next;

        while (cur) {
            next = strstr(cur, ",");
            if (next) {
                *next = 0;
                next++;
                for (; *next == ' '; next++);
            }

            if (strcmp(cur, "*") == 0) {
                auth->filter_origin_policy = matchtype;
            } else {
                void *n = realloc(auth->filter_origin, (auth->filter_origin_len + 1)*sizeof(*auth->filter_origin));
                if (!n) {
                    ICECAST_LOG_ERROR("Can not allocate memory. BAD.");
                    break;
                }

                auth->filter_origin = n;
                auth->filter_origin[auth->filter_origin_len].type = matchtype;
                auth->filter_origin[auth->filter_origin_len].origin = strdup(cur);
                if (auth->filter_origin[auth->filter_origin_len].origin) {
                    auth->filter_origin_len++;
                } else {
                    ICECAST_LOG_ERROR("Can not allocate memory. BAD.");
                    break;
                }
            }

            cur = next;
        }

        free(tmp);
    }
}

693 694 695 696 697 698 699 700 701 702 703 704 705 706
static inline void auth_get_authenticator__init_method(auth_t *auth, int *method_inited, auth_matchtype_t init_with)
{
    size_t i;

    if (*method_inited)
        return;

    for (i = 0; i < (sizeof(auth->filter_method)/sizeof(*auth->filter_method)); i++)
        auth->filter_method[i] = init_with;

    *method_inited = 1;
}

static inline int auth_get_authenticator__filter_method(auth_t *auth, xmlNodePtr node, const char *name, auth_matchtype_t matchtype, int *method_inited, auth_matchtype_t init_with)
707 708 709 710 711 712
{
    char * tmp = (char*)xmlGetProp(node, XMLSTR(name));

    if (tmp) {
        char *cur = tmp;

713 714
        auth_get_authenticator__init_method(auth, method_inited, init_with);

715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747
        while (cur) {
            char *next = strstr(cur, ",");
            httpp_request_type_e idx;

            if (next) {
                *next = 0;
                next++;
                for (; *next == ' '; next++);
            }

            if (strcmp(cur, "*") == 0) {
                size_t i;

                for (i = 0; i < (sizeof(auth->filter_method)/sizeof(*(auth->filter_method))); i++)
                    auth->filter_method[i] = matchtype;
                break;
            }

            idx = httpp_str_to_method(cur);
            if (idx == httpp_req_unknown) {
                ICECAST_LOG_ERROR("Can not add known method \"%H\" to role's %s", cur, name);
                return -1;
            }
            auth->filter_method[idx] = matchtype;
            cur = next;
        }

        free(tmp);
    }

    return 0;
}

748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793
static inline int auth_get_authenticator__permission_alter(auth_t *auth, xmlNodePtr node, const char *name, auth_matchtype_t matchtype)
{
    char * tmp = (char*)xmlGetProp(node, XMLSTR(name));

    if (tmp) {
        char *cur = tmp;

        while (cur) {
            char *next = strstr(cur, ",");
            auth_alter_t idx;

            if (next) {
                *next = 0;
                next++;
                for (; *next == ' '; next++);
            }

            if (strcmp(cur, "*") == 0) {
                size_t i;

                for (i = 0; i < (sizeof(auth->permission_alter)/sizeof(*(auth->permission_alter))); i++)
                    auth->permission_alter[i] = matchtype;
                break;
            }

            idx = auth_str2alter(cur);
            if (idx == AUTH_ALTER_NOOP) {
                ICECAST_LOG_ERROR("Can not add unknown alter action \"%H\" to role's %s", cur, name);
                return -1;
            } else if (idx == AUTH_ALTER_REDIRECT) {
                auth->permission_alter[AUTH_ALTER_REDIRECT] = matchtype;
                auth->permission_alter[AUTH_ALTER_REDIRECT_SEE_OTHER] = matchtype;
                auth->permission_alter[AUTH_ALTER_REDIRECT_TEMPORARY] = matchtype;
                auth->permission_alter[AUTH_ALTER_REDIRECT_PERMANENT] = matchtype;
            } else {
                auth->permission_alter[idx] = matchtype;
            }

            cur = next;
        }

        free(tmp);
    }

    return 0;
}
794
auth_t *auth_get_authenticator(xmlNodePtr node)
795
{
796
    auth_t *auth = calloc(1, sizeof(auth_t));
797
    config_options_t *options = NULL, **next_option = &options;
798
    xmlNodePtr child;
Philipp Schafft's avatar
Philipp Schafft committed
799
    char *method;
800
    char *tmp;
Philipp Schafft's avatar
Philipp Schafft committed
801
    size_t i;
802
    size_t filter_admin_index = 0;
803
    int method_inited = 0;
804 805 806 807

    if (auth == NULL)
        return NULL;

Philipp Schafft's avatar
Philipp Schafft committed
808 809
    thread_mutex_create(&auth->lock);
    auth->refcount = 1;
810
    auth->id = _next_auth_id();
Philipp Schafft's avatar
Philipp Schafft committed
811 812
    auth->type = (char*)xmlGetProp(node, XMLSTR("type"));
    auth->role = (char*)xmlGetProp(node, XMLSTR("name"));
813
    auth->management_url = (char*)xmlGetProp(node, XMLSTR("management-url"));
814 815 816 817 818 819 820
    auth->filter_web_policy = AUTH_MATCHTYPE_MATCH;
    auth->filter_admin_policy = AUTH_MATCHTYPE_MATCH;

    for (i = 0; i < (sizeof(auth->filter_admin)/sizeof(*(auth->filter_admin))); i++) {
        auth->filter_admin[i].type = AUTH_MATCHTYPE_UNUSED;
        auth->filter_admin[i].command = ADMIN_COMMAND_ERROR;
    }
Philipp Schafft's avatar
Philipp Schafft committed
821

822 823 824
    for (i = 0; i < (sizeof(auth->permission_alter)/sizeof(*(auth->permission_alter))); i++)
        auth->permission_alter[i] = AUTH_MATCHTYPE_NOMATCH;

Philipp Schafft's avatar
Philipp Schafft committed
825 826 827 828 829 830 831 832 833 834
    if (!auth->type) {
        auth_release(auth);
        return NULL;
    }

    method = (char*)xmlGetProp(node, XMLSTR("method"));
    if (method) {
        char *cur = method;
        char *next;

835 836
        for (i = 0; i < (sizeof(auth->filter_method)/sizeof(*auth->filter_method)); i++)
            auth->filter_method[i] = AUTH_MATCHTYPE_NOMATCH;
837
	method_inited = 1;
Philipp Schafft's avatar
Philipp Schafft committed
838 839 840 841 842 843 844 845 846 847 848 849

        while (cur) {
            httpp_request_type_e idx;

            next = strstr(cur, ",");
            if (next) {
                *next = 0;
                next++;
                for (; *next == ' '; next++);
            }

            if (strcmp(cur, "*") == 0) {
850 851
                for (i = 0; i < (sizeof(auth->filter_method)/sizeof(*auth->filter_method)); i++)
                    auth->filter_method[i] = AUTH_MATCHTYPE_MATCH;
Philipp Schafft's avatar
Philipp Schafft committed
852 853 854 855 856 857 858 859
                break;
            }

            idx = httpp_str_to_method(cur);
            if (idx == httpp_req_unknown) {
                auth_release(auth);
                return NULL;
            }
860
            auth->filter_method[idx] = AUTH_MATCHTYPE_MATCH;
Philipp Schafft's avatar
Philipp Schafft committed
861 862 863 864 865 866 867

            cur = next;
        }

        xmlFree(method);
    }

868 869 870 871
    auth_get_authenticator__filter_method(auth, node, "match-method", AUTH_MATCHTYPE_MATCH, &method_inited, AUTH_MATCHTYPE_NOMATCH);
    auth_get_authenticator__filter_method(auth, node, "nomatch-method", AUTH_MATCHTYPE_NOMATCH, &method_inited, AUTH_MATCHTYPE_MATCH);

    auth_get_authenticator__init_method(auth, &method_inited, AUTH_MATCHTYPE_MATCH);
872

873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895
    tmp = (char*)xmlGetProp(node, XMLSTR("match-web"));
    if (tmp) {
        if (strcmp(tmp, "*") == 0) {
            auth->filter_web_policy = AUTH_MATCHTYPE_MATCH;
        } else {
            auth->filter_web_policy = AUTH_MATCHTYPE_NOMATCH;
        }
        free(tmp);
    }

    tmp = (char*)xmlGetProp(node, XMLSTR("nomatch-web"));
    if (tmp) {
        if (strcmp(tmp, "*") == 0) {
            auth->filter_web_policy = AUTH_MATCHTYPE_NOMATCH;
        } else {
            auth->filter_web_policy = AUTH_MATCHTYPE_MATCH;
        }
        free(tmp);
    }

    auth_get_authenticator__filter_admin(auth, node, &filter_admin_index, "match-admin", AUTH_MATCHTYPE_MATCH);
    auth_get_authenticator__filter_admin(auth, node, &filter_admin_index, "nomatch-admin", AUTH_MATCHTYPE_NOMATCH);

896 897 898 899
    auth->filter_origin_policy = AUTH_MATCHTYPE_MATCH;
    auth_get_authenticator__filter_origin(auth, node, "match-origin", AUTH_MATCHTYPE_MATCH);
    auth_get_authenticator__filter_origin(auth, node, "nomatch-origin", AUTH_MATCHTYPE_NOMATCH);

900 901 902
    auth_get_authenticator__permission_alter(auth, node, "may-alter", AUTH_MATCHTYPE_MATCH);
    auth_get_authenticator__permission_alter(auth, node, "may-not-alter", AUTH_MATCHTYPE_NOMATCH);

903 904 905 906 907 908 909 910 911 912
    /* sub node parsing */
    child = node->xmlChildrenNode;
    do {
        if (child == NULL)
            break;

        if (xmlIsBlankNode(child))
            continue;

        if (xmlStrcmp (child->name, XMLSTR("option")) == 0) {
Philipp Schafft's avatar
Philipp Schafft committed
913
            config_options_t *opt = calloc(1, sizeof (config_options_t));
914 915
            opt->name = (char *)xmlGetProp(child, XMLSTR("name"));
            if (opt->name == NULL) {
916 917 918
                free(opt);
                continue;
            }
919 920
            opt->value = (char *)xmlGetProp(child, XMLSTR("value"));
            if (opt->value == NULL) {
Philipp Schafft's avatar
Philipp Schafft committed
921 922
                xmlFree(opt->name);
                free(opt);
923 924 925 926
                continue;
            }
            *next_option = opt;
            next_option = &opt->next;
927 928
        } else if (xmlStrcmp (child->name, XMLSTR("http-headers")) == 0) {
            config_parse_http_headers(child->xmlChildrenNode, &(auth->http_headers));
929 930 931 932 933 934 935 936
        } else if (xmlStrcmp (child->name, XMLSTR("acl")) == 0) {
            if (!auth->acl) {
                auth->acl  = acl_new_from_xml_node(child);
            } else {
                ICECAST_LOG_ERROR("More than one ACL defined in role! Not supported (yet).");
            }
        } else {
            ICECAST_LOG_WARN("unknown auth setting (%H)", child->name);
937
        }
938 939 940 941 942
    } while ((child = child->next));

    if (!auth->acl) {
        /* If we did not get a <acl> try ACL as part of <role> (old style). */
        auth->acl  = acl_new_from_xml_node(node);
943
    }
Philipp Schafft's avatar
Philipp Schafft committed
944 945
    if (!auth->acl) {
        auth_release(auth);
Karl Heyes's avatar
Karl Heyes committed
946
        auth = NULL;
Philipp Schafft's avatar
Philipp Schafft committed
947 948 949 950 951 952
    } else {
        if (get_authenticator (auth, options) < 0) {
            auth_release(auth);
            auth = NULL;
        } else {
            auth->tailp = &auth->head;
953 954 955 956
            if (!auth->immediate) {
                auth->running = 1;
                auth->thread = thread_create("auth thread", auth_run_thread, auth, THREAD_ATTACHED);
            }
Philipp Schafft's avatar
Philipp Schafft committed
957
        }
Karl Heyes's avatar
Karl Heyes committed
958
    }
959

Philipp Schafft's avatar
Philipp Schafft committed
960
    while (options) {
961 962
        config_options_t *opt = options;
        options = opt->next;
Philipp Schafft's avatar
Philipp Schafft committed
963 964
        xmlFree(opt->name);
        xmlFree(opt->value);
965
        free (opt);
966
    }
Philipp Schafft's avatar
Philipp Schafft committed
967

968
    if (auth && !auth->management_url && (auth->adduser || auth->deleteuser || auth->listuser)) {
969 970 971 972 973
        char url[128];
        snprintf(url, sizeof(url), "/admin/manageauth.xsl?id=%lu", auth->id);
        auth->management_url = (char*)xmlCharStrdup(url);
    }

974 975
    return auth;
}
976

977 978 979 980 981
int auth_alter_client(auth_t *auth, auth_client *auth_user, auth_alter_t action, const char *arg)
{
    if (!auth || !auth_user || !arg)
        return -1;

982 983 984 985 986
    if (action < 0 || action >= (sizeof(auth->permission_alter)/sizeof(*(auth->permission_alter))))
        return -1;

    if (auth->permission_alter[action] != AUTH_MATCHTYPE_MATCH)
        return -1;
987

988
    if (util_replace_string(&(auth_user->alter_client_arg), arg) != 0)
989 990 991 992 993 994
        return -1;

    auth_user->alter_client_action = action;

    return 0;
}
995

996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019
auth_alter_t auth_str2alter(const char *str)
{
    if (!str)
        return AUTH_ALTER_NOOP;

    if (strcasecmp(str, "noop") == 0) {
        return AUTH_ALTER_NOOP;
    } else if (strcasecmp(str, "rewrite") == 0) {
        return AUTH_ALTER_REWRITE;
    } else if (strcasecmp(str, "redirect") == 0) {
        return AUTH_ALTER_REDIRECT;
    } else if (strcasecmp(str, "redirect_see_other") == 0) {
        return AUTH_ALTER_REDIRECT_SEE_OTHER;
    } else if (strcasecmp(str, "redirect_temporary") == 0) {
        return AUTH_ALTER_REDIRECT_TEMPORARY;
    } else if (strcasecmp(str, "redirect_permanent") == 0) {
        return AUTH_ALTER_REDIRECT_PERMANENT;
    } else if (strcasecmp(str, "send_error") == 0) {
        return AUTH_ALTER_SEND_ERROR;
    } else {
        return AUTH_ALTER_NOOP;
    }
}

Philipp Schafft's avatar
Philipp Schafft committed
1020 1021 1022
/* these are called at server start and termination */

void auth_initialise (void)
1023
{
1024
    thread_mutex_create(&_auth_lock);
Philipp Schafft's avatar
Philipp Schafft committed
1025
}
1026

Philipp Schafft's avatar
Philipp Schafft committed
1027 1028 1029
void auth_shutdown (void)
{
    ICECAST_LOG_INFO("Auth shutdown");
1030
    thread_mutex_destroy(&_auth_lock);
Philipp Schafft's avatar
Philipp Schafft committed
1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041
}

/* authstack functions */

static void __move_client_forward_in_auth_stack(client_t *client, void (*on_result)(client_t *client, void *userdata, auth_result result), void *userdata) {
    auth_stack_next(&client->authstack);
    if (client->authstack) {
        auth_stack_add_client(client->authstack, client, on_result, userdata);
    } else {
        if (on_result)
            on_result(client, userdata, AUTH_NOMATCH);
1042
    }
Philipp Schafft's avatar
Philipp Schafft committed
1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070
}

void          auth_stack_add_client(auth_stack_t *stack, client_t *client, void (*on_result)(client_t *client, void *userdata, auth_result result), void *userdata) {
    auth_t *auth;

    if (!stack || !client || (client->authstack && client->authstack != stack))
        return;

    if (!client->authstack)
        auth_stack_addref(stack);
    client->authstack = stack;
    auth = auth_stack_get(stack);
    auth_add_client(auth, client, __move_client_forward_in_auth_stack, on_result, userdata);
    auth_release(auth);
}

void          auth_stack_release(auth_stack_t *stack) {
    if (!stack)
        return;

    thread_mutex_lock(&stack->lock);
    stack->refcount--;
    thread_mutex_unlock(&stack->lock);

    if (stack->refcount)
        return;

    auth_release(stack->auth);
1071
    auth_stack_release(stack->next);
Philipp Schafft's avatar
Philipp Schafft committed
1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089
    thread_mutex_destroy(&stack->lock);
    free(stack);
}

void          auth_stack_addref(auth_stack_t *stack) {
    if (!stack)
        return;
    thread_mutex_lock(&stack->lock);
    stack->refcount++;
    thread_mutex_unlock(&stack->lock);
}

int           auth_stack_next(auth_stack_t **stack) {
    auth_stack_t *next;
    if (!stack || !*stack)
        return -1;
    thread_mutex_lock(&(*stack)->lock);
    next = (*stack)->next;
1090
    auth_stack_addref(next);
Philipp Schafft's avatar
Philipp Schafft committed
1091 1092 1093 1094 1095
    thread_mutex_unlock(&(*stack)->lock);
    auth_stack_release(*stack);
    *stack = next;
    if (!next)
        return 1;
1096 1097 1098
    return 0;
}

Philipp Schafft's avatar
Philipp Schafft committed
1099 1100
int           auth_stack_push(auth_stack_t **stack, auth_t *auth) {
    auth_stack_t *next;
1101

Philipp Schafft's avatar
Philipp Schafft committed
1102 1103
    if (!stack || !auth)
        return -1;
1104

Philipp Schafft's avatar
Philipp Schafft committed
1105 1106 1107 1108 1109 1110 1111 1112 1113 1114
    next = calloc(1, sizeof(*next));
    if (!next) {
        return -1;
    }
    thread_mutex_create(&next->lock);
    next->refcount = 1;
    next->auth = auth;
    auth_addref(auth);

    if (*stack) {
1115 1116 1117
        auth_stack_append(*stack, next);
        auth_stack_release(next);
        return 0;
Philipp Schafft's avatar
Philipp Schafft committed
1118 1119 1120
    } else {
        *stack = next;
        return 0;
1121 1122 1123
    }
}

Philipp Schafft's avatar
Philipp Schafft committed
1124 1125
int           auth_stack_append(auth_stack_t *stack, auth_stack_t *tail) {
    auth_stack_t *next, *cur;
1126

Philipp Schafft's avatar
Philipp Schafft committed
1127 1128
    if (!stack)
        return -1;
1129

Philipp Schafft's avatar
Philipp Schafft committed
1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141
    auth_stack_addref(cur = stack);
    thread_mutex_lock(&cur->lock);
    while (1) {
        next = cur->next;
        if (!cur->next)
            break;

        auth_stack_addref(next);
        thread_mutex_unlock(&cur->lock);
        auth_stack_release(cur);
        cur = next;
        thread_mutex_lock(&cur->lock);
1142
    }
Philipp Schafft's avatar
Philipp Schafft committed
1143 1144 1145 1146 1147 1148

    auth_stack_addref(cur->next = tail);
    thread_mutex_unlock(&cur->lock);
    auth_stack_release(cur);

    return 0;
1149
}
1150

Philipp Schafft's avatar
Philipp Schafft committed
1151 1152
auth_t       *auth_stack_get(auth_stack_t *stack) {
    auth_t *auth;
1153

Philipp Schafft's avatar
Philipp Schafft committed
1154 1155
    if (!stack)
        return NULL;
1156

1157
    thread_mutex_lock(&stack->lock);
Philipp Schafft's avatar
Philipp Schafft committed
1158 1159 1160
    auth_addref(auth = stack->auth);
    thread_mutex_unlock(&stack->lock);
    return auth;
1161 1162
}

1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187
auth_t       *auth_stack_getbyid(auth_stack_t *stack, unsigned long id) {
    auth_t *ret = NULL;

    if (!stack)
        return NULL;

    auth_stack_addref(stack);

    while (!ret && stack) {
        auth_t *auth = auth_stack_get(stack);
        if (auth->id == id) {
            ret = auth;
            break;
        }
        auth_release(auth);
        auth_stack_next(&stack);
    }

    if (stack)
        auth_stack_release(stack);

    return ret;

}

1188
acl_t        *auth_stack_get_anonymous_acl(auth_stack_t *stack, httpp_request_type_e method) {
Philipp Schafft's avatar
Philipp Schafft committed
1189 1190
    acl_t *ret = NULL;

1191
    if (!stack || method < 0 || method > httpp_req_unknown)
Philipp Schafft's avatar
Philipp Schafft committed
1192
        return NULL;
1193

Philipp Schafft's avatar
Philipp Schafft committed
1194 1195 1196 1197
    auth_stack_addref(stack);

    while (!ret && stack) {
        auth_t *auth = auth_stack_get(stack);
1198
        if (auth->filter_method[method] != AUTH_MATCHTYPE_NOMATCH && strcmp(auth->type, AUTH_TYPE_ANONYMOUS) == 0) {
Philipp Schafft's avatar
Philipp Schafft committed
1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211
            acl_addref(ret = auth->acl);
        }
        auth_release(auth);

        if (!ret)
            auth_stack_next(&stack);
    }

    if (stack)
        auth_stack_release(stack);

    return ret;
}