1. 23 Jul, 2017 3 commits
  2. 23 Nov, 2015 1 commit
  3. 22 Nov, 2015 2 commits
  4. 01 Mar, 2015 2 commits
  5. 10 Feb, 2015 4 commits
    • Philipp Schafft's avatar
    • Philipp Schafft's avatar
      Feature: Support PUT with chunked transfer encoding. · 36d10121
      Philipp Schafft authored
      This adds the Transfer-Encoding chunked to PUT support.
      
      Please test carefully. Will add PUT to Allow: header after testing.
      
      Have fun.
      
      Closes: #2088
      36d10121
    • Philipp Schafft's avatar
      Cleanup: unbreak 100-continue a bit. · 79cb147c
      Philipp Schafft authored
      This tries to unbreak the 100-continue thing a bit.
      Proper headers are send in case of 100-continue. Also the 200 OK
      was moved to the end of the stream.
      The client may even be reused. But I'm not sure we only do
      'End of stream' in cases we are not on an undefined state of the
      client. Do we as of now support anything that give us EOS without
      a fatal socket state (error or shutdown)?
      
      At least this unbreaks 100-continue with active TLS that was broken
      as hell as we sent the header in clear over the socket. Not checking
      if it was transmitted completly or something. Using lowlevel socket
      calls (in contrast to the connection level calls that would have
      handled the TLS just fine).
      
      While this seem sto be a huge improvement to the situation I kindly
      ask you to do a lot testing on this. Both with SOURCE as well as
      PUT clients.
      79cb147c
    • Philipp Schafft's avatar
      Fix/Cleanup: Answer SOURCE/PUT requests with a real 200-OK. · d6908eb0
      Philipp Schafft authored
      We have answered SOURCE/PUT requests with a simple
      "HTTP/1.0 200 OK\r\n\r\n" while we should answer with complet
      headers. This commit corrects this.
      
      Interoperability:
      This will work for two classes of clients:
       * Super dumb ones not checking the response and will just send
         data and hope the socket is still open.
       * Those with a real parser.
       * Shoutcast clients (indepnded code path).
       * All libshout, curl, wget, ... based clients.
      
      This *could* break:
       * Clients that check for the exact returned message. However
         as we start with the same string this should work.
         Only client that check for the string including the End-of-header
         CRLF sequense may break.
      
      Please test careful before release.
      d6908eb0
  6. 06 Feb, 2015 1 commit
  7. 02 Feb, 2015 3 commits
  8. 01 Feb, 2015 2 commits
  9. 25 Jan, 2015 1 commit
    • Marvin Scholz's avatar
      Cleanup codestyle · 0dfc7c5b
      Marvin Scholz authored
      This commit cleanups codestyle a bit, yet there is still some work to be done
      0dfc7c5b
  10. 10 Jan, 2015 2 commits
  11. 05 Jan, 2015 1 commit
  12. 24 Dec, 2014 3 commits
  13. 20 Dec, 2014 1 commit
  14. 18 Dec, 2014 1 commit
  15. 14 Dec, 2014 1 commit
  16. 07 Dec, 2014 1 commit
  17. 02 Dec, 2014 1 commit
  18. 30 Nov, 2014 2 commits
  19. 29 Nov, 2014 1 commit
  20. 28 Nov, 2014 1 commit
    • Philipp Schafft's avatar
      Wow. Mega patch! · a642cac5
      Philipp Schafft authored
      This patch *replaces* the authentication system completly.
      
      What is new:
       - <authentication> in mount section is now a container object.
       - <authentication> in root and mount section may hold any number of <role>-Tags.
       - <role> tags:
         Those tags define a 'role' and it's ACL rules.
         A role is a instance of an authentication module (see below).
         <role> takes the following options. All but type are optional.
         - authentication related:
           - type: Type of the authentication module (values: anonymous, static, legacy-password, url or htpasswd;
                   symbolic constants in auth.h)
           - name: Name for the role. For later matching. (values: any string; default: (none))
           - method: This rule is only active on the given list of HTTP methods.
                     (list of enum values: methods as recognized by httpp/ (e.g: get,post); default: *)
         - ACL related:
           - allow-method: Allowed HTTP methods.
             (list of enum values: methods as recognized by httpp/ (e.g: get,post); default: get)
           - deny-method: Rejected HTTP methods.
             (list of enum values: methods as recognized by httpp/ (e.g: get,post); default: *)
           - allow-admin: Allowed admin commands. (list of enum values: admin command; default: buildm3u)
           - deny-admin: Rejected admin commands. (list of enum values: admin command; default: *)
           - allow-web: Allowed web pages. (values: empty or *; default: *)
           - deny-web: Rejected web pages. (values: empty or *; default: (empty))
           - connections-per-user: maximum number of simultaneous connections per role and username.
             This is only active on active sources.  (values: unlimited or number of connections; default: unlimited)
           - connection-duration: maximum time of a connection. This is only active on active sources.
             (values: unlimited or number of secounds; default: unlimited)
         <role> takes <option> child tags. <option> tags contain a name and a value option.
         Meaning of <option> tags is up to the authentication module.
       - <role>s are considered to build a stack. If a role returns with AUTH_NOMATCH the next one will be tried.
       - <role>s are tested in this order: mount specific, default mount specific, global, internal fallback.
         Internal fallback is set to allow web/ access via GET, POST and HEAD (only GET supported by this time)
         and rejects all other requests.
       - New authentication module: anonymous
         This module matches all requests. No options taken.
       - New authentication module: static
         This module matches with a static username and password.
         It takes two <option>s. One with name="username" and one with name="password" to set username and password.
         This replaces old style <*-username> and <*-password> tags.
       - New authentication module: legacy-password
         This module matches with a statich password.
         It takes one <option> with name="password" to set password.
         This replaces old ICE and ICY (shoutcast compat mode) authentication.
       - Parsing <authentication> in <mount> with a type set in a special way to allow 100% backward compatibility.
       - Parsing of <source-password>, <admin-password>, <admin-user>, <relay-password> and <relay-user> in global
         <authentication> for 100% backward compatibility.
       - <alias> is now proccessed very early. This enables them to be used for all kinds of requests.
      
      To Do List & What does not yet work:
       - type="url" auth: mount_add and mount_remove.
         This should be replaced by an unique feature I would call '<event>'.
       - Admin commands manageauth and manageauth.xsl are disabled as they need more review:
         This code needs to be ported to support multiple <role>s per <mount>.
       - url authentication module can not yet return AUTH_NOMATCH.
         This needs to be reviewed and discussed on how to handle this case best way.
       - Default config files needs to be updated to reflect the changes.
         As this is quite some political act it should be done in dicussion with the whole team
         and permission of the release manager.
       - Docs need to be updated to reflect the changes.
      
      How does it work:
       Code has been changed so that authentification is done early for all clients.
       This allows accessing the ACL data (client->acl) from nearly everywhere in the code.
      
       After accept() and initial client setup the request is parsed. In the next step
       all <alias>es are resolved. After this the client is passed for authentication.
       After authentication it is passed to the corresponding subsystem depending on kind of request.
      
       All authentication instances have a thread running for doing the authentication.
       This thread works on a queue of clients.
      
      Hints for testers:
       - Test with default config.
       - Test with diffrent authentication modules in <mount>.
       - Test shoutcast compatibility mode.
       - Test with new style <authentication> and any amount of <role> (zero to quite some).
       - Test <alias> lookup on all kinds of objects.
       - Test source level credential login into the admin interface.
       - Test shoucast style meta data updates.
       - Test playlist generation.
      
      Thank you for reading this long commit message. Have fun reading the full patch!
      
      svn path=/icecast/trunk/icecast/; revision=19358
      a642cac5
  21. 21 Nov, 2014 1 commit
  22. 20 Nov, 2014 1 commit
  23. 08 Nov, 2014 1 commit
    • Thomas B. Rücker's avatar
      Applying patch, HTTP PUT requires content-type · 24b7825a
      Thomas B. Rücker authored
      In case of SOURCE we are lenient and thus quite some source clients
      don't send a proper content-type, especially if they only support mp3.
      
      This was meant to be introduced in 2.4.0 already, sadly we missed it.
      
      All source clients MUST send proper content-type after migrating to 
      Icecast HTTP PUT protocol.
      
      closes #2082
      
      svn path=/icecast/trunk/icecast/; revision=19288
      24b7825a
  24. 03 Nov, 2014 1 commit
  25. 31 Oct, 2014 2 commits