Skip to content
GitLab
Switch branch/tag
  1. 08 Apr, 2015 1 commit
    • Philipp Schafft's avatar
      Cleanup: move libcurl specifc code into curl.c · 74023834
      Philipp Schafft authored 
      This cleans the libcurl usage up a bit. It moves common code used
to interact with libcurl into a single new file curl.[ch].

Notes:
* It does not alter any features nor fixes any bugs.
* Thew REVIEW about strdup(self->url) in event_url.c as been processed.
  According to the manpage for curl_easy_setopt()/CURLOPT_URL
  there is no need for us to copy.
* URL Auth as well as URL triggers have sent ICECAST_VERSION_STRING
  as User-Agent:, this has be corrected to what is set in the config
  file.
* As curl.c is now a single point for setting parameters all the TLS
  parameters should be reviewed and set (based on config).

Please test!
      74023834
  3. 10 Jan, 2015 2 commits
  5. 24 Dec, 2014 1 commit
  7. 14 Dec, 2014 1 commit
  9. 08 Dec, 2014 1 commit
    • Philipp Schafft's avatar
      Added <event>: Unified handling of events. · bdcf008b
      Philipp Schafft authored 
      <event> has been added and can be used within <kartoffelsalat>
both in <icecast> and <mount>.
<event> takes backend depending <option> child tags.
Currently supported backends:
 - log: send message to error log.
 - exec: executes a program or script.
 - url: delivers the event via HTTP.

within <mount> <on-connect> and <on-disconnect> has been replaced by
<event>. Config parser can on-the-fly convert old tags.
Also <authentication type="url"> within <mount> has been fixed
for those cases with <option name="mount_add" .../> and
<option name="mount_remove" .../> which are now on-the-fly converted
by the parser to corresponding <event> tags.

Please also see TAGs added as per #2098. Some include hints for
documentation updates needed after this change. Those updates
should take place before 2.4.2.
      bdcf008b
  11. 02 Dec, 2014 1 commit
  13. 30 Nov, 2014 1 commit
  15. 29 Nov, 2014 1 commit
  17. 20 Nov, 2014 1 commit
  19. 07 Nov, 2014 2 commits
  21. 31 Oct, 2014 2 commits
  23. 18 Oct, 2014 1 commit
  25. 09 Oct, 2014 1 commit
  27. 06 May, 2014 1 commit
    • Thomas B. Rücker's avatar
      SECURITY FIX - Override supplementary groups · 53e6ee7a
      Thomas B. Rücker authored 
      In case of <changeowner> only UID and GID were changed, 
supplementary groups were left in place.
This is a potential security issue only if <changeowner> is used.
New behaviour is to set UID, GID and set supplementary groups 
based on the UID
Even in case of icecast remaining in supplementary group 0 
this "only" gives it things like access to files that are owned 
by group 0 and according to their umask. This is obviously bad,
but not as bad as UID 0 with all its other special rights.
It's a security issue and we fix immediately and recommend users to update.

PS: Cherry picking this should be fine by distros for fixing older releases.

svn path=/icecast/trunk/icecast/; revision=19137
      53e6ee7a
  29. 01 Mar, 2014 1 commit
  31. 15 May, 2013 1 commit
    • Thomas B. Rücker's avatar
      This patch closes ticket #1886. · 5a269462
      Thomas B. Rücker authored 
      I've rethought the approach and found a much cleaner way. 
We now split handling of command line arguments into two parts.
Only the critical part of getting the config file is done first (and -v as it prevents startup).
The rest (currently only -b) is deferred.

This achieves the important bit why #1886 was created. 
It allows us to log error messages to stderr even if the -b argument is passed.
This is mainly for the case where the logfile or TCP port can't be opened.

svn path=/icecast/trunk/icecast/; revision=18945
      5a269462
  33. 02 Apr, 2013 2 commits
  35. 12 Nov, 2012 1 commit
  37. 12 Oct, 2012 1 commit
  39. 11 Oct, 2012 3 commits
  41. 10 Oct, 2012 1 commit
  43. 05 Aug, 2009 1 commit
  45. 08 Jan, 2009 1 commit
  47. 02 May, 2008 1 commit
  49. 11 Feb, 2008 1 commit
  51. 23 Nov, 2007 1 commit
  53. 16 Oct, 2007 1 commit
  55. 17 Dec, 2005 3 commits
  57. 24 Oct, 2005 1 commit
    • Ed "oddsock" Zaleski's avatar
      2 new features to icecast logging: · 3a85a143
      Ed "oddsock" Zaleski authored 
      - logsize : specify in KB the max size of any of icecast log files
- logarchive : causes icecast to rename logs with timestamps (for proper archiving)


svn path=/icecast/trunk/icecast/; revision=10287
      3a85a143
  59. 16 Sep, 2005 1 commit
  61. 16 Aug, 2005 1 commit
  63. 12 Aug, 2005 1 commit