- 30 Nov, 2014 6 commits
-
-
Philipp Schafft authored
svn path=/icecast/trunk/icecast/; revision=19376
-
Philipp Schafft authored
svn path=/icecast/trunk/icecast/; revision=19375
-
Philipp Schafft authored
svn path=/icecast/trunk/icecast/; revision=19373
-
Philipp Schafft authored
svn path=/icecast/trunk/icecast/; revision=19372
-
Philipp Schafft authored
svn path=/icecast/trunk/icecast/; revision=19371
-
Philipp Schafft authored
svn path=/icecast/trunk/icecast/; revision=19370
-
- 29 Nov, 2014 6 commits
-
-
Philipp Schafft authored
cleanup: converted printf() into ICECAST_LOG_DEBUG() but commented out so they do not spam logs for normal users. svn path=/icecast/trunk/icecast/; revision=19368
-
Philipp Schafft authored
svn path=/icecast/trunk/icecast/; revision=19365
-
Philipp Schafft authored
- Added <role>. - Converted <Referer> to <referer>. - Set id="nnn" in addition to <ID>nnn</ID>. - Added TAGged comments about next steps. refs #2097 svn path=/icecast/trunk/icecast/; revision=19364
-
Philipp Schafft authored
svn path=/icecast/trunk/icecast/; revision=19361
-
Philipp Schafft authored
svn path=/icecast/trunk/icecast/; revision=19360
-
Philipp Schafft authored
svn path=/icecast/trunk/icecast/; revision=19359
-
- 28 Nov, 2014 1 commit
-
-
Philipp Schafft authored
This patch *replaces* the authentication system completly. What is new: - <authentication> in mount section is now a container object. - <authentication> in root and mount section may hold any number of <role>-Tags. - <role> tags: Those tags define a 'role' and it's ACL rules. A role is a instance of an authentication module (see below). <role> takes the following options. All but type are optional. - authentication related: - type: Type of the authentication module (values: anonymous, static, legacy-password, url or htpasswd; symbolic constants in auth.h) - name: Name for the role. For later matching. (values: any string; default: (none)) - method: This rule is only active on the given list of HTTP methods. (list of enum values: methods as recognized by httpp/ (e.g: get,post); default: *) - ACL related: - allow-method: Allowed HTTP methods. (list of enum values: methods as recognized by httpp/ (e.g: get,post); default: get) - deny-method: Rejected HTTP methods. (list of enum values: methods as recognized by httpp/ (e.g: get,post); default: *) - allow-admin: Allowed admin commands. (list of enum values: admin command; default: buildm3u) - deny-admin: Rejected admin commands. (list of enum values: admin command; default: *) - allow-web: Allowed web pages. (values: empty or *; default: *) - deny-web: Rejected web pages. (values: empty or *; default: (empty)) - connections-per-user: maximum number of simultaneous connections per role and username. This is only active on active sources. (values: unlimited or number of connections; default: unlimited) - connection-duration: maximum time of a connection. This is only active on active sources. (values: unlimited or number of secounds; default: unlimited) <role> takes <option> child tags. <option> tags contain a name and a value option. Meaning of <option> tags is up to the authentication module. - <role>s are considered to build a stack. If a role returns with AUTH_NOMATCH the next one will be tried. - <role>s are tested in this order: mount specific, default mount specific, global, internal fallback. Internal fallback is set to allow web/ access via GET, POST and HEAD (only GET supported by this time) and rejects all other requests. - New authentication module: anonymous This module matches all requests. No options taken. - New authentication module: static This module matches with a static username and password. It takes two <option>s. One with name="username" and one with name="password" to set username and password. This replaces old style <*-username> and <*-password> tags. - New authentication module: legacy-password This module matches with a statich password. It takes one <option> with name="password" to set password. This replaces old ICE and ICY (shoutcast compat mode) authentication. - Parsing <authentication> in <mount> with a type set in a special way to allow 100% backward compatibility. - Parsing of <source-password>, <admin-password>, <admin-user>, <relay-password> and <relay-user> in global <authentication> for 100% backward compatibility. - <alias> is now proccessed very early. This enables them to be used for all kinds of requests. To Do List & What does not yet work: - type="url" auth: mount_add and mount_remove. This should be replaced by an unique feature I would call '<event>'. - Admin commands manageauth and manageauth.xsl are disabled as they need more review: This code needs to be ported to support multiple <role>s per <mount>. - url authentication module can not yet return AUTH_NOMATCH. This needs to be reviewed and discussed on how to handle this case best way. - Default config files needs to be updated to reflect the changes. As this is quite some political act it should be done in dicussion with the whole team and permission of the release manager. - Docs need to be updated to reflect the changes. How does it work: Code has been changed so that authentification is done early for all clients. This allows accessing the ACL data (client->acl) from nearly everywhere in the code. After accept() and initial client setup the request is parsed. In the next step all <alias>es are resolved. After this the client is passed for authentication. After authentication it is passed to the corresponding subsystem depending on kind of request. All authentication instances have a thread running for doing the authentication. This thread works on a queue of clients. Hints for testers: - Test with default config. - Test with diffrent authentication modules in <mount>. - Test shoutcast compatibility mode. - Test with new style <authentication> and any amount of <role> (zero to quite some). - Test <alias> lookup on all kinds of objects. - Test source level credential login into the admin interface. - Test shoucast style meta data updates. - Test playlist generation. Thank you for reading this long commit message. Have fun reading the full patch! svn path=/icecast/trunk/icecast/; revision=19358
-
- 22 Nov, 2014 4 commits
-
-
Philipp Schafft authored
some more changes for ACL framework: exported admin_get_command() and ADMIN_COMMAND_ERROR as well as introduced ADMIN_COMMAND_ANY svn path=/icecast/trunk/icecast/; revision=19349
-
Philipp Schafft authored
svn path=/icecast/trunk/httpp/; revision=19348
-
Philipp Schafft authored
Changed ABI a bit: updated httpp_request_type_e-type. To avoid any problems do a complet rebuild of your projects. Thank you. svn path=/icecast/trunk/httpp/; revision=19347
-
Philipp Schafft authored
svn path=/icecast/trunk/icecast/; revision=19346
-
- 21 Nov, 2014 5 commits
-
-
Philipp Schafft authored
svn path=/icecast/trunk/icecast/; revision=19345
-
Philipp Schafft authored
svn path=/icecast/trunk/icecast/; revision=19344
-
Philipp Schafft authored
svn path=/icecast/trunk/icecast/; revision=19343
-
Philipp Schafft authored
svn path=/icecast/trunk/icecast/; revision=19342
-
Philipp Schafft authored
(sync with my branch) Updated handling of <on-connect> and <on-disconnect> in <mount>, see r19305:r19312, refs #1354, #2089, #2087, #1752 svn path=/icecast/trunk/icecast/; revision=19340
-
- 20 Nov, 2014 4 commits
-
-
Philipp Schafft authored
(sync with my branch) report system name and print better warnings about <hostname> at start of process svn path=/icecast/trunk/icecast/; revision=19339
-
Philipp Schafft authored
(sync with my branch) remove threadpool_size in global config, added warnings for <threadpool> and <no-yp> as well as updated warning for <source-password> svn path=/icecast/trunk/icecast/; revision=19338
-
Philipp Schafft authored
svn path=/icecast/trunk/icecast/; revision=19337
-
Philipp Schafft authored
svn path=/icecast/trunk/icecast/; revision=19336
-
- 19 Nov, 2014 1 commit
-
-
ePirat authored
See: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=767542 svn path=/icecast/trunk/icecast/; revision=19321
-
- 18 Nov, 2014 2 commits
- 17 Nov, 2014 1 commit
-
-
Philipp Schafft authored
subset of my earlier patch so it can go into 2.4.1: disconnects stdio of <on-[dis]connect> scripts from random filehandles. closes #2087 svn path=/icecast/trunk/icecast/; revision=19313
-
- 10 Nov, 2014 1 commit
-
-
Philipp Schafft authored
patch to fix regression on header size with large headers introduced by support of <server-id> and <http-headers>. This should ensure we have at least space for 2kB of extra headers. Depending on function and call we may have much more space. Please test this very carefully. Some pointers what should be in the tests (NOT complet list): - request to 'static' web/ and admin/ pages. - requests to playlist generation. - requests to streams. - requests to admin/ manipulation functions. - test everything with at least 8kB of extra headers, then reduce in 1kB (or 512B) steps. - see if response is correct OR 500 is returned. - run under valgrind or similar to see no buffer overflow or similiar will happen. - take a cookie! svn path=/icecast/trunk/icecast/; revision=19300
-
- 09 Nov, 2014 1 commit
-
-
Thomas B. Rücker authored
String taken from: https://wiki.mozilla.org/Security/Server_Side_TLS#Intermediate_compatibility_.28default.29 svn path=/icecast/trunk/icecast/; revision=19295
-
- 08 Nov, 2014 4 commits
-
-
Thomas B. Rücker authored
svn path=/icecast/trunk/icecast/; revision=19292
-
Thomas B. Rücker authored
In case of SOURCE we are lenient and thus quite some source clients don't send a proper content-type, especially if they only support mp3. This was meant to be introduced in 2.4.0 already, sadly we missed it. All source clients MUST send proper content-type after migrating to Icecast HTTP PUT protocol. closes #2082 svn path=/icecast/trunk/icecast/; revision=19288
-
Philipp Schafft authored
Fixed regression introduced in r18356 (CVE-2011-4612): client duration time is now correctly logged. PRIu64 MUST NOT be used with log_write_direct() as depending on platform PRIu64 may be using something not supported by __vsnprintf() of log/log.c. close #2081, see r18356 svn path=/icecast/trunk/icecast/; revision=19287
-
Philipp Schafft authored
svn path=/icecast/trunk/icecast/; revision=19286
-
- 07 Nov, 2014 4 commits
-
-
Philipp Schafft authored
svn path=/icecast/trunk/net/; revision=19282
-
Philipp Schafft authored
svn path=/icecast/trunk/httpp/; revision=19281
-
Philipp Schafft authored
svn path=/icecast/trunk/icecast/; revision=19280
-
Philipp Schafft authored
svn path=/icecast/trunk/icecast/; revision=19278
-