404 is the expected result

This adds support to read metadata from Ogg/Opus streams:
 * Original sample rate from OpusHead,
 * number of channels from OpusHead,
 * Tags from OpusTags.

This adds spaces into the strings such as "nomatch" (-> "no match")
as returned by auth_result2str(). This is to improve readability of
resulting logfiles by most uses.

This fixes the number of arguments for ICECAST_LOG_INFO().
Why doesn't GCC warn about this?

This fixes a number of segfault happening in case config tags are
empty. This patch also adds warnings for most cases.

Please test for any regressions.
This should likely be ported to 2.4.4 as well.

Closes: #2265

libspeex reports warnings in case of oddnesses with the data to stderr.
However Icecast2 uses those functions in it's codec probeing process.
This way libspeex will write messages to a posibily reused random handle.

This is clearly a bug by package maintainers of libspeex.
See the source code of this change as well as libspeex's source code
as reference.

Philipp Schafft authored Aug 15, 2016 and Philipp Schafft committed Sep 04, 2016

This fixes the regression introduced by r19250 (461a5375).
The fix checks if the source client is actually known before printing it's IP-Address.

See also: #2016

Marvin Scholz authored Jun 28, 2016 and Philipp Schafft committed Jun 28, 2016

As proposed in #2272, this renames the mount specific
mp3-metadata-interval to icy-metadata-interval to prevent
confusion about what it does (setting the icy metadata
interval) and to make clear it's not mp3 specific but ICY
specific.

Marvin Scholz authored Jun 07, 2016 and Philipp Schafft committed Jun 07, 2016

This corrects the test for libcurl.

Closes: #2273

JRS authored Jul 25, 2015 and Marvin Scholz committed Apr 13, 2016

Signed-off-by: Marvin Scholz <epirat07@gmail.com>

Closes: #2248

This changes the file extension check in a way that it no longer
ignores trailing characters. This significantly reduces the risk
for false positives while matching. However this invalidates old
setups with files like foo.xsl3. However I have never files like
that in the wild.

This is based on the patch privided by ePirat in ticket #2248.

See: #2248

(applying lessons learned from libshout)

Joseph Wallace authored Feb 13, 2016 and Marvin Scholz committed Feb 13, 2016

Signed-off-by: Marvin Scholz <epirat07@gmail.com>

This replaces the add node function with the one intended for text nodes
to prevent that invalid entities are not encoded and therefore could
break the XML output.

(See d739c65e and #2255)

This fixes the issue that auth for STATS method always fails, by
adding stats method to legacy admin auth in cfgfile.c

This fixes a bug where listener Referer or User-Agent strings containing
a sequence like `&T;` was not escaped properly and therefore made the
whole XML document invalid.
Injecting new XML nodes (<foo></foo>) was not possible, it seems in the
worse case all it could cause was that the XML failed to parse.

Fix #2255

There was an error how URIs were handled in our custom XSL loader
that rewrites include URIs to point to admin dir if the include
is not found in the current dir.

The check for the file would not work if the path contains chars
that are usually escaped in URIs, like a space (%20), as we get
a already encoded version of that URI in the loader and did not
decode it before checking the existence of the file.

(Fix #2249)