Icecast-Server issueshttps://gitlab.xiph.org/xiph/icecast-server/-/issues2018-03-06T12:49:48Zhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/1977check mime-type file handling in win32 build2018-03-06T12:49:48ZThomas B. Rückercheck mime-type file handling in win32 builduser reported a vague problem.
Seems we open a mime-types file from fserve.c
Also there seems to be an undocumented config option when parsing xml.
So might be enough to include a file and point to it in the win32 default config.
Unless ...user reported a vague problem.
Seems we open a mime-types file from fserve.c
Also there seems to be an undocumented config option when parsing xml.
So might be enough to include a file and point to it in the win32 default config.
Unless mingw provides some magic in its libc.Icecast 2.4.1https://gitlab.xiph.org/xiph/icecast-server/-/issues/1993Icecast server configure fails on ibm AIX 72018-03-06T12:49:48ZAlexandruIcecast server configure fails on ibm AIX 7Hello Team,
I'm having trouble compiling the Icecast server version 2.3.3 on IBM AIX version 7100-02-01-1245.
./configure script fails while checking for libvorbis installation with the following message:
"checking for libvorbis... co...Hello Team,
I'm having trouble compiling the Icecast server version 2.3.3 on IBM AIX version 7100-02-01-1245.
./configure script fails while checking for libvorbis installation with the following message:
"checking for libvorbis... configure: error: must have Ogg Vorbis v1.0 or above installed"
The following libraries have been installed without issues in /opt/freeware/lib:
root@aiiics02:/>rpm -qa|egrep 'vorbis|ogg'
libogg-1.3.0-1
libogg-devel-1.3.0-1
libvorbis-1.3.3-1
libvorbis-devel-1.3.3-1
root@aiiics02:/>rpm -ql libvorbis-1.3.3-1
/opt/freeware/doc/libvorbis-1.3.3
/opt/freeware/doc/libvorbis-1.3.3/AUTHORS
/opt/freeware/doc/libvorbis-1.3.3/COPYING
/opt/freeware/doc/libvorbis-1.3.3/README
/opt/freeware/lib/libvorbis.a
/opt/freeware/lib/libvorbisenc.a
/opt/freeware/lib/libvorbisfile.a
/usr/lib/libvorbis.a
/usr/lib/libvorbisenc.a
/usr/lib/libvorbisfile.a
I'm also attaching the configure.log file in case it helps.
I can help test this on all current AIX versions so you can add AIX to the supported platforms.
Thanks in advance and best of regards!
-AlexThomas B. RückerThomas B. Rückerhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/1994Icecast server configure fails on ibm AIX 72018-03-06T12:49:48ZAlexandruIcecast server configure fails on ibm AIX 7Hello Team,
I'm having trouble compiling the Icecast server version 2.3.3 on IBM AIX version 7100-02-01-1245.
./configure script fails while checking for libvorbis installation with the following message:
"checking for libvorbis......Hello Team,
I'm having trouble compiling the Icecast server version 2.3.3 on IBM AIX version 7100-02-01-1245.
./configure script fails while checking for libvorbis installation with the following message:
"checking for libvorbis... configure: error: must have Ogg Vorbis v1.0 or above installed"
The following libraries have been installed without issues in /opt/freeware/lib:
root@aiiics02:/>rpm -qa|egrep 'vorbis|ogg'
libogg-1.3.0-1
libogg-devel-1.3.0-1
libvorbis-1.3.3-1
libvorbis-devel-1.3.3-1
root@aiiics02:/>rpm -ql libvorbis-1.3.3-1
/opt/freeware/doc/libvorbis-1.3.3
/opt/freeware/doc/libvorbis-1.3.3/AUTHORS
/opt/freeware/doc/libvorbis-1.3.3/COPYING
/opt/freeware/doc/libvorbis-1.3.3/README
/opt/freeware/lib/libvorbis.a
/opt/freeware/lib/libvorbisenc.a
/opt/freeware/lib/libvorbisfile.a
/usr/lib/libvorbis.a
/usr/lib/libvorbisenc.a
/usr/lib/libvorbisfile.a
I'm also attaching the config.log file in case it helps.
I can help test this on all current AIX versions so you can add AIX to the supported platforms.
Thanks in advance and best of regards!
-Alex
https://gitlab.xiph.org/xiph/icecast-server/-/issues/1995Icecast server configure fails on ibm AIX 72018-03-06T12:49:48ZAlexandruIcecast server configure fails on ibm AIX 7Hello Team,
I'm having trouble compiling the Icecast server version 2.3.3 on IBM AIX version 7100-02-01-1245.
./configure script fails while checking for libvorbis installation with the following message:
"checking for libvorbis......Hello Team,
I'm having trouble compiling the Icecast server version 2.3.3 on IBM AIX version 7100-02-01-1245.
./configure script fails while checking for libvorbis installation with the following message:
"checking for libvorbis... configure: error: must have Ogg Vorbis v1.0 or above installed"
The following libraries have been installed without issues in /opt/freeware/lib:
root@aiiics02:/>rpm -qa|egrep 'vorbis|ogg'
libogg-1.3.0-1
libogg-devel-1.3.0-1
libvorbis-1.3.3-1
libvorbis-devel-1.3.3-1
root@aiiics02:/>rpm -ql libvorbis-1.3.3-1
/opt/freeware/doc/libvorbis-1.3.3
/opt/freeware/doc/libvorbis-1.3.3/AUTHORS
/opt/freeware/doc/libvorbis-1.3.3/COPYING
/opt/freeware/doc/libvorbis-1.3.3/README
/opt/freeware/lib/libvorbis.a
/opt/freeware/lib/libvorbisenc.a
/opt/freeware/lib/libvorbisfile.a
/usr/lib/libvorbis.a
/usr/lib/libvorbisenc.a
/usr/lib/libvorbisfile.a
I'm can send the configure.log file in case it helps and also
help test this on all current AIX versions (5.3, 6.1 & 7.1) so you can add AIX to the supported platforms.
Thanks in advance and best of regards!
-Alex
Thomas B. RückerThomas B. Rückerhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/2016Add IP address of the source in error.log2018-03-06T12:49:48ZFrancois LafontAdd IP address of the source in error.logHere is typical content of error.log during a source connection:
```
[2014-05-02 13:43:49] INFO connection/_handle_source_request Source logging in at mountpoint "/test1.mp3"
[2014-05-02 13:43:49] INFO format-vorbis/initial_vorbis_pa...Here is typical content of error.log during a source connection:
```
[2014-05-02 13:43:49] INFO connection/_handle_source_request Source logging in at mountpoint "/test1.mp3"
[2014-05-02 13:43:49] INFO format-vorbis/initial_vorbis_page seen initial vorbis header
[2014-05-02 13:43:49] INFO source/source_main listener count on /test1.mp3 now 0
[2014-05-02 13:43:57] INFO source/get_next_buffer End of Stream /test1.mp3
[2014-05-02 13:43:57] INFO source/source_shutdown Source "/test1.mp3" exiting
```
It will be great if the IP source address was indicate in error.log. For example, something like that:
```
[2014-05-02 13:43:49] INFO connection/_handle_source_request Source (IP=192.168.0.26) logging in at mountpoint "/test1.mp3"
[2014-05-02 13:43:49] INFO format-vorbis/initial_vorbis_page seen initial vorbis header
[2014-05-02 13:43:49] INFO source/source_main listener count on /test1.mp3 now 0
[2014-05-02 13:43:57] INFO source/get_next_buffer End of Stream /test1.mp3
[2014-05-02 13:43:57] INFO source/source_shutdown Source (IP=192.168.0.26) "/test1.mp3" exiting
```
Isn't it? ;-)
Francois LafontIcecast 2.5.0Thomas B. RückerThomas B. Rückerhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/2018Add a web interface equivalent of SIGHUP2018-03-06T12:49:47ZwillwhAdd a web interface equivalent of SIGHUPI run icecast2 on windows, and it'd be great to have some HTTP interface I could POST to, to call a reload to add mounts, without kicking any sources or clients from the running mounts.
Thanks guys!I run icecast2 on windows, and it'd be great to have some HTTP interface I could POST to, to call a reload to add mounts, without kicking any sources or clients from the running mounts.
Thanks guys!Icecast 2.5.0Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/icecast-server/-/issues/2019[PATCH] Add PLS Playlist Format2018-03-06T12:49:47ZMarvin Scholz[PATCH] Add PLS Playlist FormatThis patch adds support for the pls playlist format.This patch adds support for the pls playlist format.Thomas B. RückerThomas B. Rückerhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/2020[PATCH] Fix autogen.sh to work properly on Mac OS2018-03-06T12:49:47ZMarvin Scholz[PATCH] Fix autogen.sh to work properly on Mac OSThis patch fixes autogen.sh, so it will not exit with the error that libtool is not installed on Mac OS.
The command `libtoolize` on Mac OS is called `glibtoolize`, this patch makes it check for both versions.
This patch fixes autogen.sh, so it will not exit with the error that libtool is not installed on Mac OS.
The command `libtoolize` on Mac OS is called `glibtoolize`, this patch makes it check for both versions.
Thomas B. RückerThomas B. Rückerhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/2088accept data with “Transfer-Encoding: chunked”2018-03-06T12:49:47ZSven Herzbergaccept data with “Transfer-Encoding: chunked”Many HTTP frameworks will automatically encode data streams using the aforementioned method. I propose this behavior for Icecast:
* check if the protocol is not `HTTP/1.1` or there is no `Transfer-Encoding` header, continue as in the pa...Many HTTP frameworks will automatically encode data streams using the aforementioned method. I propose this behavior for Icecast:
* check if the protocol is not `HTTP/1.1` or there is no `Transfer-Encoding` header, continue as in the past (i.e. assume `identity` encoding)
* if the `Transfer-Encoding` header is present and it is `identity`, continue as in the past
* if the `Transfer-Encoding` header is present and it is `chunked`, accept the data and strip the encoding information both from the output stream and from the dumpfile
* if the `Transfer-Encoding` header is present and has a different value, terminate the request with 501 (Unimplemented) and provide an HTTP response body listing the supported encodings (in case developers need to debug this).
That behavior in compliant with RFC2616 (Section 3.6) and RFC7230 (Section 3.3.1).Icecast 2.5.0Thomas B. RückerThomas B. Rückerhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/2028Non-existing community link on server information page2018-03-06T12:49:47ZRoland HermansNon-existing community link on server information pageClicking on the Community link of the Server Information web page /server_version.xsl results in a 404 error: "The requested URL /community.php was not found on this server.".
Steps to reproduce:
1. Open the Icecast web interface in a b...Clicking on the Community link of the Server Information web page /server_version.xsl results in a 404 error: "The requested URL /community.php was not found on this server.".
Steps to reproduce:
1. Open the Icecast web interface in a browser
2. Click on Version in the menu
3. Click on the community link (http://icecast.org/community.php)
Actual result:
404 error
Expected result:
Web page with information on the Icecast community is shown.Thomas B. RückerThomas B. Rückerhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/2089[duplicate] icecast sends output of <on-connect> script to source client2018-03-06T12:49:47ZSven Herzberg[duplicate] icecast sends output of <on-connect> script to source clientPlease look at #2087 instead.
----
Using the on-connect script from #2087, a client which does not close the connection immediately after receiving the 200 response, has a chance of reading “stdout” after stopping to send any data.
If...Please look at #2087 instead.
----
Using the on-connect script from #2087, a client which does not close the connection immediately after receiving the 200 response, has a chance of reading “stdout” after stopping to send any data.
If this is unintentional, this data should end up in e.g. the `<errorlog>` target.
If this is intentional, the length of the data should be indicated by a `Content-Length` header, or should be properly encoded as `Transfer-Encoding: chunked` (which would then be required as a header in the response).Thomas B. RückerThomas B. Rückerhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/2031Admin functions do not accept URL encoded values2018-03-06T12:49:47ZBradAdmin functions do not accept URL encoded valuesThe admin functions should accept/decode the mount GET value since / is a reserved character.
This works:
http://192.168.1.10:8000/admin/metadata?mount=/mystream&mode=updinfo&song=ACDC+Back+In+Black
This doesn't:
http://192.168.1.10:80...The admin functions should accept/decode the mount GET value since / is a reserved character.
This works:
http://192.168.1.10:8000/admin/metadata?mount=/mystream&mode=updinfo&song=ACDC+Back+In+Black
This doesn't:
http://192.168.1.10:8000/admin/metadata?mount=%F2mystream&mode=updinfo&song=ACDC+Back+In+Black
Response is: 400 - Source does not exist
Thomas B. RückerThomas B. Rückerhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/2096use setresuid()/setresgid() instead of setuid()/setgid()2018-03-06T12:49:47Zd26264b9use setresuid()/setresgid() instead of setuid()/setgid()We should be dropping privileges with setresuid()/setresgid() when requested as recommended by "Setuid Demystified" (http://www.cs.berkeley.edu/~daw/papers/setuid-usenix02.pdf).
Also, chdir("/") after chroot() and actually check for pro...We should be dropping privileges with setresuid()/setresgid() when requested as recommended by "Setuid Demystified" (http://www.cs.berkeley.edu/~daw/papers/setuid-usenix02.pdf).
Also, chdir("/") after chroot() and actually check for proper return values on both. This was modelled after OpenSSH's chroot() logic.
Tested on OpenBSD. Someone should try compiling/testing on Linux to verify. As far as I can tell, the proper syscalls are implemented on Linux as well.
```
--- src/main.c Mon May 5 18:29:06 2014
+++ src/main.c Thu Nov 27 18:55:34 2014
@@ -377,7 +377,7 @@
fprintf(stderr, "WARNING: Cannot change server root unless running as root.\n");
return;
}
- if(chroot(conf->base_dir))
+ if(chroot(conf->base_dir) == -1 || chdir("/") == -1)
{
fprintf(stderr,"WARNING: Couldn't change server root: %s\n", strerror(errno));
return;
@@ -398,7 +398,7 @@
}
if(uid != (uid_t)-1 && gid != (gid_t)-1) {
- if(!setgid(gid))
+ if(!setresgid(gid, gid, gid))
fprintf(stdout, "Changed groupid to %i.\n", (int)gid);
else
fprintf(stdout, "Error changing groupid: %s.\n", strerror(errno));
@@ -406,7 +406,7 @@
fprintf(stdout, "Changed supplementary groups based on user: %s.\n", conf->user);
else
fprintf(stdout, "Error changing supplementary groups: %s.\n", strerror(errno));
- if(!setuid(uid))
+ if(!setresuid(uid, uid, uid))
fprintf(stdout, "Changed userid to %i.\n", (int)uid);
else
fprintf(stdout, "Error changing userid: %s.\n", strerror(errno));
```
Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/icecast-server/-/issues/2033Json output fails parser lint2018-03-06T12:49:47ZKompilerJson output fails parser lintStrange json output that fails the json lint test and php fails to parse. Here's a sample output that is broke.
sample broken json:
{"icestats":{"admin":"icemaster@localhost","host":"localhost","location":"Earth","server_id":"Icecast ...Strange json output that fails the json lint test and php fails to parse. Here's a sample output that is broke.
sample broken json:
{"icestats":{"admin":"icemaster@localhost","host":"localhost","location":"Earth","server_id":"Icecast 2.4.0","server_start":"Tue, 29 Jul 2014 00:53:00 +0200","server_start_iso8601":"2014-07-29T00:53:00+0200","source":[{"audio_info":"bitrate=256;channels=2;samplerate=44100","bitrate":256,"channels":2,"genre":"Various","listener_peak":0,"listeners":0,"listenurl":"http://localhost:8000/User","samplerate":44100,"server_description":"User live in the mix on server.tv!","server_name":"server.tv - User","server_type":"audio/mpeg","server_url":"http://server.tv/live/index/User","stream_start":"Tue, 29 Jul 2014 00:53:01 +0200","stream_start_iso8601":"2014-07-29T00:53:01+0200",,{"audio_info":"bitrate=256;channels=2;samplerate=44100","bitrate":256,"channels":2,"genre":"Various","listener_peak":0,"listeners":0,"listenurl":"http://localhost:8000/autodj","samplerate":44100,"server_description":"server.tv Replays","server_name":"server.tv Radio","server_type":"audio/mpeg","server_url":"http://server.tv/","stream_start":"Tue, 29 Jul 2014 00:53:01 +0200","stream_start_iso8601":"2014-07-29T00:53:01+0200","title":"server.tv Radio: User - M”ix,]}}Thomas B. RückerThomas B. Rückerhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/2097In <listener> in some tags are camelcase that should be converted to lowercase.2018-03-06T12:49:47ZPhilipp SchafftIn <listener> in some tags are camelcase that should be converted to lowercase.in <listener> the following tags are camelcase: <ID>, <IP>, <UserAgent> and <Connected>. Those should be converted to lower case.
XML tells that tag names are case sensitive.
This needs to be documented before we can change it and be cha...in <listener> the following tags are camelcase: <ID>, <IP>, <UserAgent> and <Connected>. Those should be converted to lower case.
XML tells that tag names are case sensitive.
This needs to be documented before we can change it and be changed with a major release. I suggest to document it as 'Parsers MUST be case insensitive for ALL tags in ANY admin/-command output.'
```
09:51 <+tbr> as a broad statement, I'd not expect this change to happen before 2.6
09:52 < ph3-der-loewe> I haven't thought about a timeline for that already.
09:52 < ph3-der-loewe> I'm fine with <= 3.0.0 :)
09:53 < ph3-der-loewe> with 3.0.0 the question that arise is if the interface still exist ;)
```
Please review this before 2.5 to check if we are on-track on this.Icecast 2.5.0Thomas B. RückerThomas B. Rückerhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/2037Check if Icecast returns HTTP 200 on disallowed metadata updates2018-03-06T12:49:47ZThomas B. RückerCheck if Icecast returns HTTP 200 on disallowed metadata updatesWe've had a report that some version of Icecast might be doing this.
http://lists.xiph.org/pipermail/icecast/2014-August/012905.html
We should check if this is the case and if so consider changing it to a 403, accompanied by a sensible ...We've had a report that some version of Icecast might be doing this.
http://lists.xiph.org/pipermail/icecast/2014-August/012905.html
We should check if this is the case and if so consider changing it to a 403, accompanied by a sensible error message.Thomas B. RückerThomas B. Rückerhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/2098TAGs for comments in all icecast projects2018-03-06T12:49:47ZPhilipp SchafftTAGs for comments in all icecast projectsI suggest to define the following tags in comments for more easy finding stuff that needs to be reviewed or handled in future release. Those tags should be added as part of the coding style guide to define some standard for the Icecast p...I suggest to define the following tags in comments for more easy finding stuff that needs to be reviewed or handled in future release. Those tags should be added as part of the coding style guide to define some standard for the Icecast project and be used by all components handed by the project including but not limited to the Icecast server, Ices2 and the library subprojects. I'm unsure if/how it will match the stream directory subproject.
The following tags should be defined:
Actions:
- REVIEW: ask for a review of this.
- REWRITE: ask for a rewrite of this section.
- TODO: ask for implementation of a feature.
- FIXME: ask correcting an implementation.
- REMOVE: remove a block or feature.
- DOCUMENT: documentation for this block or feature is missing, incomplete or wrong and needs update.
Conditions:
- [BEFORE|AFTER|IN] RELEASE $version: This is relevant to release $version. $version can also be NEXT.
- [BEFORE|AFTER|IN] YEAR $yyyy: This is relevant to (4-digit) year $yyyy
Extra Tags:
- IMPORTANT: This is an important problem.
- SECURITY: This is security critical.
- LEAK: This leaks some resource (memory, file descriptors, ...).
Syntax:
```
/* [CONDITION[ CONDITION[...]]] [EXTRA TAGS] ACTION [#TICKET]: DESCRIPTION
* [LONG DESCRIPTION]
*/
```
Examples:
```
/* BEFORE RELEASE 2.5.3 REVIEW #1234: Should we convert A to B?
* A is according to standard REF0. This standard was superseded by
* standard REF1 which could be implemented with option B.
* This may break early clients of standard REF0 not being aware of SOMETHING.
*/
/* IN YEAR 2022 REWRITE: Change copyright statement as license expires. */
/* LEAK FIXME #1234: Fix case object can not be added to queue. */
/* BEFORE RELEASE NEXT IMPORTANT SECURITY FIXME #1234: Do not expose passwords on authentication failure of backend server */
/* AFTER RELEASE 2.5.3 REMOVE: Remove support for icecast 1.x style SOURCE requests */
```Thomas B. RückerThomas B. Rückerhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/2039Icecast segfault : auth_url.c2018-03-06T12:49:47ZTeddyIcecast segfault : auth_url.cHi !
I'm using Icecast 2.4.0 with stream_auth authentication option.
When Nicecast (OSX streaming client) connects and sends metadata, a segfault occurs.
I investigated a bit, and it seems that _client->username_ and _client->password_...Hi !
I'm using Icecast 2.4.0 with stream_auth authentication option.
When Nicecast (OSX streaming client) connects and sends metadata, a segfault occurs.
I investigated a bit, and it seems that _client->username_ and _client->password_ (auth_url.c, lines 542/543) are both _null_.
My icecast.xml config file is almost genuine (changed the port, and configured a mountpoint with stream_auth). Please see attachments.
Here is a GDB run :
```
(gdb) run -c etc/icecast.xml
Starting program: /home/radioking/icecast-dbg/icecast-2.4.0/build/bin/icecast -c etc/icecast.xml
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[New Thread 0x7ffff7fda700 (LWP 16800)]
[New Thread 0x7ffff7f59700 (LWP 16801)]
[New Thread 0x7ffff7ed8700 (LWP 16802)]
[New Thread 0x7ffff14ca700 (LWP 16803)]
[New Thread 0x7ffff1449700 (LWP 16804)]
[Thread 0x7ffff1449700 (LWP 16804) exited]
[New Thread 0x7ffff083f700 (LWP 16805)]
[New Thread 0x7ffff07be700 (LWP 16806)]
[Thread 0x7ffff083f700 (LWP 16805) exited]
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7ffff7fda700 (LWP 16800)]
strlen () at ../sysdeps/x86_64/strlen.S:106
106 ../sysdeps/x86_64/strlen.S: Aucun fichier ou dossier de ce type.
```
And the backtrace :
```
(gdb) bt
#0 strlen () at ../sysdeps/x86_64/strlen.S:106
#1 0x000000000040ba9c in util_url_escape (src=0x0) at util.c:269
#2 0x000000000041e0db in url_stream_auth (auth_user=<optimized out>)
at auth_url.c:542
#3 0x000000000041ac80 in stream_auth_callback (auth=0x64cf20, auth_user=0x684280)
at auth.c:248
#4 0x000000000041a5cf in auth_run_thread (arg=arg@entry=0x64cf20) at auth.c:311
#5 0x0000000000421e77 in _start_routine (arg=0x657550) at thread.c:657
#6 0x00007ffff68c4182 in start_thread (arg=0x7ffff7fda700) at pthread_create.c:312
#7 0x00007ffff65f130d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111
```Icecast 2.5.0Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/icecast-server/-/issues/2102Make strcmp in main.c#_start_logging explicit2018-03-06T12:49:47ZMicheil SmithMake strcmp in main.c#_start_logging explicitCurrently the don't pipe to standard output options are in the else branch, because of usage of `strcmp` such as `if ( strcmp(a, b) ) { `.
This gist https://gist.github.com/miksago/cfb3f41784bff197facc includes changes to make the comp...Currently the don't pipe to standard output options are in the else branch, because of usage of `strcmp` such as `if ( strcmp(a, b) ) { `.
This gist https://gist.github.com/miksago/cfb3f41784bff197facc includes changes to make the comparison of strings explicit as well as changes the logic to be:
```
if config->access_log == '-'; then
handle standard output
else
handle logging
```
Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/icecast-server/-/issues/2047Icecast 2.4.0 - status-json.xsl - parse error2018-03-06T12:49:47ZGhost UserIcecast 2.4.0 - status-json.xsl - parse errorHello,
The attached status json file does not parse.
The file is here:
http://www.noizeukradio.com:8000/status-json.xsl
This topic looks similar:
http://icecast.imux.net/viewtopic.php?t=8240
Thanks,
DavidHello,
The attached status json file does not parse.
The file is here:
http://www.noizeukradio.com:8000/status-json.xsl
This topic looks similar:
http://icecast.imux.net/viewtopic.php?t=8240
Thanks,
DavidIcecast 2.5.0Thomas B. RückerThomas B. Rücker