Skip to content

GitLab

Closed
Opened by moo@moo

[kh] hang not accepting source

i have client connect to kh branch of icecast with no success

in changeset [16524]

sock = sock_accept(serversock, ip, MAX_ADDR_LEN);

is changed to

sock = sock_accept (serversock, NULL, 0);

while in changeset [15864]

if (!sock_valid_socket(serversock)) 
  return SOCK_ERROR;

is changed to

if (ip == NULL || len == 0 || !sock_valid_socket(serversock)) 
  return SOCK_ERROR;

sock_accept (serversock, NULL, 0) will always return SOCK_ERROR. no client will be accept()ed