Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
Icecast-Server
Icecast-Server
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 94
    • Issues 94
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • External Wiki
    • External Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Xiph.Org
  • Icecast-ServerIcecast-Server
  • Issues
  • #1617

Closed
Open
Opened Nov 04, 2009 by moo@moo

[kh] hang not accepting source

i have client connect to kh branch of icecast with no success

in changeset [16524]

sock = sock_accept(serversock, ip, MAX_ADDR_LEN);

is changed to

sock = sock_accept (serversock, NULL, 0); 

while in changeset [15864]

if (!sock_valid_socket(serversock)) 
  return SOCK_ERROR; 

is changed to

if (ip == NULL || len == 0 || !sock_valid_socket(serversock)) 
  return SOCK_ERROR; 

sock_accept (serversock, NULL, 0) will always return SOCK_ERROR. no client will be accept()ed

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: xiph/icecast-server#1617