Icecast down when connection limit is reached
This bug was induce by changeset [9733] and [9740]. In connection.c,
if (client_create (&client, con, NULL) < 0)
{
global_unlock();
client_send_404 (client, "Icecast connection limit reached");
continue;
}
But,
- client can be NULL if the calloc in client_create() fails
- even if client is not NULL, client->refbuf is still NULL And the server will go down in client_send_404()