Commit 2bb49dee authored by Marvin Scholz's avatar Marvin Scholz Committed by Philipp Schafft

Fix: Add missing log message arguments

Found with lgtm.com
parent 859fae25
Pipeline #390 failed with stage
in 11 seconds
...@@ -859,10 +859,10 @@ client_slurp_result_t client_body_skip(client_t *client) ...@@ -859,10 +859,10 @@ client_slurp_result_t client_body_skip(client_t *client)
char buf[2048]; char buf[2048];
int ret; int ret;
ICECAST_LOG_DEBUG("Slurping client %p"); ICECAST_LOG_DEBUG("Slurping client %p", client);
if (!client) { if (!client) {
ICECAST_LOG_DEBUG("Slurping client %p ... failed"); ICECAST_LOG_DEBUG("Slurping client %p ... failed", client);
return CLIENT_SLURP_ERROR; return CLIENT_SLURP_ERROR;
} }
...@@ -870,7 +870,7 @@ client_slurp_result_t client_body_skip(client_t *client) ...@@ -870,7 +870,7 @@ client_slurp_result_t client_body_skip(client_t *client)
size_t left = (size_t)client->request_body_length - client->request_body_read; size_t left = (size_t)client->request_body_length - client->request_body_read;
if (!left) { if (!left) {
ICECAST_LOG_DEBUG("Slurping client %p ... was a success"); ICECAST_LOG_DEBUG("Slurping client %p ... was a success", client);
return CLIENT_SLURP_SUCCESS; return CLIENT_SLURP_SUCCESS;
} }
...@@ -880,10 +880,10 @@ client_slurp_result_t client_body_skip(client_t *client) ...@@ -880,10 +880,10 @@ client_slurp_result_t client_body_skip(client_t *client)
client_body_read(client, buf, left); client_body_read(client, buf, left);
if ((size_t)client->request_body_length == client->request_body_read) { if ((size_t)client->request_body_length == client->request_body_read) {
ICECAST_LOG_DEBUG("Slurping client %p ... was a success"); ICECAST_LOG_DEBUG("Slurping client %p ... was a success", client);
return CLIENT_SLURP_SUCCESS; return CLIENT_SLURP_SUCCESS;
} else { } else {
ICECAST_LOG_DEBUG("Slurping client %p ... needs more data"); ICECAST_LOG_DEBUG("Slurping client %p ... needs more data", client);
return CLIENT_SLURP_NEEDS_MORE_DATA; return CLIENT_SLURP_NEEDS_MORE_DATA;
} }
} else { } else {
...@@ -893,15 +893,15 @@ client_slurp_result_t client_body_skip(client_t *client) ...@@ -893,15 +893,15 @@ client_slurp_result_t client_body_skip(client_t *client)
ret = client_body_eof(client); ret = client_body_eof(client);
switch (ret) { switch (ret) {
case 0: case 0:
ICECAST_LOG_DEBUG("Slurping client %p ... needs more data"); ICECAST_LOG_DEBUG("Slurping client %p ... needs more data", client);
return CLIENT_SLURP_NEEDS_MORE_DATA; return CLIENT_SLURP_NEEDS_MORE_DATA;
break; break;
case 1: case 1:
ICECAST_LOG_DEBUG("Slurping client %p ... was a success"); ICECAST_LOG_DEBUG("Slurping client %p ... was a success", client);
return CLIENT_SLURP_SUCCESS; return CLIENT_SLURP_SUCCESS;
break; break;
default: default:
ICECAST_LOG_DEBUG("Slurping client %p ... failed"); ICECAST_LOG_DEBUG("Slurping client %p ... failed", client);
return CLIENT_SLURP_ERROR; return CLIENT_SLURP_ERROR;
break; break;
} }
......
...@@ -73,7 +73,7 @@ static inline event_exec_argvtype_t __str2argvtype(const char *str) { ...@@ -73,7 +73,7 @@ static inline event_exec_argvtype_t __str2argvtype(const char *str) {
} else if (strcmp(str, "legacy") == 0) { } else if (strcmp(str, "legacy") == 0) {
return ARGVTYPE_LEGACY; return ARGVTYPE_LEGACY;
} else { } else {
ICECAST_LOG_ERROR("Unknown argument type %s, using \"default\""); ICECAST_LOG_ERROR("Unknown argument type %s, using \"default\"", str);
return ARGVTYPE_DFAULT; return ARGVTYPE_DFAULT;
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment