1. 07 Jul, 2018 1 commit
  2. 30 Jun, 2018 1 commit
    • Philipp Schafft's avatar
      Fix: Report correct listen URL to client. · 7742bf0a
      Philipp Schafft authored
      The URL is constructed considering Protocol, TLS Mode, Host, and Port.
      
      This considers:
       - The Host:-header as provided by the client,
       - The effective listensocket of the client,
       - Global configuration.
      
      This works for:
       - Playlist generation,
       - Admin authed playlist generation,
       - Stats based XSLT.
      
      It also unifies code:
       - Default stats values.
      
      Not yet included:
       - YP requests.
      7742bf0a
  3. 19 Jun, 2018 3 commits
  4. 17 Jun, 2018 2 commits
  5. 07 May, 2018 1 commit
    • Philipp Schafft's avatar
      Feature: Generate errors based on IDs. · b42378ab
      Philipp Schafft authored
      This generates error pages based on IDs. This allows to reuse errors
      and add more advanced information to them.
      
      This patch also makes Icecast send in plain text OR HTML based
      on the clients Accept:-string.
      b42378ab
  6. 13 Apr, 2018 1 commit
  7. 23 Jul, 2017 1 commit
  8. 04 Sep, 2016 1 commit
  9. 28 Nov, 2015 1 commit
  10. 06 Jun, 2015 1 commit
  11. 08 Apr, 2015 1 commit
  12. 28 Mar, 2015 2 commits
    • Philipp Schafft's avatar
      Added config option for history size. · 961453b0
      Philipp Schafft authored
      This adds a <max-history> config option to the <mount> section.
      Default is a history size of 4.
      
      See: #766
      961453b0
    • Philipp Schafft's avatar
      Initial patch for playlist history support. · 5f77b35d
      Philipp Schafft authored
      This allows to store a history of played songs along the source
      object and report it as part of the status XML.
      
      Additional work needs to be done to make this configurable.
      Also format_mp3.c needs work to support this.
      
      A generic song changed handler should be implemented to handle this
      in a nice way.
      That one should also be the point to call logging_playlist().
      
      See: #766
      5f77b35d
  13. 01 Mar, 2015 1 commit
    • Thomas B. Rücker's avatar
      Fixed log messages and comments · 671c2366
      Thomas B. Rücker authored
       * Reworded many log messages for better understanding.
       * Adjusted some version targets as we won't have a 2.4.2 release.
       * Added some FIXME comments
      671c2366
  14. 10 Feb, 2015 1 commit
    • Philipp Schafft's avatar
      Cleanup: unbreak 100-continue a bit. · 79cb147c
      Philipp Schafft authored
      This tries to unbreak the 100-continue thing a bit.
      Proper headers are send in case of 100-continue. Also the 200 OK
      was moved to the end of the stream.
      The client may even be reused. But I'm not sure we only do
      'End of stream' in cases we are not on an undefined state of the
      client. Do we as of now support anything that give us EOS without
      a fatal socket state (error or shutdown)?
      
      At least this unbreaks 100-continue with active TLS that was broken
      as hell as we sent the header in clear over the socket. Not checking
      if it was transmitted completly or something. Using lowlevel socket
      calls (in contrast to the connection level calls that would have
      handled the TLS just fine).
      
      While this seem sto be a huge improvement to the situation I kindly
      ask you to do a lot testing on this. Both with SOURCE as well as
      PUT clients.
      79cb147c
  15. 07 Feb, 2015 1 commit
  16. 10 Jan, 2015 2 commits
  17. 20 Dec, 2014 1 commit
  18. 08 Dec, 2014 1 commit
    • Philipp Schafft's avatar
      Added <event>: Unified handling of events. · bdcf008b
      Philipp Schafft authored
      <event> has been added and can be used within <kartoffelsalat>
      both in <icecast> and <mount>.
      <event> takes backend depending <option> child tags.
      Currently supported backends:
       - log: send message to error log.
       - exec: executes a program or script.
       - url: delivers the event via HTTP.
      
      within <mount> <on-connect> and <on-disconnect> has been replaced by
      <event>. Config parser can on-the-fly convert old tags.
      Also <authentication type="url"> within <mount> has been fixed
      for those cases with <option name="mount_add" .../> and
      <option name="mount_remove" .../> which are now on-the-fly converted
      by the parser to corresponding <event> tags.
      
      Please also see TAGs added as per #2098. Some include hints for
      documentation updates needed after this change. Those updates
      should take place before 2.4.2.
      bdcf008b
  19. 02 Dec, 2014 1 commit
  20. 30 Nov, 2014 1 commit
  21. 28 Nov, 2014 1 commit
    • Philipp Schafft's avatar
      Wow. Mega patch! · a642cac5
      Philipp Schafft authored
      This patch *replaces* the authentication system completly.
      
      What is new:
       - <authentication> in mount section is now a container object.
       - <authentication> in root and mount section may hold any number of <role>-Tags.
       - <role> tags:
         Those tags define a 'role' and it's ACL rules.
         A role is a instance of an authentication module (see below).
         <role> takes the following options. All but type are optional.
         - authentication related:
           - type: Type of the authentication module (values: anonymous, static, legacy-password, url or htpasswd;
                   symbolic constants in auth.h)
           - name: Name for the role. For later matching. (values: any string; default: (none))
           - method: This rule is only active on the given list of HTTP methods.
                     (list of enum values: methods as recognized by httpp/ (e.g: get,post); default: *)
         - ACL related:
           - allow-method: Allowed HTTP methods.
             (list of enum values: methods as recognized by httpp/ (e.g: get,post); default: get)
           - deny-method: Rejected HTTP methods.
             (list of enum values: methods as recognized by httpp/ (e.g: get,post); default: *)
           - allow-admin: Allowed admin commands. (list of enum values: admin command; default: buildm3u)
           - deny-admin: Rejected admin commands. (list of enum values: admin command; default: *)
           - allow-web: Allowed web pages. (values: empty or *; default: *)
           - deny-web: Rejected web pages. (values: empty or *; default: (empty))
           - connections-per-user: maximum number of simultaneous connections per role and username.
             This is only active on active sources.  (values: unlimited or number of connections; default: unlimited)
           - connection-duration: maximum time of a connection. This is only active on active sources.
             (values: unlimited or number of secounds; default: unlimited)
         <role> takes <option> child tags. <option> tags contain a name and a value option.
         Meaning of <option> tags is up to the authentication module.
       - <role>s are considered to build a stack. If a role returns with AUTH_NOMATCH the next one will be tried.
       - <role>s are tested in this order: mount specific, default mount specific, global, internal fallback.
         Internal fallback is set to allow web/ access via GET, POST and HEAD (only GET supported by this time)
         and rejects all other requests.
       - New authentication module: anonymous
         This module matches all requests. No options taken.
       - New authentication module: static
         This module matches with a static username and password.
         It takes two <option>s. One with name="username" and one with name="password" to set username and password.
         This replaces old style <*-username> and <*-password> tags.
       - New authentication module: legacy-password
         This module matches with a statich password.
         It takes one <option> with name="password" to set password.
         This replaces old ICE and ICY (shoutcast compat mode) authentication.
       - Parsing <authentication> in <mount> with a type set in a special way to allow 100% backward compatibility.
       - Parsing of <source-password>, <admin-password>, <admin-user>, <relay-password> and <relay-user> in global
         <authentication> for 100% backward compatibility.
       - <alias> is now proccessed very early. This enables them to be used for all kinds of requests.
      
      To Do List & What does not yet work:
       - type="url" auth: mount_add and mount_remove.
         This should be replaced by an unique feature I would call '<event>'.
       - Admin commands manageauth and manageauth.xsl are disabled as they need more review:
         This code needs to be ported to support multiple <role>s per <mount>.
       - url authentication module can not yet return AUTH_NOMATCH.
         This needs to be reviewed and discussed on how to handle this case best way.
       - Default config files needs to be updated to reflect the changes.
         As this is quite some political act it should be done in dicussion with the whole team
         and permission of the release manager.
       - Docs need to be updated to reflect the changes.
      
      How does it work:
       Code has been changed so that authentification is done early for all clients.
       This allows accessing the ACL data (client->acl) from nearly everywhere in the code.
      
       After accept() and initial client setup the request is parsed. In the next step
       all <alias>es are resolved. After this the client is passed for authentication.
       After authentication it is passed to the corresponding subsystem depending on kind of request.
      
       All authentication instances have a thread running for doing the authentication.
       This thread works on a queue of clients.
      
      Hints for testers:
       - Test with default config.
       - Test with diffrent authentication modules in <mount>.
       - Test shoutcast compatibility mode.
       - Test with new style <authentication> and any amount of <role> (zero to quite some).
       - Test <alias> lookup on all kinds of objects.
       - Test source level credential login into the admin interface.
       - Test shoucast style meta data updates.
       - Test playlist generation.
      
      Thank you for reading this long commit message. Have fun reading the full patch!
      
      svn path=/icecast/trunk/icecast/; revision=19358
      a642cac5
  22. 21 Nov, 2014 2 commits
  23. 19 Nov, 2014 1 commit
  24. 17 Nov, 2014 1 commit
  25. 31 Oct, 2014 2 commits
  26. 23 Oct, 2014 1 commit
    • ePirat's avatar
      More detailed logging · 461a5375
      ePirat authored
      Add source IP adress to startup and source exit logging, see #2016
      Add mountpoint to some log lines, see #1388
      
      
      svn path=/icecast/trunk/icecast/; revision=19250
      461a5375
  27. 09 Oct, 2014 1 commit
  28. 04 May, 2014 1 commit
  29. 02 Apr, 2013 1 commit
    • Philipp Schafft's avatar
      Added support for a default mount. See #1914. · d54c61bf
      Philipp Schafft authored
      The default mount is a block in the config file that contains settings for
      all mount points that do not have a block in configfile themself.
      This is implemented by a <mount type="default">-block.
      In this case the <mount>-block MUST NOT contain a <mount-name>-subblock.
      
      svn path=/icecast/trunk/icecast/; revision=18902
      d54c61bf
  30. 14 Oct, 2012 1 commit
  31. 17 Jul, 2012 3 commits