Icecast-Server issueshttps://gitlab.xiph.org/xiph/icecast-server/-/issues2018-03-06T12:49:49Zhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/803Max listeners causes server crash2018-03-06T12:49:49ZDavidMax listeners causes server crashI have a mount without a username, where username is blank <username></username>.
I set max listeners to 1 and connected to the source as a 2nd listener and it crashed the server.. First connection was from winamp 2nd connection was fro...I have a mount without a username, where username is blank <username></username>.
I set max listeners to 1 and connected to the source as a 2nd listener and it crashed the server.. First connection was from winamp 2nd connection was from WMP.
Will test the 2nd listener from a differnt computer. because most people will not launch 2 seprate connections from the same machine. stay tuned....Karl HeyesKarl Heyeshttps://gitlab.xiph.org/xiph/icecast-server/-/issues/802Icecast mounts and Sam 32018-03-06T12:49:49ZDavidIcecast mounts and Sam 3using Sam 3 encoder does not recoginze the username and password for authenticating source when mount is specified in Icecast config. So in effect I can use Sam and Icecast. Only if I don't declare a mount in the icecast config file. Ice...using Sam 3 encoder does not recoginze the username and password for authenticating source when mount is specified in Icecast config. So in effect I can use Sam and Icecast. Only if I don't declare a mount in the icecast config file. Icecast will automatically declare whatever Sam shows and broadcast.
This would normally be ok if I was just streaming 1 broadcast, but I'm trying to manage mutiple broadcast and thier max listener capacity and stream quality.
Is there a workaround for this without declaring a mount? Icecast seems to be declaring mounts on the fly from Sam3, but like I said it leaves connections as unlimited....
Can you help fix this?Icecast 2.3Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/801Icecast server source details max-listeners2018-03-06T12:49:49ZDavidIcecast server source details max-listenersSpecified on the mount the number of max listeners to 1. Tried connecting form 2 different sources and it still allowed the 2nd connection. In addtion the sever details shows max_listeners "unlimited" instead of 1Specified on the mount the number of max listeners to 1. Tried connecting form 2 different sources and it still allowed the 2nd connection. In addtion the sever details shows max_listeners "unlimited" instead of 1Icecast 2.3Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/800URL listener authenticator2018-03-06T12:49:49ZDavidURL listener authenticatorYour URL auth is not working properly I used the examples in the domumentation altering my url and it does not auth. it just connects to the stream...In addtion with the basic orginal file admin control panel does not show the red key...
Your URL auth is not working properly I used the examples in the domumentation altering my url and it does not auth. it just connects to the stream...In addtion with the basic orginal file admin control panel does not show the red key...
Icecast 2.3Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/798Nothing appears on icecast when i'm broadcasting2018-03-06T12:49:49ZdeepbluesensationsNothing appears on icecast when i'm broadcastingHello there,
My server is saying that i'm broadcasting, but i find no traces of my program on icecast at my usual page, then nobody can listen to my program...
grrrr
The SmurfHello there,
My server is saying that i'm broadcasting, but i find no traces of my program on icecast at my usual page, then nobody can listen to my program...
grrrr
The SmurfMichael SmithMichael Smithhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/794[PATCH] Autotools and header fixes2018-06-15T21:35:52Zgtgbr[PATCH] Autotools and header fixes* Improve autotools handling of sys/time.h and time.h -- it should be checked whether both may be included simultaneously.
* Actually use the XIPH_C__FUNC__ macro, since #ifdef __SUNPRO_C was removed from src/compat.h
* A bit of header...* Improve autotools handling of sys/time.h and time.h -- it should be checked whether both may be included simultaneously.
* Actually use the XIPH_C__FUNC__ macro, since #ifdef __SUNPRO_C was removed from src/compat.h
* A bit of header/includes cleanup. Icecast sources search for support libs locally first, not in system include paths.
* Remove spurious CRs
* Do not let Windows include <stdio.h> twice in src/util.cMichael SmithMichael Smithhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/791[PATCH] More type related cleanups2018-11-10T13:05:43Zgtgbr[PATCH] More type related cleanupsMore type related cleanups:
* Add casts where implicit casting would happen otherwise (covers all, except those int->char casts that are harmless.)
* Resolve accuracy issues, mostly by changing long to int (except in one case in source...More type related cleanups:
* Add casts where implicit casting would happen otherwise (covers all, except those int->char casts that are harmless.)
* Resolve accuracy issues, mostly by changing long to int (except in one case in source.c where it's the other way round)
* More int -> size_t changes when buffer sizes are involved. While doing so, slightly rewrite get_line() in auth_htpasswd.c to not shadow the len parameter.
* While in httpp.h, remove prototype for nonexistent function httpp_parse_icy()
* Adjust sanity checks to not test whether an unsigned variable is < 0
* In net/sock.c, use sizeof(ip) instead of MAX_ADDR_LEN
* Do not forget to #include <sys/types.h> and "compat.h" whenever _t types are usedIcecast 2.5.0Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/icecast-server/-/issues/789Use proper function prototypes and declarations (2/2)2018-03-06T12:49:49ZgtgbrUse proper function prototypes and declarations (2/2)ANSI C requires function prototype and declaration to be of the same static'ness.ANSI C requires function prototype and declaration to be of the same static'ness.Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/788Use proper function prototypes and declarations (1/2)2018-03-06T12:49:49ZgtgbrUse proper function prototypes and declarations (1/2)void foobar();
is not the same as
void foobar(void);
Fix those, and while around in auth.h, de-lint the enum.void foobar();
is not the same as
void foobar(void);
Fix those, and while around in auth.h, de-lint the enum.Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/787[PATCH] Clean up remaining signedness issues2018-03-06T12:49:49Zgtgbr[PATCH] Clean up remaining signedness issuesRecent versions of gcc on Linux, e.g. gcc on Debian/sarge (or rather, Debian/testing) complains a lot, making warnings less useful for easily spotting problems. The bulk of the warnings is taken care of in the incompatible_pointer patche...Recent versions of gcc on Linux, e.g. gcc on Debian/sarge (or rather, Debian/testing) complains a lot, making warnings less useful for easily spotting problems. The bulk of the warnings is taken care of in the incompatible_pointer patches, this cleans up the rest. After this, Icecast is -Wall clean on Linux again.
While around in src/util.c, fix up some int->size_t's.Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/786Fix bad __FUNCTION__ defines2018-03-06T12:49:49ZgtgbrFix bad __FUNCTION__ definesAlso take into account that strrchr() may be used in some cases (e.g. on Windows), so adjust the headers.
Remove the __SUNPRO_C case, as it is taken care of during configure time by xiph_compiler.m4.Also take into account that strrchr() may be used in some cases (e.g. on Windows), so adjust the headers.
Remove the __SUNPRO_C case, as it is taken care of during configure time by xiph_compiler.m4.Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/785[PATCH] Explicitly casts for (un)signed char* conversions (3/3)2018-03-06T12:49:49Zgtgbr[PATCH] Explicitly casts for (un)signed char* conversions (3/3)Mop up the rest ... after this, lint is happy about it (gcc on recent Linux dists isn't quite happy yet, though.)Mop up the rest ... after this, lint is happy about it (gcc on recent Linux dists isn't quite happy yet, though.)Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/784[PATCH] Explicitly casts for (un)signed char* conversions (2/3)2018-03-06T12:49:49Zgtgbr[PATCH] Explicitly casts for (un)signed char* conversions (2/3)Pass 2/3: Add another macro, CCPSTR(str), for the other way round: casts to (const char *).Pass 2/3: Add another macro, CCPSTR(str), for the other way round: casts to (const char *).Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/783[PATCH] Explicitly casts for (un)signed char* conversions (1/3)2018-03-06T12:49:49Zgtgbr[PATCH] Explicitly casts for (un)signed char* conversions (1/3)Pass 1/3: Add XMLSTR(str) macro to cast to (xmlChar *). Requires a fix to global.h, which needs to #include "avl/avl.h" for its avl_tree usage.Pass 1/3: Add XMLSTR(str) macro to cast to (xmlChar *). Requires a fix to global.h, which needs to #include "avl/avl.h" for its avl_tree usage.Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/782Treat ICECAST_VERSION_STRING as user-settable ...2018-03-06T12:49:49ZgtgbrTreat ICECAST_VERSION_STRING as user-settable ...... and thus protect format strings from it. There's also this feature request that people want to be able to set the version string in the configuration file, so this patch prepares for that feature's implementation.... and thus protect format strings from it. There's also this feature request that people want to be able to set the version string in the configuration file, so this patch prepares for that feature's implementation.Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/781Facilitate auditing by explicitly using "unsigned int" instead of just "unsig...2018-03-06T12:49:49ZgtgbrFacilitate auditing by explicitly using "unsigned int" instead of just "unsigned"Improves readability and makes code more consistent.Improves readability and makes code more consistent.Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/780[PATCH] Make refbufs use size_t for sizes instead of unsigned long2018-03-06T12:49:49Zgtgbr[PATCH] Make refbufs use size_t for sizes instead of unsigned longThis may or may not solve any real issues on 64bit archs at the moment, but it surely is more correct and makes large parts of Icecast code more consistent, where adding casts would be necessary otherwise.
This is the first of a long se...This may or may not solve any real issues on 64bit archs at the moment, but it surely is more correct and makes large parts of Icecast code more consistent, where adding casts would be necessary otherwise.
This is the first of a long series of patches that are supposed to enhance Icecast's maintainability, portability and correctness. They are the result of an ongoing (and by now week-long) audit that shows that there are subtle issues hidden in Icecast that only work by accident at this point -- fixing those will make it much easier on the long run to maintain Icecast's quality.Karl HeyesKarl Heyeshttps://gitlab.xiph.org/xiph/icecast-server/-/issues/775default log level should be lower2018-03-06T12:49:49ZGhost Userdefault log level should be lowerIcecast 2.3.1 shipped with the default loglevel of 4, which generates rather more lines than one would want in a production environment. I suggest that this default be changed to 2 or 3.Icecast 2.3.1 shipped with the default loglevel of 4, which generates rather more lines than one would want in a production environment. I suggest that this default be changed to 2 or 3.Icecast 2.3Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/774YP data submitted even when source cannot connect2018-03-06T12:49:49Zchris.aretiYP data submitted even when source cannot connectHi,
I'm using 2.3.0 but as I didn't see it as a bugfix on the list, I'm presuming it remains the same in 2.3.1..
I have icecast set to not allow people to take over source control if someone's connected already, however due to necessit...Hi,
I'm using 2.3.0 but as I didn't see it as a bugfix on the list, I'm presuming it remains the same in 2.3.1..
I have icecast set to not allow people to take over source control if someone's connected already, however due to necessity when some people kill the connected source and broadcast - the main broadcast server still attempts to connect to the source every 15 seconds. This means that when the DJ has finished their set, then simply disconnect and 24 hour playout comes back online.
However, I've noticed with 2.3.0 that even though the broadcast server gets a disconnected error message, the metadata the broadcast server generates whilst the other source is on air manages to update and overwrite that which the current source connection is providing.
In short, metadata from a connecting client (who cannot connect because the source is in use by another client) still manages to be accepted by icecast and updated on the stream.. meaning that the two clients are constantly fighting to keep metadata with that of the current source.
Any help would be much appreciated!
Thanks,
Chris.Icecast 2.3Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/766a list of the last n songs played should be accessible to visitors through st...2018-03-06T12:49:49Zicecast.aphexa list of the last n songs played should be accessible to visitors through status.xslIcecast 2.5.0Philipp SchafftPhilipp Schafft