Skip to content

L
liboggz
Commit d57cd71f authored by conrad's avatar conrad
Browse files
Options

oggz-validate: handle tracking of bos and eos when checking pages, not packets. 

This also adds reporting for "eos marked on page with no completed packets."
For the background to this patch, see the discussion at:
http://lists.xiph.org/pipermail/ogg-dev/2008-February/thread.html


git-svn-id: http://svn.annodex.net/liboggz/trunk@3493 8158c8cd-e7e1-0310-9fa4-c5954c97daef
parent a8954959
Hide whitespace changes
Inline Side-by-side
Showing with 72 additions and 52 deletions
doc/oggz-validate.1.sgml
View file @ d57cd71f
......@@ -100,10 +100,11 @@ manpage.1: manpage.sgml
<listitem><para>Packets out of order</para></listitem>
<listitem><para>Packet belongs to unknown serialno</para></listitem>
<listitem><para>Granulepos decreasing within track</para></listitem>
<listitem><para>Multiple bos packets</para></listitem>
<listitem><para>Multiple eos packets</para></listitem>
<listitem><para>Multiple bos pages</para></listitem>
<listitem><para>Multiple eos pages</para></listitem>
<listitem><para>eos marked but no bos</para></listitem>
<listitem><para>Missing eos packets</para></listitem>
<listitem><para>eos marked on page with no completed packets</para></listitem>
<listitem><para>Granulepos on page with no completed packets</para></listitem>
<listitem><para>Theora video bos page after audio bos page</para></listitem>
</itemizedlist>
......@@ -187,6 +188,10 @@ manpage.1: manpage.sgml
<refsect1>
<title>SEE ALSO</title>
<para>
<citerefentry>
<refentrytitle>oggz-sort</refentrytitle>
<manvolnum>1</manvolnum>
</citerefentry>,
<citerefentry>
<refentrytitle>oggzdump</refentrytitle>
<manvolnum>1</manvolnum>
......
src/tools/oggz-validate.c
View file @ d57cd71f
......@@ -61,6 +61,8 @@ typedef struct _OVData {
OggzTable * missing_eos;
int theora_count;
int audio_count;
int chain_ended;
} OVData;
typedef struct {
......@@ -71,8 +73,8 @@ typedef struct {
static error_text errors[] = {
{-20, "Packet belongs to unknown serialno"},
{-24, "Granulepos decreasing within track"},
{-5, "Multiple bos packets"},
{-6, "Multiple eos packets"},
{-5, "Multiple bos pages"},
{-6, "Multiple eos pages"},
{0, NULL}
};
......@@ -95,7 +97,8 @@ list_errors (void)
printf (" %s\n", errors[i].description);
}
printf (" eos marked but no bos\n");
printf (" Missing eos packets\n");
printf (" Missing eos pages\n");
printf (" eos marked on page with no completed packets\n");
printf (" Granulepos on page with no completed packets\n");
printf (" Theora video bos page after audio bos page\n");
}
......@@ -174,38 +177,6 @@ gp_to_time (OGGZ * oggz, long serialno, ogg_int64_t granulepos)
return (timestamp_t)((double)(granule * gr_d) / (double)gr_n);
}
static int
read_page (OGGZ * oggz, const ogg_page * og, long serialno, void * user_data)
{
OVData * ovdata = (OVData *)user_data;
ogg_int64_t gpos = ogg_page_granulepos((ogg_page *)og);
const char * content_type;
int ret = 0;
if (ogg_page_bos ((ogg_page *)og)) {
content_type = ot_page_identify (oggz, og, NULL);
if (content_type) {
if (!strcmp (content_type, "Theora")) {
ovdata->theora_count++;
if (ovdata->audio_count > 0) {
log_error ();
fprintf (stderr, "serialno %010ld: Theora video bos page after audio bos page\n", serialno);
}
} else if (!strcmp (content_type, "Vorbis") || !strcmp (content_type, "Speex")) {
ovdata->audio_count++;
}
}
}
if(gpos != -1 && ogg_page_packets((ogg_page *)og) == 0) {
ret = log_error ();
fprintf (stderr, "serialno %010ld: granulepos %" PRId64 " on page with no completed packets, must be -1\n", serialno, gpos);
}
return ret;
}
static void
ovdata_init (OVData * ovdata)
{
......@@ -225,6 +196,7 @@ ovdata_init (OVData * ovdata)
ovdata->missing_eos = oggz_table_new ();
ovdata->theora_count = 0;
ovdata->audio_count = 0;
ovdata->chain_ended = 0;
}
static void
......@@ -248,15 +220,37 @@ ovdata_clear (OVData * ovdata)
}
static int
read_packet (OGGZ * oggz, ogg_packet * op, long serialno, void * user_data)
read_page (OGGZ * oggz, const ogg_page * og, long serialno, void * user_data)
{
OVData * ovdata = (OVData *)user_data;
timestamp_t timestamp;
int flush;
int ret = 0, feed_err = 0, i;
ogg_int64_t gpos = ogg_page_granulepos((ogg_page *)og);
const char * content_type;
int ret = 0;
if (op->b_o_s) {
if (ovdata->chain_ended) {
ovdata_clear (ovdata);
ovdata_init (ovdata);
suffix = 0;
}
if (ogg_page_bos ((ogg_page *)og)) {
/* Register this serialno as needing eos */
oggz_table_insert (ovdata->missing_eos, serialno, (void *)0x1);
/* Handle ordering of Theora vs. audio packets */
content_type = ot_page_identify (oggz, og, NULL);
if (content_type) {
if (!strcmp (content_type, "Theora")) {
ovdata->theora_count++;
if (ovdata->audio_count > 0) {
log_error ();
fprintf (stderr, "serialno %010ld: Theora video bos page after audio bos page\n", serialno);
}
} else if (!strcmp (content_type, "Vorbis") || !strcmp (content_type, "Speex")) {
ovdata->audio_count++;
}
}
}
if (!suffix && oggz_table_lookup (ovdata->missing_eos, serialno) == NULL) {
......@@ -264,14 +258,42 @@ read_packet (OGGZ * oggz, ogg_packet * op, long serialno, void * user_data)
fprintf (stderr, "serialno %010ld: missing *** bos\n", serialno);
}
if (!suffix && op->e_o_s) {
if (oggz_table_remove (ovdata->missing_eos, serialno) == -1) {
if (ogg_page_eos((ogg_page *)og)) {
int removed = oggz_table_remove (ovdata->missing_eos, serialno);
if (!suffix && removed == -1) {
ret = log_error ();
fprintf (stderr, "serialno %010ld: *** eos marked but no bos\n",
serialno);
serialno);
}
if (ogg_page_packets((ogg_page *)og) == 0) {
ret = log_error ();
fprintf (stderr, "serialno %010ld: *** eos marked on page with no completed packets\n",
serialno);
}
if (oggz_table_size (ovdata->missing_eos) == 0) {
ovdata->chain_ended = 1;
}
}
if(gpos != -1 && ogg_page_packets((ogg_page *)og) == 0) {
ret = log_error ();
fprintf (stderr, "serialno %010ld: granulepos %" PRId64 " on page with no completed packets, must be -1\n", serialno, gpos);
}
return ret;
}
static int
read_packet (OGGZ * oggz, ogg_packet * op, long serialno, void * user_data)
{
OVData * ovdata = (OVData *)user_data;
timestamp_t timestamp;
int flush;
int ret = 0, feed_err = 0, i;
timestamp = gp_to_time (oggz, serialno, op->granulepos);
if (timestamp != -1.0) {
if (timestamp < current_timestamp) {
......@@ -312,13 +334,6 @@ read_packet (OGGZ * oggz, ogg_packet * op, long serialno, void * user_data)
}
}
/* If this is the last packet in a chain, reset ovdata */
if (op->e_o_s && oggz_table_size (ovdata->missing_eos) == 0) {
ovdata_clear (ovdata);
ovdata_init (ovdata);
suffix = 0;
}
return ret;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment