1. 24 Apr, 2010 1 commit
  2. 20 Apr, 2010 1 commit
    • conrad's avatar
      Fix regression introduced in 8c2da1 · ccd2a2fe
      conrad authored
      When using a recent liboggz, liboggplay fails to play some files. It
      appears it's only files with Kate streams, however some files with
      Kate streams do play fine, but liboggplay reports unknown
      category/language, so that's probably still failing, but in a way that
      liboggplay can recover from.
      
      A sample file which worked before and does not work now is the good old:
      http://people.xiph.org/~oggk/Stephen_Fry-Happy_Birthday_GNU-hq_600px_780kbit.ogv
      This file is seen as correct by oggz-validate.
      
      Issue:
      
      * when oggz_read() sees the first few packets before it sees a
      granulepos, it buffers them in a dlist
      * then, oggz_read_deliver_packet() is a dlist callback which goes
      through these buffered packets and calls the read callback for each
      * the commit you found by bisection returns an error if the
      read_callback returns non-zero; previously the read_callback return
      values were ignored
      * liboggplay's read_predetected(), the read_callback in use during
      stream detection, returns 1 (OGGZ_STOP_OK) when it has done what it
      needs to do
      
      ... hence, the STOP_OK value gets turned into an error value by the
      bad commit.
      
      Reported-by: ogg.k.ogg.k@googlemail.com
      Signed-off-by: conrad's avatarConrad Parker <conrad@metadecks.org>
      ccd2a2fe
  3. 14 Apr, 2010 1 commit
  4. 10 Apr, 2010 1 commit
  5. 01 Apr, 2010 1 commit
  6. 18 Mar, 2010 3 commits
  7. 06 Mar, 2010 2 commits
  8. 11 Feb, 2010 1 commit
  9. 09 Feb, 2010 2 commits
    • conrad's avatar
      Allow NULL-value comments, and form "KEY=" · aee099bc
      conrad authored
      This commit changes the policy of fs_comment_validate_byname() to
      allow NULL-value comments, and changes fs_comment_new() to handle
      the case where value=NULL, and where the comment has no value but
      has an = sign.
      
      This commit should pass "make check", including the policy change
      introduced in the previous commit.
      aee099bc
    • conrad's avatar
      tests: allow NULL-valued comments · f619cbd2
      conrad authored
      This test changes the policy on what comments are valid, to allow
      plain comments, not of the form KEY=VALUE (the condition reported
      in Mozilla #520500).
      
      As this commit only modifies the test suite, 'make check' is
      expected to fail.
      f619cbd2
  10. 28 Nov, 2009 4 commits
  11. 17 Oct, 2009 1 commit
  12. 07 Oct, 2009 2 commits
  13. 04 Oct, 2009 2 commits
  14. 22 Sep, 2009 1 commit
  15. 14 Sep, 2009 4 commits
  16. 12 Sep, 2009 1 commit
  17. 11 Sep, 2009 1 commit
  18. 10 Sep, 2009 2 commits
  19. 30 Aug, 2009 1 commit
  20. 21 Aug, 2009 1 commit
  21. 20 Aug, 2009 1 commit
  22. 14 Aug, 2009 1 commit
    • conrad's avatar
      Annodex #1581: Apply patch from keelerda · 88982d11
      conrad authored
      oggz_comments_decode calls _oggz_comment_add_byname with "value" as NULL
      under certain situations. This can then sometimes cause
      _oggz_comment_add_byname to try to run strcmp on NULL, which fails.
      88982d11
  23. 12 Aug, 2009 2 commits
  24. 08 Jul, 2009 1 commit
  25. 07 Jul, 2009 2 commits