libskeleton issueshttps://gitlab.xiph.org/xiph/libskeleton/-/issues2023-08-14T10:15:27Zhttps://gitlab.xiph.org/xiph/libskeleton/-/issues/2088reserved identifier violation2023-08-14T10:15:27ZMarkus Elfringreserved identifier violation:eyes: I would like to point out that identifiers like “[`__OGG_SKELETON_H__`](https://gitlab.xiph.org/xiph/libskeleton/-/blob/3c56c1b76a9b805bb1e2d2141a43b50f8e2dd232/include/skeleton/skeleton.h#L32 "Update candidate")” and “[`_OggSkele...:eyes: I would like to point out that identifiers like “[`__OGG_SKELETON_H__`](https://gitlab.xiph.org/xiph/libskeleton/-/blob/3c56c1b76a9b805bb1e2d2141a43b50f8e2dd232/include/skeleton/skeleton.h#L32 "Update candidate")” and “[`_OggSkeletonError`](https://gitlab.xiph.org/xiph/libskeleton/-/blob/3c56c1b76a9b805bb1e2d2141a43b50f8e2dd232/include/skeleton/skeleton_constants.h#L40 "Another update candidate")” [do not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier "Do not declare an identifier which is reserved for the compiler implementation.") to the expected naming convention of the C++ language standard.
:thought_balloon: Would you like to adjust your selection for unique names?