Ogg issueshttps://gitlab.xiph.org/xiph/ogg/-/issues2017-04-07T21:51:41Zhttps://gitlab.xiph.org/xiph/ogg/-/issues/94100189582017-04-07T21:51:41Zgumboot10018958```
ogg123 links against /usr/lib/libvorbis.so (which fails because it's out of date) despite there being a /usr/local/lib/libvorbis.so present. This is done explicity in the command issued by make:
gcc -O20 -ffast-math -fsigned-char...```
ogg123 links against /usr/lib/libvorbis.so (which fails because it's out of date) despite there being a /usr/local/lib/libvorbis.so present. This is done explicity in the command issued by make:
gcc -O20 -ffast-math -fsigned-char -o oggenc oggenc.o audio.o encode.o \
platform.o /usr/lib/libvorbis.so -L/lib /usr/lib/libvorbisenc.so -lm \
/usr/lib/libogg.so ../share/libutf8.a ../share/libgetopt.a
```Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/ogg/-/issues/91documentation doesn't mention gmake requirement2006-06-12T11:25:10Znisharfidocumentation doesn't mention gmake requirement```
comatoast@dymaxion: ~/cvsSandbox/ogg> make
Making all in src
Bad modifier: )
Unclosed variable specification
"Makefile", line 242: Need an operator
Fatal errors encountered -- cannot continue
*** Error code 1
unsurprisingly, neithe...```
comatoast@dymaxion: ~/cvsSandbox/ogg> make
Making all in src
Bad modifier: )
Unclosed variable specification
"Makefile", line 242: Need an operator
Fatal errors encountered -- cannot continue
*** Error code 1
unsurprisingly, neither $GZIP_ENV nor $TAR are defined in my shell.
```Segher BoessenkoolSegher Boessenkoolhttps://gitlab.xiph.org/xiph/ogg/-/issues/80crc block generation doesn't set crc_ready2006-06-12T10:57:30Ztimjcrc block generation doesn't set crc_ready```
the end of _ogg_crc_init() should actually read:
crc_ready=1; instead of the current crc_ready=0;
``````
the end of _ogg_crc_init() should actually read:
crc_ready=1; instead of the current crc_ready=0;
```Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/ogg/-/issues/60src/Makefile.am doesn't work with outside-the-tree builds2006-06-12T11:23:31Zahltorpsrc/Makefile.am doesn't work with outside-the-tree builds```
The Makefile.am in src/Makefile.am does not properly set the include path
if building in a separate obj directory. The patch below fixes that problem.
Index: Makefile.am
=========================================================
===...```
The Makefile.am in src/Makefile.am does not properly set the include path
if building in a separate obj directory. The patch below fixes that problem.
Index: Makefile.am
=========================================================
==========
RCS file: /usr/local/cvsroot/ogg/src/Makefile.am,v
retrieving revision 1.3
diff -u -r1.3 Makefile.am
--- Makefile.am 2000/11/02 20:11:33 1.3
+++ Makefile.am 2001/10/08 01:29:52
@@ -2,7 +2,7 @@
AUTOMAKE_OPTIONS = foreign
-INCLUDES = -I../include
+INCLUDES = -I../include -I$(top_srcdir)/include
lib_LTLIBRARIES = libogg.la
```Jack MoffittJack Moffitthttps://gitlab.xiph.org/xiph/ogg/-/issues/56"ogg_packet_clear" not exported in ogg.def2006-06-12T11:08:23Zadonnai"ogg_packet_clear" not exported in ogg.def```
The function "ogg_packet_clear" isn't listed in ogg.def so linking fails when
calling it. One exmaple, vorbiscomment, couldn't compile because of this bug.
``````
The function "ogg_packet_clear" isn't listed in ogg.def so linking fails when
calling it. One exmaple, vorbiscomment, couldn't compile because of this bug.
```Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/ogg/-/issues/26'win32/*.bat' do not handle SRCROOT long path names with spaces correctly2006-06-12T10:56:22Ztom'win32/*.bat' do not handle SRCROOT long path names with spaces correctly```
as an example:
set SRCROOT=e:\Xiph CVS\
call build_vorbis_static.bat
produces the error:
cvs==. was unexpected at this time.
and does *not* set %SRCROOT% to any value
resolution:
replace the line:
if .%SRCROOT%==. set SRC...```
as an example:
set SRCROOT=e:\Xiph CVS\
call build_vorbis_static.bat
produces the error:
cvs==. was unexpected at this time.
and does *not* set %SRCROOT% to any value
resolution:
replace the line:
if .%SRCROOT%==. set SRCROOT=c:\src
with the line:
if ".%SRCROOT%"=="." set SRCROOT=c:\src
```starclassstarclasshttps://gitlab.xiph.org/xiph/ogg/-/issues/25'win32/*.bat', harcoded path to 'vcvars32.bat' might be a bad idea2009-04-19T20:39:35Ztom'win32/*.bat', harcoded path to 'vcvars32.bat' might be a bad idea```
'win32/*.bat' all contain:
call "c:\program files\microsoft visual studio\vc98\bin\vcvars32.bat"
maybe this should be replaced with:
call "%MSDevDir%\..\..\vc98\bin\vcvars32.bat"
or (if we assume it is pathed, since later on we s...```
'win32/*.bat' all contain:
call "c:\program files\microsoft visual studio\vc98\bin\vcvars32.bat"
maybe this should be replaced with:
call "%MSDevDir%\..\..\vc98\bin\vcvars32.bat"
or (if we assume it is pathed, since later on we see just 'msdev' without a
path):
call vcvars32.bat
```starclassstarclasshttps://gitlab.xiph.org/xiph/ogg/-/issues/24missing 'ogg_stream_packetpeek' export in 'win32/ogg.def'2006-06-12T10:30:29Ztommissing 'ogg_stream_packetpeek' export in 'win32/ogg.def'```
This breaks the build of the vorbis for the win32 platform
``````
This breaks the build of the vorbis for the win32 platform
```Jack MoffittJack Moffitthttps://gitlab.xiph.org/xiph/ogg/-/issues/23oggenc manpage and --help disagree on default bitrate2006-06-12T10:41:39Zjemorrisoggenc manpage and --help disagree on default bitrate```
The oggenc manpage says
-b n, --bitrate=n
Sets encoding to the bitrate closest to n (in
kb/s). Defaults to 160 kb/s for stereo.
And oggenc --help says (under MODES)
The default is the 128 k...```
The oggenc manpage says
-b n, --bitrate=n
Sets encoding to the bitrate closest to n (in
kb/s). Defaults to 160 kb/s for stereo.
And oggenc --help says (under MODES)
The default is the 128 kbps mode.
(I think line 54 of oggenc.c sets the actual default to 128.)
```Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/ogg/-/issues/21oggpack_read() return value not well defined2006-06-12T11:31:37ZSegher Boessenkoologgpack_read() return value not well defined```
If <long> is 32 bit on your platform, the return value -1 can mean
two different things: an out of data error occured, or we just read
32 bits, all 1.
And there's a signed/unsigned issue as well.
I'll convert everything that needs ...```
If <long> is 32 bit on your platform, the return value -1 can mean
two different things: an out of data error occured, or we just read
32 bits, all 1.
And there's a signed/unsigned issue as well.
I'll convert everything that needs to be unsigned, in ogg as well as
in vorbis.
This will get rid of a lot of compiler warnings on non-x86 and non-gcc
platforms...
```Segher BoessenkoolSegher Boessenkoolhttps://gitlab.xiph.org/xiph/ogg/-/issues/13Minor portability issues2006-06-12T11:22:27ZaegiskMinor portability issues```
Lines 74, 76, 78, and 81 are missing explicit typecasts to unsigned char (VC++ 6
is complaining).
Lines 177 and 209 are assigning -1 to an unsigned long. This is unspecified
according to the C specification. Change to 0xFFFFFFFF...```
Lines 74, 76, 78, and 81 are missing explicit typecasts to unsigned char (VC++ 6
is complaining).
Lines 177 and 209 are assigning -1 to an unsigned long. This is unspecified
according to the C specification. Change to 0xFFFFFFFF?
I'll attach a patch if desired.
```Segher BoessenkoolSegher Boessenkool