Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Ogg Ogg
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 9
    • Issues 9
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Xiph.Org
  • OggOgg
  • Issues
  • #2300

Closed
Open
Created Aug 04, 2020 by Clément Bœsch@ubituxContributor

Check for overflow on growing buffer

Hi,

I came across this code while debugging an issue in libshout (icecast-libshout#2318 (closed)), and it looked pretty unsafe to me: 0001-framing-check-for-overflow-on-growing-buffer.patch.

One could check that the oy->storage<0 and similar checks are enough, but I still believe it's safer not to assign the invalid value in the first place.

Assignee
Assign to
Time tracking