diff --git a/libcelt/entdec.c b/libcelt/entdec.c index 555543f404462ca9ed874c689f1da079c6abfc69..284ce397f32736ca0fb06b73b6decba5984b0ee4 100644 --- a/libcelt/entdec.c +++ b/libcelt/entdec.c @@ -5,6 +5,7 @@ #include <stddef.h> #include "entdec.h" #include "os_support.h" +#include "arch.h" void ec_byte_readinit(ec_byte_buffer *_b,unsigned char *_buf,long _bytes){ @@ -106,6 +107,8 @@ ec_uint32 ec_dec_uint(ec_dec *_this,ec_uint32 _ft){ unsigned s; int ftb; t=0; + /*In order to optimize EC_ILOG(), it is undefined for the value 0.*/ + celt_assert(_ft>1); _ft--; ftb=EC_ILOG(_ft); if(ftb>EC_UNIT_BITS){ diff --git a/libcelt/entenc.c b/libcelt/entenc.c index 3da351e9885933d24dc1fae5f1fa9a98de94e3a1..d0cbb0c59d5e378d7e5f945a2ec52ebfe39758cf 100644 --- a/libcelt/entenc.c +++ b/libcelt/entenc.c @@ -100,8 +100,10 @@ void ec_enc_uint(ec_enc *_this,ec_uint32 _fl,ec_uint32 _ft){ unsigned ft; unsigned fl; int ftb; + /*In order to optimize EC_ILOG(), it is undefined for the value 0.*/ + celt_assert(_ft>1); _ft--; - ftb=EC_ILOG(_ft)&-!!_ft; + ftb=EC_ILOG(_ft); if(ftb>EC_UNIT_BITS){ ftb-=EC_UNIT_BITS; ft=(_ft>>ftb)+1; diff --git a/tests/ectest.c b/tests/ectest.c index b3fc220cb5275c358bbefd62eee03ccd5491633a..49d39a16938e3db1b647ee246a3e8ada40503eb4 100644 --- a/tests/ectest.c +++ b/tests/ectest.c @@ -31,7 +31,7 @@ int main(int _argc,char **_argv){ /*Testing encoding of raw bit values.*/ ec_byte_writeinit(&buf); ec_enc_init(&enc,&buf); - for(ft=0;ft<1024;ft++){ + for(ft=2;ft<1024;ft++){ for(i=0;i<ft;i++){ entropy+=log(ft)*M_LOG2E; ec_enc_uint(&enc,i,ft); @@ -59,7 +59,7 @@ int main(int _argc,char **_argv){ fprintf(stderr,"Packed to %li bytes.\n",(long)(buf.ptr-buf.buf)); ec_byte_readinit(&buf,ec_byte_get_buffer(&buf),ec_byte_bytes(&buf)); ec_dec_init(&dec,&buf); - for(ft=0;ft<1024;ft++){ + for(ft=2;ft<1024;ft++){ for(i=0;i<ft;i++){ sym=ec_dec_uint(&dec,ft); if(sym!=i){