From 72f4f8a6c2c38a135d714bfa2a0831493299aebd Mon Sep 17 00:00:00 2001
From: "Timothy B. Terriberry" <tterribe@xiph.org>
Date: Sun, 3 Jul 2016 19:03:18 -0700
Subject: [PATCH] Fix free with uninitialized data in opus_tags_parse().
If the parsing fails before all comments are filled in, we will
attempt to free any binary metadata at the position one past the
last comment, which will be uninitialized.
Introduced in commit 0221ca95fc58.
---
src/info.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/info.c b/src/info.c
index d7ead3f..eb40d35 100644
--- a/src/info.c
+++ b/src/info.c
@@ -199,6 +199,7 @@ static int opus_tags_parse_impl(OpusTags *_tags,
if(_tags->user_comments[ci]==NULL)return OP_EFAULT;
_tags->comment_lengths[ci]=(int)count;
_tags->comments=ci+1;
+ _tags->user_comments[ci+1]=NULL;
}
_data+=count;
len-=count;
--
GitLab