• Timothy B. Terriberry's avatar
    Minor win32 warning fix. · dc27cf17
    Timothy B. Terriberry authored
    op_fopen() and op_freopen() declare these arguments as non-NULL,
     so when building with mingw, the compiler reasonably complains
     when we check to see if they're NULL.
    We could remove the OP_ARG_NONNULL tags, but the behavior of
     _wopen/_wfreopen appears to be to crash on NULL for either
    On Linux, the behavior appears to be to handle a NULL path (fopen
     returns NULL with errno set to EFAULT, and freopen returns the
     passed FILE * with errno set to EFAULT), but crash on a NULL mode.
    Keeping the OP_ARG_NONNULL tags promises that passing NULL results
     in undefined behavior, which is at least consistent with the
     behavior being different on different platforms.
    It's also consistent with the ABI promises of previous releases,
     which compilers linking against libopusfile might have taken
     advantage of.
stream.c 11.5 KB