• Timothy B. Terriberry's avatar
    Minor win32 warning fix. · dc27cf17
    Timothy B. Terriberry authored
    op_fopen() and op_freopen() declare these arguments as non-NULL,
     so when building with mingw, the compiler reasonably complains
     when we check to see if they're NULL.
    We could remove the OP_ARG_NONNULL tags, but the behavior of
     _wopen/_wfreopen appears to be to crash on NULL for either
     parameter.
    On Linux, the behavior appears to be to handle a NULL path (fopen
     returns NULL with errno set to EFAULT, and freopen returns the
     passed FILE * with errno set to EFAULT), but crash on a NULL mode.
    Keeping the OP_ARG_NONNULL tags promises that passing NULL results
     in undefined behavior, which is at least consistent with the
     behavior being different on different platforms.
    It's also consistent with the ABI promises of previous releases,
     which compilers linking against libopusfile might have taken
     advantage of.
    dc27cf17
Name
Last commit
Last update
ci Loading commit data...
doc Loading commit data...
examples Loading commit data...
include Loading commit data...
m4 Loading commit data...
mingw Loading commit data...
src Loading commit data...
unix Loading commit data...
win32 Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.travis.yml Loading commit data...
AUTHORS Loading commit data...
COPYING Loading commit data...
Makefile.am Loading commit data...
README.md Loading commit data...
appveyor.yml Loading commit data...
autogen.sh Loading commit data...
configure.ac Loading commit data...
opusfile-uninstalled.pc.in Loading commit data...
opusfile.pc.in Loading commit data...
opusurl-uninstalled.pc.in Loading commit data...
opusurl.pc.in Loading commit data...
releases.sha2 Loading commit data...
update_version Loading commit data...