Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • theora theora
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 33
    • Issues 33
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Xiph.Org
  • theoratheora
  • Issues
  • #1419
Closed
Open
Created Aug 31, 2008 by martins.mozeiko@martins.mozeiko

cpuid instruction detection function oc_detect_cpuid_helper is buggy

In lib/cpu.c there is cpuid instruction detection function oc_detect_cpuid_helper used for MSVC. Currently it just overwrites values of arguments (two pointers _eax and _ebx) with contents of eax and ebx registers:

    mov [_eax],eax
    mov [_ebx],ebx

It should be replaced with following code:

    mov ecx,_eax
    mov [ecx],eax
    mov ecx,_ebx
    mov [ecx],ebx

For me this bug always prevents to use cpuid instruction (didn't return correct values of eax and ebx) - therefore no MMX optimizations.

I'm using Micorosft Visual C++ 2008 Express Edition SP1 compiler.

Assignee
Assign to
Time tracking