[PATCH] Wrong target bitrate in the header
The spec says the field NOMR is a 24 bit unsigned int and is a hint for the target bitrate. If the target_bitrate is > 2 ^ 24 ^ - 1 the libtheora-svn encoder seems to works fine, allocating this bitrate, but sets in the NOMR field a wrong value, truncating target_bitrate. The encoder should rather sets a value of 2 ^ 24 ^ - 1 if the target bitrate is => 2 ^ 24 ^ - 1. Also the spec should be updated saying that if NOMR is 2 ^ 24 - ^ 1, the nominal bitrate should be considered 2 ^ 24 ^ - 1 or higher. Alternatively libtheora should fails with bitrate higher than 2 ^ 24 ^ - 1, in a manner similar to libvorbis with bitrate > 500 kb/s. Also shouldn't target_bitrate be an unsigned int, rather than an int?