- 02 Mar, 2020 2 commits
-
-
Ralph Giles authored
Follow up on the previous change, propagating the vorbis library version string to oggdec and ogg123 and regularizing the output.
-
eblanca76 authored
Signed-off-by:
Ralph Giles <giles@thaumas.net>
-
- 22 Jan, 2018 9 commits
-
-
Thomas Daede authored
-
Martin Steghöfer authored
Bug-Debian: https://bugs.debian.org/572491 Bug: https://trac.xiph.org/ticket/1681 Forwarded: https://trac.xiph.org/ticket/1681
-
Martin Steghöfer authored
oggdec: Write to stdout instead of "-.wav" when reading from stdin and not output file name is given. In bug #263762 it was reported that the behavior of oggdec was inconsistent with its documentation: According to the man page, "oggdec" should write to stdout, when reading its input from stdin and no output file name is given. The "oggdec" executable writes to "-.wav" instead. I adjusted the behavior of "oggdec" instead of adjusting the documentation because it seems more sensible to write to stdout than to write to a file called "-.wav". The code changes themselves are simple enough to be self-explanatory. Bug-Debian: https://bugs.debian.org/263762 Forwarded: https://trac.xiph.org/ticket/1678#comment:1
-
Petter Reinholdtsen authored
Author: Kamil Dudka <kdudka@redhat.com> Origin: http://lists.xiph.org/pipermail/vorbis-dev/2015-February/020423.html Bug: https://trac.xiph.org/ticket/2136 Bug: https://trac.xiph.org/ticket/2137 Bug-Debian: https://bugs.debian.org/776086 Forwarded: not-needed Reviewed-By:
Petter Reinholdtsen <pere@hungry.com> Last-Update: 2015-09-22
-
Petter Reinholdtsen authored
Author: Mark Harris <mark.hsj@gmail.com> Origin: https://trac.xiph.org/attachment/ticket/2212/0001-oggenc-Fix-large-alloca-on-bad-AIFF-input.patch Bug-Debian: https://bugs.debian.org/797461 Forwarded: https://trac.xiph.org/ticket/2212 Reviewed-By:
Petter Reinholdtsen <pere@hungry.com> Last-Update: 2015-09-22
-
Martin Steghöfer authored
The "oggdec" executable uses the "_" (underscore) macro for internationalization and has translations of the relevant strings available in the .po files, but nevertheless outputs everything in English. This was due to a lack of initialization of the internationalization modules in that executable. Bug-Debian: https://bugs.debian.org/772976 Forwarded: https://trac.xiph.org/ticket/2149
-
Martin Steghöfer authored
oggdec treats all negative return values coming from ov_read as OV_HOLE errors and therefore as recoverable. So even in the case of fatal errors it keeps on calling ov_read, which may either crash (libvorbis' data structures may be uninitialized) or simply not progress and therefore trap oggdec in an infinite loop. Fix this by distinguishing between recoverable and non-recoverable errors. In the case of fatal errors, exit gracefully with an error message. The error string is "borrowed" from ogg123 and therefore already translated into several languages. Bug-Debian: https://bugs.debian.org/772978 Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/vorbis-tools/+bug/629135 Forwarded: https://trac.xiph.org/ticket/2148
-
Martin Steghöfer authored
The speex decoder didn't initialize the channel matrix, which caused libao to print the cryptic error message '" in channel matrix ""' and occasionally (depending on the output device) to abort audio output. Bug-Debian: https://bugs.debian.org/772766
-
Martin Steghöfer authored
If the status line is longer than the number of columns of the terminal that stderr prints to, line-wrapping occurs and the mechanisms to overwrite the current line don't work any longer, thus filling the terminal with status lines. This can be avoided by checking the available size and truncating the line, if necessary. The truncation is indicated to the user via suspension points. Bug-Debian: https://bugs.debian.org/239073 Forwarded: https://trac.xiph.org/ticket/1677#comment:1
-
- 21 Jan, 2018 4 commits
-
-
Martin Steghöfer authored
Bug-Debian: https://bugs.debian.org/359948 Forwarded: https://trac.xiph.org/ticket/1679 The -f option to specify an output file name works only if a file device has previously been specified using the -d option. Some parts of the documentation don't make it very explicit that -f needs -d and that the -d option has to precede the -f option.
-
Martin Steghöfer authored
Bug-Debian: https://bugs.debian.org/307325 Forwarded: https://trac.xiph.org/ticket/1956#comment:3 When arriving at the end of the input file, the main thread waits for the output thread to finish up the current buffer. If a cancellation signal arrives at that stage, this signal of an empty buffer never arrives because the output thread bails out before actually emptying the buffer. Fix: 1.) Make sure the output thread wakes up the main thread when bailing out, so the main thread can go on, too. 2.) When the main thread wakes up while waiting for an empty buffer, make sure it understands the situation (that there won't be an empty buffer because the replay has been cancelled) and doesn't go back to sleep.
-
Martin Steghöfer authored
The following interleaving can cause problems: The interrupt for SIGINT could set sig_request.cancel right after the consumer thread checks it ("buf->cancel_flag || sig_request.cancel"), but before the consumer thread enters the mutex in order to wait for more data ("COND_WAIT"). If the producer thread reacts to the new situation immediately by exiting (which it can do because the consumer thread hasn't entered the mutex yet), the consumer thread initiates a COND_WAIT that might never be fulfilled because the producer thread is gone. The producer's intention to kill the consumer using buffer_thread_kill doesn't work because it was executed after the consumer's check for buf->cancel_flag and before the consumer's COND_WAIT. Fix the problem by putting the cancelation flag checks in the same mutex lock zone as the "COND_WAIT".
-
Thomas Daede authored
-
- 14 Aug, 2017 1 commit
-
-
Ralph Giles authored
When setting up a new chain link, vcedit_open_callbacks always tries to read a new chunk at the edit of the stream identification loop. This could fail if the whole segment fits within a single, already buffered chunk. Instead, check for a new available page before trying to buffer more data. As long as there's a data page available after the header pages, this will succeed, exiting early without trying to load data unnecessarily. Thanks to lsd for reporting the issue. Signed-off-by:
Thomas Daede <tdaede@mozilla.com>
-
- 24 Jul, 2017 1 commit
-
-
Mats Erik Andersson authored
Last-Update: 2011-07-20 Forwarded: no Bug-Debian: https://bugs.debian.org/328266 Bug-Debian: https://bugs.debian.org/634855 In checking the quality setting, the program `oggenc' performs a floating point comparison after down scaling the given value to a tenth. This causes the inexact internal representation to complain unnecessarily. * It is better to compare first, and normalize later, since quality 10 is top notch!
-
- 23 Jul, 2017 1 commit
-
-
Joao Paulo Pinharanda Magalhaes authored
Bug-Debian: https://bugs.debian.org/595104
-
- 09 May, 2017 1 commit
-
-
Philipp Schafft authored
This commit adds -d/--rm to vorbiscomment. The new option allows removal of tags from the processed files. It allows both removal of specific tags or all tags with a given namen. It also implies --append (which should maybe be renamed to --update). Manpage has been updated. Signed-off-by:
Ralph Giles <giles@thaumas.net>
-
- 26 Sep, 2016 4 commits
-
-
Mike Akiba authored
Signed-off-by:
Ralph Giles <giles@thaumas.net>
-
Ralph Giles authored
Mostly re-wrapping lines. These are changes from running autogen.sh on a Fedora 24 system.
-
Ralph Giles authored
-
Ralph Giles authored
Fixes an automake warning.
-
- 30 Mar, 2016 7 commits
-
-
Ralph Giles authored
-
Ralph Giles authored
This is a continuous integration service integrated with github. This just invokes 'make check'. 'make distcheck' fails with a permission issue: cannot move `/home/travis/build/rillian/vorbis-tools/vorbis-tools-1.4.0/_build/po/sv.new.po' to `sv.po': Permission denied
-
Ralph Giles authored
-
Ralph Giles authored
This is bad style, especially since "goto fail".
-
Bangun K authored
-
Chocobo1 authored
... to follow the one in CHANGES.
-
Chocobo1 authored
MSVC doesn't have unistd.h
-
- 26 Sep, 2015 1 commit
-
-
Ralph Giles authored
autoreconf looks for ACLOCAL_*FLAGS in Makefile.am and will pass that on when it invokes aclocal. Furthermore, setting a local like this doesn't make it available to subcommands, so the line has no effect.
-
- 08 Jul, 2015 3 commits
-
-
Ralph Giles authored
The automake dist target should take care of this for us now.
-
Ralph Giles authored
-
Ralph Giles authored
This is symlinked by automake and shouldn't be in-tree.
-
- 03 Jul, 2015 1 commit
-
-
Tristan Matthews authored
-
- 23 Jun, 2015 1 commit
-
-
Marvin Scholz authored
-
- 05 Jan, 2015 2 commits
-
-
Ralph Giles authored
This simplifies compiling the utility stand-alone for testing or in alternate build systems. svn path=/trunk/vorbis-tools/; revision=19424
-
Ralph Giles authored
Input files with sampling rate 0 are useless and can make oggenc crash because neither oggenc itself nor libvorbis are prepared for this case. A sanity check lets the program refuse those inputs gracefully without crash. Patch by Martin Steghöfer <martin@steghoefer.eu> Fixes #2078 Bug-Debian: https://bugs.debian.org/716613 svn path=/trunk/vorbis-tools/; revision=19423
-
- 12 Dec, 2014 1 commit
-
-
Timothy B. Terriberry authored
The ogg123 executable wasn't able to correctly play stereo speex files that don't contain any inband intensity stereo signals at all or whose first inband intensity stereo signal arrives after the stream has already started. This was due to the stereo information data structure not being initialized properly before the first inband intensity stereo signal arrived. So in the mentioned cases the speex decoder used uninitialized float values for the stereo decoding. This patch fixes the problem by using the proper initialization and deallocation functions from libspeex. Patch by Martin_Steghöfer <martin@steghoefer.eu> Bug-Debian: https://bugs.debian.org/312185 Fixes #1676 svn path=/trunk/vorbis-tools/; revision=19405
-
- 08 Oct, 2014 1 commit
-
-
unlord authored
ogg123: fix a format security issue in status.c, reported by downstream https://bugs.gentoo.org/520580 svn path=/trunk/vorbis-tools/; revision=19227
-