1. 04 Nov, 2010 1 commit
  2. 22 Oct, 2010 1 commit
  3. 23 Aug, 2010 1 commit
  4. 26 Mar, 2010 6 commits
    • Ralph Giles's avatar
      Remove an unused variable. · 01390cbc
      Ralph Giles authored
      The found flag was set on a match, but the value was never used.
      Fixes a warning reported by scan-build.
      
      svn path=/trunk/vorbis-tools/; revision=17074
      01390cbc
    • Ralph Giles's avatar
      The the return value of ogg_stream_pagein() in vcut. · 5099dd0a
      Ralph Giles authored
      Fixes an unchecked value warning reported by clang's scan-build tool.
      
      svn path=/trunk/vorbis-tools/; revision=17073
      5099dd0a
    • Ralph Giles's avatar
      Only clean the theora_comment struct if we're passed a non-NULL pointer. · 90ee3b37
      Ralph Giles authored
      The implementation of theora_comment_clear() in ogginfo performed a
      NULL check before deferencing members to free() them, but zeroed the
      indicated memory regardless.
      
      svn path=/trunk/vorbis-tools/; revision=17072
      90ee3b37
    • Ralph Giles's avatar
      Use strcmp instead of pointer comparison against string literals. · 56ad6cba
      Ralph Giles authored
      The oggenc option parsing set some filter strings to a default,
      then checked later settings from the command line against that
      default to decide whether to warn about multiple settings of
      the same value. This works fine when the default is 'NULL' but
      unforutnately in the case where the default is a string literal
      the results of the pointer comparison is undefined: the compiler
      will generally collapse the two instances of the same #define'd
      literal, but it is not required to do so. And if fact, the clang
      compiler warns about this.
      
      Instead, we use strcmp() to compare the values of the two different
      pointers, which will be identical if they both point to the literal.
      
      This works in the case of DEFAULT_NAMEFMT_REMOVE, but generated a
      new warning on DEFAULT_NAMEFMT_REPLACE which was NULL. Clang also
      warns (incorrectly) on  the code:
      
      #define bar NULL
      if (foo && bar && strcmp(foo, bar));
      
      so instead, we use the empty string for an empty default. This lets
      us preserve the identical code paths for the two options, and have
      things still work if the defaults are changed later.
      
      The logic is still a little odd as it won't warn about successive
      identical settings, but perhaps that's a feature.
      
      svn path=/trunk/vorbis-tools/; revision=17071
      56ad6cba
    • Ralph Giles's avatar
      Require libvorbis 1.3.0 or later to build. · c7e18ff9
      Ralph Giles authored
      The oggenc program uses OV_ECTL_COUPLING_SET which appreared in
      libvorbis 1.3.0. We could easily conditionalize this option,
      but prefer to require that the two version upgrade in sync, so
      instead the configure script checks for this version, or if
      pkg-config isn't available, it checks for the symbol itself.
      
      Note that the use of AC_CHECK_DECL() probably requires a more
      recent autoconf version than the 2.53 dependency we declare,
      but as usual the documentation provides no guidance as to when
      this macro was added.
      
      svn path=/trunk/vorbis-tools/; revision=17070
      c7e18ff9
    • Monty's avatar
      Update CHANGES file for release · dba279fd
      Monty authored
      
      svn path=/trunk/vorbis-tools/; revision=17062
      dba279fd
  5. 24 Mar, 2010 8 commits
  6. 23 Mar, 2010 2 commits
  7. 07 Mar, 2010 1 commit
  8. 04 Feb, 2010 1 commit
  9. 27 Jan, 2010 2 commits
  10. 26 Jan, 2010 5 commits
  11. 22 Jan, 2010 2 commits
  12. 22 Feb, 2009 1 commit
  13. 03 Jan, 2009 1 commit
  14. 31 Dec, 2008 2 commits
  15. 16 Nov, 2008 1 commit
  16. 10 Nov, 2008 1 commit
  17. 09 Nov, 2008 1 commit
  18. 06 Nov, 2008 1 commit
  19. 05 Nov, 2008 2 commits