1. 25 Sep, 2001 2 commits
  2. 22 Sep, 2001 1 commit
    • Stan Seibert's avatar
      - Created a "share" directory for code shared between all of the tools. Right · d4791d94
      Stan Seibert authored
      now it only contains the getopt code and the utf8 code.
      - Modified vorbiscomment to perform UTF-8 encoding of the comments as per the
      vorbis comment spec.
      - Added stubs in the utf8.c file for the future UTF-8 decoding routines that
      someone will hopefully write.  :)  We need them for ogg123 and ogginfo.
      
      svn path=/trunk/vorbis-tools/; revision=2067
      d4791d94
  3. 15 Aug, 2001 1 commit
  4. 12 Aug, 2001 1 commit
  5. 11 Aug, 2001 1 commit
  6. 17 Jul, 2001 1 commit
  7. 12 Jul, 2001 2 commits
  8. 04 Mar, 2001 1 commit
  9. 19 Feb, 2001 1 commit
    • jsquyres's avatar
      This is a horrible compromise just for the sake of getting beta4 out the · 37ea15a1
      jsquyres authored
      door, and it's a more complicated issue than one would think,
      so read everything before you draw any conclusions.  :-)
      
      The issues:
      
      It is not a good idea to double-instantiate functions/variables that
      the underlsying OS already provides.  getopt() and friends are a good
      example of this.  However, some systems don't have the getopt-kinds of
      functionality that is used in the tools (i.e., some do, some don't).
      Hence, we include the GNU
      definitions of getopt(), getopt_long(), and their associated global
      variables.  GNU libc systems will effectively nullify our included
      copies due to clever #if statements in the files.  POSIX systems that
      have getopt() (but not getopt_long()) will have a double instantiation
      of getopt() and the global variables.  This appears to not cause any
      problems (but it still isn't Right).
      
      The short-term solution:
      
      Copy getopt.c, getopt.h, and getopt1.c into each of the directories in
      the vorbis-tools tree, and let each tool compile and link their own
      local copies.  We do this because we know *it works*, and we need to get
      beta4 out the door.  This commit copies them into
      vorbis-tools/vorbiscomment (they were already in oggenc and ogg123).
      
      The long-term solution:
      
      After beta4 is out the door and we have time for proper testing, we'll
      remove the getopt* files from each tool directory and create a new
      directory named "support/", and put them in there.  But with a few
      caveats.
      
      - getopt() will be commented out.  We don't use it, anyway -- we only
      use getopt_long() (getopt() is not used to implement getopt_long()).
      - tests will be added in configure to check for getopt() on the local
      system.  If it's already there, we won't instantiate the global
      variables in getopt.c (since the OS already provides them).
      - there's still indecision on whether to name the included copy of
      getopt.h to be something different (e.g,. "ov_getopt.h") to prevent a
      name clash with the OS's copy (if it has one).  To be decided later...
      - the relevant .c files will be compiled into a static convenience
      library, libvtsupport.a.
      - each of the tool directories will "-l$(top_builddir)/support
      -lvtsupport" when linking their binaries
      - if other functions come up like this (that exist on some systems but
      not on others), we can add them into libvtsupport.a.
      
      svn path=/trunk/vorbis-tools/; revision=1319
      37ea15a1
  10. 17 Feb, 2001 1 commit
    • Michael Smith's avatar
      Minor fixes: · 25e593c5
      Michael Smith authored
        no newlines in error strings
        cast some stuff to avoid compiler warnings.
      
      svn path=/trunk/vorbis-tools/; revision=1282
      25e593c5
  11. 16 Feb, 2001 1 commit
  12. 10 Feb, 2001 2 commits
  13. 30 Jan, 2001 1 commit
    • Michael Smith's avatar
      · 02e87654
      Michael Smith authored
      Portability fixes for ogg123.
      
      Major fix (i.e. don't just chop off additional streams in a chained bitstream) for vcedit.c
      
      svn path=/trunk/vorbis-tools/; revision=1227
      02e87654
  14. 25 Jan, 2001 1 commit
    • Ralph Giles's avatar
      · 09997c65
      Ralph Giles authored
      use _LDADD instead of the over-riding _LDFLAGS for ogg, vorbis and ao libs
      
      improve order for static linking
      
      Thanks for Jeff Squyres for this one.
      
      svn path=/trunk/vorbis-tools/; revision=1220
      09997c65
  15. 23 Jan, 2001 1 commit
    • Michael Smith's avatar
      · d3820712
      Michael Smith authored
      More cleanup/error checking.
      Should probably still add more (checking of return values from ogg and vorbis functions is missing in a fair number of places - similarly to the encoder and decoder examples.
      
      svn path=/trunk/vorbis-tools/; revision=1202
      d3820712
  16. 22 Jan, 2001 1 commit
    • Michael Smith's avatar
      · fe0ed7fa
      Michael Smith authored
      Cleanup code to not leak in event of failure.
      Fix nasty bugs in vcomment.c
      
      svn path=/trunk/vorbis-tools/; revision=1194
      fe0ed7fa
  17. 20 Jan, 2001 1 commit
    • Ralph Giles's avatar
      · 31641f1d
      Ralph Giles authored
      code cleanup: don't call add_comment after fgets() returns EOF.
      
      svn path=/trunk/vorbis-tools/; revision=1187
      31641f1d
  18. 19 Jan, 2001 1 commit
    • Ralph Giles's avatar
      · 9ae08cff
      Ralph Giles authored
      Added something resembling a cmdline interface to the new vorbiscomment
      example code. You can say
      
         vorbiscomment [-l] <file>
      
      and have it dump the comments to stdout, and
      
         vorbiscomment -w <infile> <outfile>
      
      and have it read a replacement set of comments from stdin.
      
      Still needs some polishing, but it's at least marginally useful
      now. I also tried to lay it out so it remained easy to read as
      a code example.
      
      The Makefile has been changed to build/install vorbiscomment by
      default again, mostly on Monty's approval.
      
      svn path=/trunk/vorbis-tools/; revision=1173
      9ae08cff
  19. 18 Jan, 2001 1 commit
    • Michael Smith's avatar
      · 2dac541b
      Michael Smith authored
      Added vorbis_commentheader_out() to vorbis
      Added ogg_packet_clear to ogg
      
      Updated vcedit.c to use them. There's now enough source there to build a working and useful comment editor.
      
      svn path=/trunk/vorbis-tools/; revision=1172
      2dac541b
  20. 17 Jan, 2001 1 commit
    • Michael Smith's avatar
      · 586d3413
      Michael Smith authored
      Killed off vorbiscomment (at last).
      
      Added a new comment editor.
       vcedit.[ch] is the core of it. Provides a potentially usable API.
       vcomment.c builds a completely useless frontend on top of it, to show how to
           use the API.
      
      svn path=/trunk/vorbis-tools/; revision=1168
      586d3413
  21. 18 Nov, 2000 1 commit
  22. 04 Nov, 2000 1 commit
  23. 03 Oct, 2000 2 commits
  24. 27 Sep, 2000 1 commit
  25. 11 Sep, 2000 1 commit
  26. 07 Sep, 2000 1 commit