GitLab

... to follow the one in CHANGES.

MSVC doesn't have unistd.h

autoreconf looks for ACLOCAL_*FLAGS in Makefile.am and will
pass that on when it invokes aclocal. Furthermore, setting
a local like this doesn't make it available to subcommands,
so the line has no effect.

The automake dist target should take care of this for us now.

This is symlinked by automake and shouldn't be in-tree.

This simplifies compiling the utility stand-alone for testing
or in alternate build systems.

svn path=/trunk/vorbis-tools/; revision=19424

Input files with sampling rate 0 are useless and can make oggenc crash
because neither oggenc itself nor libvorbis are prepared for this case.
A sanity check lets the program refuse those inputs gracefully without crash.

Patch by Martin Steghöfer <martin@steghoefer.eu>

Fixes #2078
Bug-Debian: https://bugs.debian.org/716613

svn path=/trunk/vorbis-tools/; revision=19423

The ogg123 executable wasn't able to correctly play stereo speex
files that don't contain any inband intensity stereo signals at
all or whose first inband intensity stereo signal arrives after
the stream has already started. This was due to the stereo
information data structure not being initialized properly before
the first inband intensity stereo signal arrived. So in the
mentioned cases the speex decoder used uninitialized float
values for the stereo decoding. This patch fixes the problem by
using the proper initialization and deallocation functions from
libspeex.

Patch by Martin_Steghöfer <martin@steghoefer.eu>
Bug-Debian: https://bugs.debian.org/312185
Fixes #1676


svn path=/trunk/vorbis-tools/; revision=19405

ogg123: fix a format security issue in status.c, reported by downstream https://bugs.gentoo.org/520580


svn path=/trunk/vorbis-tools/; revision=19227

oggenc: fix crash on raw file close, reported by Hanno in issue #2009. pointer to a non-static struct was escaping its scope. Also fix a C99-ism.

svn path=/trunk/vorbis-tools/; revision=19117

svn path=/trunk/vorbis-tools/; revision=19090

Typo in the conditional to check the exit condition in ascii_strcasecmp.
It checks for (!*s1 || !*s1) instead of (!*s1 || !*s2). The typo did
not affect the result of the function as the loop is exited before
changing s1 or s2 anyway.

Fix ported from the copy in the flac library. Thanks to dcb314 for
reporting it here.

Closes https://trac.xiph.org/ticket/2007

svn path=/trunk/vorbis-tools/; revision=19089

svn path=/trunk/vorbis-tools/; revision=19046

Fixes an issue with the macro expecting pthread_t to be
convertable from an int, which isn't true on mingw where
pthread_t is a struct.

Also move the macro out of acinclude.m4 and into its own
file in the m4 subdirectory.

Thanks to Laura Michaels for reporting the issue.


svn path=/trunk/vorbis-tools/; revision=18791

Update configure.ac to, as ron puts it, "the 21st century" (mostly macro updates that appear to be symvol-pushing)


svn path=/trunk/vorbis-tools/; revision=18763

Patch to the vorbis-dev list. https://bugzilla.redhat.com/887540

svn path=/trunk/vorbis-tools/; revision=18747

ogginfo wasn't correcting for the granule position difference
 between 3.2.0 and 3.2.1 streams.
It was always assuming the 3.2.1 behavior, but since this code
 hasn't been changed since 2005 and the 3.2.1 bitstream bump was
 done in 2007, it was simply wrong before.

svn path=/trunk/vorbis-tools/; revision=18497

svn path=/trunk/vorbis-tools/; revision=18450

This isn't all of them, by any stretch, but they are
the ones which were easy to trigger when the output
file could not be opened. Helps with valgrind cleanness.

svn path=/trunk/vorbis-tools/; revision=18449

This option was accidentally disconnected in r16793.
This patch restores the option's functionality, and allows the code
 to distinguish between an actual unknown length (totalframes==-1)
 and an empty file (totalframes==0).
Fixes #1803.

svn path=/trunk/vorbis-tools/; revision=18383

resize_buffer() would only free the channel buffers when the
 channel count changed, not when the size of the buffer changed,
 even though it allocated new buffers in both cases.

svn path=/trunk/vorbis-tools/; revision=18382

patch from ph3r-der-loewe
See Trac #1786

svn path=/trunk/vorbis-tools/; revision=18121

svn path=/trunk/vorbis-tools/; revision=17722

svn path=/trunk/vorbis-tools/; revision=17625

Reported by msoltyspl, fixes Trac #1749


svn path=/trunk/vorbis-tools/; revision=17616

svn path=/trunk/vorbis-tools/; revision=17559

Requested by Philipp Schafft.

svn path=/trunk/vorbis-tools/; revision=17368

The found flag was set on a match, but the value was never used.
Fixes a warning reported by scan-build.

svn path=/trunk/vorbis-tools/; revision=17074

Fixes an unchecked value warning reported by clang's scan-build tool.

svn path=/trunk/vorbis-tools/; revision=17073

The implementation of theora_comment_clear() in ogginfo performed a
NULL check before deferencing members to free() them, but zeroed the
indicated memory regardless.

svn path=/trunk/vorbis-tools/; revision=17072

The oggenc option parsing set some filter strings to a default,
then checked later settings from the command line against that
default to decide whether to warn about multiple settings of
the same value. This works fine when the default is 'NULL' but
unforutnately in the case where the default is a string literal
the results of the pointer comparison is undefined: the compiler
will generally collapse the two instances of the same #define'd
literal, but it is not required to do so. And if fact, the clang
compiler warns about this.

Instead, we use strcmp() to compare the values of the two different
pointers, which will be identical if they both point to the literal.

This works in the case of DEFAULT_NAMEFMT_REMOVE, but generated a
new warning on DEFAULT_NAMEFMT_REPLACE which was NULL. Clang also
warns (incorrectly) on  the code:

#define bar NULL
if (foo && bar && strcmp(foo, bar));

so instead, we use the empty string for an empty default. This lets
us preserve the identical code paths for the two options, and have
things still work if the defaults are changed later.

The logic is still a little odd as it won't warn about successive
identical settings, but perhaps that's a feature.

svn path=/trunk/vorbis-tools/; revision=17071

The oggenc program uses OV_ECTL_COUPLING_SET which appreared in
libvorbis 1.3.0. We could easily conditionalize this option,
but prefer to require that the two version upgrade in sync, so
instead the configure script checks for this version, or if
pkg-config isn't available, it checks for the symbol itself.

Note that the use of AC_CHECK_DECL() probably requires a more
recent autoconf version than the 2.53 dependency we declare,
but as usual the documentation provides no guidance as to when
this macro was added.

svn path=/trunk/vorbis-tools/; revision=17070

svn path=/trunk/vorbis-tools/; revision=17062

svn path=/trunk/vorbis-tools/; revision=17017

loop.
Fixes #1598


svn path=/trunk/vorbis-tools/; revision=17016

svn path=/trunk/vorbis-tools/; revision=17015