Skip to content

Vorbis tools
Vorbis tools
Switch branch/tag
  1. 02 Mar, 2020 2 commits
  3. 22 Jan, 2018 9 commits
  5. 21 Jan, 2018 4 commits
    • Martin Steghöfer's avatar
      Make it clear in documentation that -f needs a previous -d. · f3bf5570
      Martin Steghöfer authored 
      Bug-Debian: https://bugs.debian.org/359948
Forwarded: https://trac.xiph.org/ticket/1679

The -f option to specify an output file name works only if a file device has previously been specified using the -d option. Some parts of the documentation don't make it very explicit that -f needs -d and that the -d option has to precede the -f option.
      f3bf5570
    • Martin Steghöfer's avatar
      Fix ogg123 freeze when interrupting at End-Of-Stream. · 98a83487
      Martin Steghöfer authored 
      Bug-Debian: https://bugs.debian.org/307325
Forwarded: https://trac.xiph.org/ticket/1956#comment:3

When arriving at the end of the input file, the main thread waits for
the output thread to finish up the current buffer. If a cancellation
signal arrives at that stage, this signal of an empty buffer never
arrives because the output thread bails out before actually emptying
the buffer.

Fix:
1.) Make sure the output thread wakes up the main thread when bailing
out, so the main thread can go on, too.
2.) When the main thread wakes up while waiting for an empty buffer,
make sure it understands the situation (that there won't be an empty
buffer because the replay has been cancelled) and doesn't go back to
sleep.
      98a83487
    • Martin Steghöfer's avatar
      Fix synchronization issue · 6d670e7c
      Martin Steghöfer authored 
      The following interleaving can cause problems:
The interrupt for SIGINT could set sig_request.cancel right after the consumer thread
checks it ("buf->cancel_flag || sig_request.cancel"), but before the consumer
thread enters the mutex in order to wait for more data ("COND_WAIT"). If the producer
thread reacts to the new situation immediately by exiting (which it can do because the
consumer thread hasn't entered the mutex yet), the consumer thread initiates a COND_WAIT
that might never be fulfilled because the producer thread is gone. The producer's intention
to kill the consumer using buffer_thread_kill doesn't work because it was executed after
the consumer's check for buf->cancel_flag and before the consumer's COND_WAIT.

Fix the problem by putting the cancelation flag checks in the same mutex lock zone as
the "COND_WAIT".
      6d670e7c
    • Thomas Daede's avatar
      Use https URL in vorbiscomment man page. · 34d88b00
      Thomas Daede authored
      34d88b00
  7. 14 Aug, 2017 1 commit
    • Ralph Giles's avatar
      vorbiscomment: Fix handling very short files. · 77384f71
      Ralph Giles authored 
      When setting up a new chain link, vcedit_open_callbacks
always tries to read a new chunk at the edit of the
stream identification loop. This could fail if the
whole segment fits within a single, already buffered
chunk.

Instead, check for a new available page before trying
to buffer more data. As long as there's a data page
available after the header pages, this will succeed,
exiting early without trying to load data unnecessarily.

Thanks to lsd for reporting the issue.
Signed-off-by: default avatarThomas Daede <tdaede@mozilla.com>
      77384f71
  9. 24 Jul, 2017 1 commit
  11. 23 Jul, 2017 1 commit
  13. 09 May, 2017 1 commit
  15. 26 Sep, 2016 4 commits
  17. 30 Mar, 2016 7 commits
  19. 26 Sep, 2015 1 commit
  21. 08 Jul, 2015 3 commits
  23. 03 Jul, 2015 1 commit
  25. 23 Jun, 2015 1 commit
  27. 05 Jan, 2015 2 commits
  29. 12 Dec, 2014 1 commit
    • Timothy B. Terriberry's avatar
      Fix ogg123 speex stereo: Initialize stereo info data structure · 422daa25
      Timothy B. Terriberry authored 
      The ogg123 executable wasn't able to correctly play stereo speex
files that don't contain any inband intensity stereo signals at
all or whose first inband intensity stereo signal arrives after
the stream has already started. This was due to the stereo
information data structure not being initialized properly before
the first inband intensity stereo signal arrived. So in the
mentioned cases the speex decoder used uninitialized float
values for the stereo decoding. This patch fixes the problem by
using the proper initialization and deallocation functions from
libspeex.

Patch by Martin_Steghöfer <martin@steghoefer.eu>
Bug-Debian: https://bugs.debian.org/312185
Fixes #1676


svn path=/trunk/vorbis-tools/; revision=19405
      422daa25
  31. 08 Oct, 2014 1 commit