Skip to content

GitLab

Vorbis
Vorbis
Closed
Opened by mle@mle

[Patch] Const correct tags functions

I tend to compile my code with all GCC warnings turned on. However, when I do this :

vorbis_comment_add_tag(&vdata->vc,"ENCODER","libsndfile");

I get the following warning messages:

warning: passing argument 2 of 'vorbis_comment_add_tag' discards 
    qualifiers from pointer target type
warning: passing argument 3 of 'vorbis_comment_add_tag' discards 
    qualifiers from pointer target type

The problem is that string literals like "ENCODER" are be const char * while vorbis_comment_add_tag is prototyped as having char * pointers, even though the strings pointed to are not modified.

The following patch (against SVN head) makes the libvorbis const correct.