GitLab

Michael Scheerer has following comments on the Vorbis specification after successfully implementing a Vorbis decoder accordign to spec:

1. A not actual MDCT link.

Actual is e.g. http://www.digital-audio.net/res/docs/ps/eusipco_corrected.ps

2. A decoder side scaling factor described in the paper was proposed for the vorbis decoder, including following code lines: float scale;

scale=4.f/n;

but then never used, because the scale is now done encoder sided.

This should be mentioned in the spec.

3. The residue reconstruction after the sentence:

"Packet decode proceeds as follows, matching the description offered earlier in the document."

has at least one curly bracket error in the pseudo code. A developer can't determine, which code block belongs to which curly bracket.