Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Vorbis Vorbis
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 24
    • Issues 24
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Xiph.Org
  • VorbisVorbis
  • Issues
  • #2142

Closed
Open
Created Jan 05, 2015 by Martin Steghöfer@martin.steghoefer

_initial_pcmoffset uses error codes from vorbis_packet_blocksize in arithmetics

While working on #2140 (closed), I realized that the function _initial_pcmoffset doesn't handle negative values (error codes) returned by vorbis_packet_blocksize properly. It simply uses the returned value in an arithmetic expression, regardless the sign - which leads to an incorrect result. In change, the functions ov_raw_seek and ov_pcm_seek seem to skip the current packet, if vorbis_packet_blocksize returns a negative value.

In the comments of #2140 (closed), tterribe suggested a fix that I'm attaching as patch, but couldn't test yet.

Assignee
Assign to
Time tracking