1. 08 Feb, 2013 3 commits
    • John Koleszar's avatar
      Avoid allocating memory when resizing frames · c03d45de
      John Koleszar authored
      As long as the new frame is smaller than the size that was originally
      allocated, we don't need to free and reallocate the memory allocated.
      Instead, do the allocation on the size of the first frame. We could
      make this passed in from the application instead, if we wanted to
      support external upscaling.
      
      Change-Id: I204d17a130728bbd91155bb4bd863a99bb99b038
      c03d45de
    • John Koleszar's avatar
      Adds a test for the VP8E_SET_SCALEMODE control · 88f99f4e
      John Koleszar authored
      Tests that the external interface to set the internal codec scaling
      works as expected. Also updates the test to pull the height from
      the decoded frame size rather than parsing the keyframe header,
      in anticipation of allowing resolution changes on non-keyframes.
      
      Change-Id: I3ed92117d8e5288fbbd1e7b618f2f233d0fe2c17
      88f99f4e
    • John Koleszar's avatar
      Restore SSSE3 subpixel filters in new convolve framework · 29d47ac8
      John Koleszar authored
      This commit adds the 8 tap SSSE3 subpixel filters back into the code
      underneath the convolve API. The C code is still called for 4x4
      blocks, as well as compound prediction modes. This restores the
      encode performance to be within about 8% of the baseline.
      
      Change-Id: Ife0d81477075ae33c05b53c65003951efdc8b09c
      29d47ac8
  2. 05 Feb, 2013 2 commits
    • John Koleszar's avatar
      Convert subpixel filters to use convolve framework · 7a07eea1
      John Koleszar authored
      Update the code to call the new convolution functions to do subpixel
      prediction rather than the existing functions. Remove the old C and
      assembly code, since it is unused. This causes a 50% performance
      reduction on the decoder, but that will be resolved when the asm for
      the new functions is available.
      
      There is no consensus for whether 6-tap or 2-tap predictors will be
      supported in the final codec, so these filters are implemented in
      terms of the 8-tap code, so that quality testing of these modes
      can continue. Implementing the lower complexity algorithms is a
      simple exercise, should it be necessary.
      
      This code produces slightly better results in the EIGHTTAP_SMOOTH
      case, since the filter is now applied in only one direction when
      the subpel motion is only in one direction. Like the previous code,
      the filtering is skipped entirely on full-pel MVs. This combination
      seems to give the best quality gains, but this may be indicative of a
      bug in the encoder's filter selection, since the encoder could
      achieve the result of skipping the filtering on full-pel by selecting
      one of the other filters. This should be revisited.
      
      Quality gains on derf positive on almost all clips. The only clip
      that seemed to be hurt at all datarates was football
      (-0.115% PSNR average, -0.587% min). Overall averages 0.375% PSNR,
      0.347% SSIM.
      
      Change-Id: I7d469716091b1d89b4b08adde5863999319d69ff
      7a07eea1
    • John Koleszar's avatar
      Add 8-tap generic convolver · 5ca6a366
      John Koleszar authored
      This commit introduces a new convolution function which will be used to
      replace the existing subpixel interpolation functions. It is much the
      same as the existing functions, but allows for changing the filter
      kernel on a per-pixel basis, and doesn't bake in knowledge of the
      filter to be applied or the size of the resulting block into the
      function name.
      
      Replacing the existing subpel filters will come in a later commit.
      
      Change-Id: Ic9a5615f2f456cb77f96741856fc650d6d78bb91
      5ca6a366
  3. 30 Jan, 2013 4 commits
  4. 29 Jan, 2013 3 commits
    • Ronald S. Bultje's avatar
      Fix block pointer corruption in intra8x8 prediction with 4x4 transform. · ffc2e4f4
      Ronald S. Bultje authored
      The RD loop would change the pointer after the first mode (DC) was tested,
      leading to corrupt block objects being provided for the others. This
      would essentially render the i8x8 predictor useless.
      
      Change-Id: I16c5906ca64fb34878ac32ce59af8974e4582bb8
      ffc2e4f4
    • Paul Wilkins's avatar
      Remove eob_max_offset markers. · 93762ca9
      Paul Wilkins authored
      Remove eob_max_offset markers and replace
      with the generic skip_block flag to indicate
      to the quantizer that all coeffs to be set to 0
      and eob position set to 0;
      
      Change-Id: Id477e8f8d4ec1a5562758904071013c24b76bfd7
      93762ca9
    • Deb Mukherjee's avatar
      Further improvement on compound inter-intra expt · 3b04d467
      Deb Mukherjee authored
      Adds a special combination mode specific to intra prediciton
      mode D45.
      
      Current results with the compound inter/intra experiment:
      derf: 0.2%
      yt: 0.55%
      std-hd: 0.75%
      hd: 0.74%
      
      Change-Id: I8976bdf3b9b0b66ab8c5c628bbc62c14fc72ca86
      3b04d467
  5. 28 Jan, 2013 2 commits
    • Paul Wilkins's avatar
      Segment Skip Flag · 0ff9b033
      Paul Wilkins authored
      First step in simplifying the segment mode and
      segment EOB flags into a simpler segment skip
      flag that implies 0,0 mv and EOB at position 0.
      
      Change-Id: Ib750cac31a7a02dc21082580498efd9f7d8d72a5
      0ff9b033
    • Paul Wilkins's avatar
      Simplify Zero bin and zero bin run code. · 8e2c03fb
      Paul Wilkins authored
      Simplification to eliminate a number of very large data
      data structures. All zero run, zbin boosts for different
      transform sizes are now limited to a maximum run length
      of 15 before they max out the boost.
      
      Some further work still needs be done to refactor, rationalize
      and optimize the multiple quantizer functions.
      
      The simplification coupled with tweaks to the 16 element array
      now used for all transform sizes, has minimal effect on quality.
      
      Change-Id: I6f3948b8ca0418b60d4db9030ff19026a34ed423
      8e2c03fb
  6. 26 Jan, 2013 2 commits
  7. 25 Jan, 2013 2 commits
  8. 24 Jan, 2013 2 commits
    • Paul Wilkins's avatar
      Mvref speedup · fcb4a25c
      Paul Wilkins authored
      Quality / decode speed trade off changes.
      Simpler insert method without sort. Quality impact small.
      
      Change-Id: Id0c0941bc508d985405abd06a13ffe7489170b62
      fcb4a25c
    • Deb Mukherjee's avatar
      Adds an error-resilient mode with test · 01cafaab
      Deb Mukherjee authored
      Adds an error-resilient mode where frames can be continued
      to be decoded even when there are errors (due to network losses)
      on a prior frame. Specifically, backward updates are turned off
      and probabilities of various symbols are reset to defaults at
      the beginning of each frame. Further, the last frame's mvs are
      not used for the mv reference list, and the sorting of the
      initial list based on search on previous frames is turned off
      as well.
      
      Also adds a test where an arbitrary set of frames are skipped
      from decoding to simulate errors. The test verifies (1) that if
      the error frames are droppable - i.e. frame buffer updates have
      been turned off - there are no mismatch errors for the remaining
      frames after the error frames; and (2) if the error-frames are non
      droppable, there are not only no decoding errors but the mismatch
      PSNR between the decoder's version of the post-error frames and the
      encoder's version is at least 20 dB.
      
      Change-Id: Ie6e2bcd436b1e8643270356d3a930e8989ff52a5
      01cafaab
  9. 23 Jan, 2013 1 commit
    • Scott LaVarnway's avatar
      Intrinsic version of loopfilter now matches C code · 6a997400
      Scott LaVarnway authored
      Updated the instrinsic code to match Yaowu's latest loopfilter change.
      (I584393906c4f5f948a581d6590959522572743bb)
      
      The decoder performance improved by ~30% for the test clip used.
      
      Change-Id: I026cfc75d5bcb7d8d58be6f0440ac9e126ef39d2
      6a997400
  10. 18 Jan, 2013 2 commits
    • John Koleszar's avatar
      Use alt-ref frame context for keyframes · 2f24ad9e
      John Koleszar authored
      This matches the behavior prior to generalizing the frame context
      selection, and intuitively makes sense in that the first forward ref
      is immediately after the keyframe, so it's quality is improved a bit
      by using the keyframe's entropy context rather than the default.
      
      Change-Id: Ia82cef79382b9d8cfafdc44ba0533d4dc3e44053
      2f24ad9e
    • Yaowu Xu's avatar
      a minor change to a portion of loop filtering · b95ed688
      Yaowu Xu authored
      The loop filtering used for MB edge or internal edge of a MB using 8x8
      tranform was reading 5 pixel each side and writting 3 pixel each side.
      With suggestion from Aki and Scott on hardware&software performance,
      this commit changed to read 4 pixel each side and write 3 pixel each
      side.
      
      Change-Id: I584393906c4f5f948a581d6590959522572743bb
      b95ed688
  11. 16 Jan, 2013 5 commits
    • John Koleszar's avatar
      Preserve the previous golden frame on golden updates · 26bd81b9
      John Koleszar authored
      This commit restores the quality lost when the buffer-to-buffer copy
      logic was removed. Note that this is specific to the current use of
      golden frames and will need rework when RTC functionality is added.
      
      Change-Id: I7324a75acd96eafd9e0f9b8633d782e390d5dc21
      26bd81b9
    • John Koleszar's avatar
      Generalize and increase frame coding contexts · 4b65837b
      John Koleszar authored
      Previously there were two frame coding contexts tracked, one for normal
      frames and one for alt-ref frames. Generalize this by signalling the
      context to use in the bitstream, rather than tieing it to the alt ref
      refresh bit. Also increase the number of contexts available to 4, which
      may be useful for temporal scalability.
      
      Change-Id: I7b66daaddd55c535c20cd16713541fab182b1662
      4b65837b
    • John Koleszar's avatar
      Start to anonymize reference frames · da832a80
      John Koleszar authored
      Remove lst_fb_idx, gld_fb_idx, alt_fb_idx, refresh_last_frame,
      refresh_golden_frame, refresh_alt_ref_frame from common. Gold/Alt are
      encode side conventions. From the decoder's perspective, we want to be
      dealing with numbered references.
      
      Updates to active_ref 2 signal mode context switches, vestigial from
      refresh_alt_ref_frame. This needs some clean up to make sense with
      increased numbers of reference frames, as well as reimplementing the
      swapping of alt/golden which was previously done using the
      buffer-to-buffer copy mechanism removed in an earlier commit.
      
      Change-Id: I7334445158b7666f9295d2a2dd22aa03f4485f58
      da832a80
    • John Koleszar's avatar
      Update encoder to use fb_idx_ref_cnt · 394b0a6a
      John Koleszar authored
      Do reference counting the same way on the encoder as the decoder does,
      rather than maintaining the 'flags' member of YV12_BUFFER_CONFIG.
      
      Change-Id: I91dc210ffca081acaf9d5c09a06e7461b3c3139c
      394b0a6a
    • John Koleszar's avatar
      Remove buffer-to-buffer copy logic · b8e02798
      John Koleszar authored
      This is the first in a series of commits to add additional reference
      frames to the codec. Each frame will be able to update any of the
      available references, but copying between references is not
      supported.
      
      Change-Id: I5945b5ce6cc3582c495102b4e7eed4f08c44d5a1
      b8e02798
  12. 15 Jan, 2013 2 commits
  13. 14 Jan, 2013 10 commits
    • John Koleszar's avatar
      Use INT64_MAX instead of LLONG_MAX · 24bc1a71
      John Koleszar authored
      These variables have the type int64_t, not long long. long long could
      be a larger type than 64 bits. Emulate INT64_MAX for older versions of
      MSVC, and remove the unreferenced vpx_ports/vpxtypes.h
      
      Change-Id: Ideaca71838fcd3849d816d5ab17aa347c97d03b0
      24bc1a71
    • Ronald S. Bultje's avatar
      Remove compound intra-intra experiment. · c9071601
      Ronald S. Bultje authored
      This experiment gives little gains and adds relatively much code
      complexity (and it hinders other experiments), so let's get rid of
      it.
      
      Change-Id: Id25e79a137a1b8a01138aa27a1fa0ba4a2df274a
      c9071601
    • Yaowu Xu's avatar
      Merge experiment "subpelrefmv" · 741fbe96
      Yaowu Xu authored
      Change-Id: Iac7f3d108863552b850c92c727e00c95571c9e96
      741fbe96
    • Yaowu Xu's avatar
      Merge experiment "widerlpf" · f7dab600
      Yaowu Xu authored
      Change-Id: I0c94475075e66e13cfe4c20fab7db6474441ae86
      f7dab600
    • Yaowu Xu's avatar
      changed UV plane loop filtering for TX_8X8 · ad9a16ed
      Yaowu Xu authored
      In commit 9a1d73d0, loop filtering was added for UV 4x4 boundaries
      when TX_8X8 is used by a MB. This commit further refined the decision
      to be based on the actual transform used for the UV planes. When
      UV planes use 4x4 transform, i.e. when prediction mode used is either
      I8X8_PRED or SPLITMV, UV planes are filtered on 4x4 boundaries, and no
      filtering is applied on 4x4 block boundaries when UV planes use 8X8
      transform.
      
      Change-Id: Ibb404face0a1d129b4b4abaf67c55d82e8df8bec
      ad9a16ed
    • Yaowu Xu's avatar
      change to evaluate reference mvs using above only · fdf86541
      Yaowu Xu authored
      Change-Id: Ibcc342efac0a9be7a21d9b2c09984d9e16bbb225
      fdf86541
    • Yaowu Xu's avatar
      Fix compiler warnings · 113005b1
      Yaowu Xu authored
      The warnings caused verify failure with gerrit for several  commits
      
      Change-Id: I030df8638bd69b8783a3ac58e720ff9f0bfd546c
      113005b1
    • Adrian Grange's avatar
      Merge prediction filter · 7bcaac3e
      Adrian Grange authored
      Removed the experimental flag from around the prediction filter.
      
      Change-Id: Ic1dd2db8fe8ac17ed5129f83094d4c5cdd5527d2
      7bcaac3e
    • Ronald S. Bultje's avatar
      Reset x->skip for each iteration in the RD loop. · 290b83ab
      Ronald S. Bultje authored
      This prevents ill-defined behaviour, such as setting x->skip for a mode
      that is excluded because of frame-level flags (e.g. filter selection,
      compound prediction selection), then not breaking out of the RD loop
      because the mode is not allowed, but keeping the flag on. Whatever mode
      is iterated through next in the RD loop will then carry this flag, and
      all sort of bad stuff happens, such as x->skip being set on intra pred
      modes.
      
      Change-Id: I5bec46b36e38292174acb1c564b3caf00a9b4b9a
      290b83ab
    • John Koleszar's avatar
      Fix unused variable warnings · 76ac5b39
      John Koleszar authored
      Previous commit does not build cleanly on Jenkins with the DWT/DCT
      hybrid experiment enabled (--enable-dwtdcthybrid).
      
      Change-Id: Ia67e8f59d17ef2d5200ec6b90dfe6711ed6835a5
      76ac5b39