1. 25 Nov, 2010 1 commit
    • Pascal Massimino's avatar
      allow dimensions as low as 1 pixel · fd9f9dc0
      Pascal Massimino authored
      remove warning comment in vpxenc.c: in case of 1x1 picture,
      detect_bytes will be equal to '3' and we'll fall back to
      RAW_TYPE.
      fix read_frame() by tracking the pre-read buffer length
      in the struct detect
      
      Change-Id: If1ed86ee5260dcdbc8f9d10da6cbb84a4cc2f151
      fd9f9dc0
  2. 22 Nov, 2010 1 commit
    • Paul Wilkins's avatar
      Recalibration of bits per MB tables · ad6150f7
      Paul Wilkins authored
      The baseline bits per MB prediction tables have been
      re calibrated based on the assumption that bits per mb
      is inversely proportional to the quantizer level.
      
      Change-Id: Ibd355c7acac4b8053dda1baf1032fe35f11da7f7
      ad6150f7
  3. 19 Nov, 2010 1 commit
  4. 18 Nov, 2010 1 commit
    • Pascal Massimino's avatar
      remove warning · ed5ab7fa
      Pascal Massimino authored
      was having: "vp8/encoder/onyx_if.c:5365: warning: comparison of unsigned expression >= 0 is always true"
      ed5ab7fa
  5. 17 Nov, 2010 4 commits
    • Scott LaVarnway's avatar
      Removed unnecessary checks. · f7670acc
      Scott LaVarnway authored
      macro_block_yrd and vp8_rdcost_mby are not called for SPLITMV.
      
      Change-Id: I2224d3c8725df526d48426447482768d543752f1
      f7670acc
    • Paul Wilkins's avatar
      Replaced recode loop test with a function call · f874391e
      Paul Wilkins authored
      Replaced existing code to decide if a frame recode is required
      with a function call. This is to simplify addition of extra clauses
      that may be needed for the planned constrained quality mode.
      
      Also fixed a bug where by alt ref not considered in the test.
      
      Change-Id: I3d40bb21abe3e19f8456761e6849deb171738b60
      f874391e
    • John Koleszar's avatar
      vp8mt_alloc_temp_buffers: make prototype return void · 8d94796c
      John Koleszar authored
      This function was never called in a context expecting a return value,
      the return value was always a constant, and the !CONFIG_MULTITHREAD
      path didn't have a return statement, which caused a compiler warning.
      This patch changes the function to return void instead.
      
      Fixes issue #231
      
      Change-Id: I9ef7f56e54418b7265026c54fc4ed5660c1418d1
      8d94796c
    • John Koleszar's avatar
      Disable compile warning for ERROR macro · 79e2b1f3
      John Koleszar authored
      The ERROR macro collides wiith the MS SDK on Windows. Since we're not
      making any win32 calls in this function, just #undef it first to take
      ownership.
      
      Change-Id: Ic18c60dfa3a33c52e6c49d3f4f8d3e7e3ac3341d
      79e2b1f3
  6. 16 Nov, 2010 2 commits
  7. 15 Nov, 2010 2 commits
    • Fritz Koenig's avatar
      Remove stack shadowing for x86-x64 for SAD functions. · e1802553
      Fritz Koenig authored
      x86-64 passes arguments in registers.  There is no need to push
      them to the stack before using them.
      
      This fixes 15acc84f where ebx
      was not getting preserved on x86.
      
      Change-Id: I1214b5f818a0201f75ab6ad7d5c6f448e09b16c2
      e1802553
    • Paul Wilkins's avatar
      Bad cost tables used in ARNR filtering. · 373f5c31
      Paul Wilkins authored
      The use of incorrect mv costing tables in the ARNR sub-pel
      filtering code led to corruption of the altref buffer in some cases,
      particularly at low data rates.
      
      The average gain from this fix is about 0.3% but there are a few
      extreme cases where nasty and visible artifacts manifested and
      for these few data points the improvement is > 10%.
      
      PGW and AWG
      
      Change-Id: I95cc02b196a433e71d0d2bd2b933fe68ed31e796
      373f5c31
  8. 11 Nov, 2010 3 commits
    • Yaowu Xu's avatar
      make rdmult adaptive for intra in quantizer RDO · ef2f27f1
      Yaowu Xu authored
      This intends to correct the tendency that VP8 aggressively favors rate
      on intra coded frames. Experiments tested different numbers in [0, 1]
      and found 9/16 overall provided about 2-4% gains for all-intra coded
      clips based on vpx-ssim metric. The impact on regular encoded clips
      is much smaller but positive overall. Overall impact on psnr is also
      positive even though very small.
      
      Change-Id: If808553aaaa87fdd44691f9787820ac9856d9f8a
      ef2f27f1
    • John Koleszar's avatar
      quantizer: fix assertion in fast quantizer path · 0a49747b
      John Koleszar authored
      The fast quantizer assembly code has not been updated to match the new
      exact quantizer, which was made the default in commit 6adbe090.
      Specifically, they are not aware of the potential for the coefficient
      to be scaled, which results in the quantized result exceeding the range
      of the DCT. This patch restores the previous behavior of using the
      non-shifted coefficients when in the fast quantizer code path, but
      unfortunately requires rebuilding the tables when switching between the
      two.
      
      Change-Id: I0a33f5b3850335011a06906f49fafed54dda9546
      0a49747b
    • Fritz Koenig's avatar
      Revert "Remove stack shadowing for x86-64" · 58083cb3
      Fritz Koenig authored
      This reverts commit 15acc84f.
      
      Change-Id: Ia640be8cbc134432914849c1750f62575ea084e6
      58083cb3
  9. 10 Nov, 2010 4 commits
    • Fritz Koenig's avatar
      FDCT optimizations. · 5f0e0617
      Fritz Koenig authored
      Fixed up the fdct for mmx and 8x4 sse2 to match them
      most recent changes.
      
      Change-Id: Ibee2d6c536fe14dcf75cd6eb1c73f4848a56d719
      5f0e0617
    • Fritz Koenig's avatar
      postproc : Re-work posproc calling to allow more flags. · 647df00f
      Fritz Koenig authored
      Debugging in postproc needs more flags to allow for specific
      block types to be turned on or off in the visualizations.
      
      Must be enabled with --enable-postproc-visualizer during
      configuration time.
      
      Change-Id: Ia74f357ddc3ad4fb8082afd3a64f62384e4fcb2d
      647df00f
    • Paul Wilkins's avatar
      Relax rate control for last few frames · 513f8e68
      Paul Wilkins authored
      VBR rate control can become very noisy for the last few frames.
      If there are a few bits to spare or a small overshoot then the
      target rate and hence quantizer may start to fluctuate wildly.
      
      This patch prevents further adjustment of the active Q limits for
      the last few frames.
      
      Patch also removes some redundant variables and makes one small bug fix.
      
      Change-Id: Ic167831bec79acc9f0d7e4698bcc4bb188840c45
      513f8e68
    • Paul Wilkins's avatar
      Tuning for the more exact quantizer. · 6adbe090
      Paul Wilkins authored
      Small changes to the default zero bin and rounding tables.
      Though the tables are currently the same for the Y1 and Y2 cases
      I have left them as separate tables in case we want to tune this later.
      
      There is now some adjustment of the zbin based on the prediction mode.
      Previously this was restricted to an adjustment for gf/arf 0,0 MV.
      
      The exact quantizer now marginal outperforms and is the default.
      
      The overall average gain is about 0.5%
      
      Change-Id: I5e4353f3d5326dde4e86823684b236a1e9ea7f47
      6adbe090
  10. 05 Nov, 2010 2 commits
    • John Koleszar's avatar
      fix integer promotion bug in partition size check · 9fb80f71
      John Koleszar authored
      The check '(user_data_end - partition < partition_size)' must be
      evaluated as a signed comparison, but because partition_size was
      unsigned, the LHS was promoted to unsigned, causing an incorrect
      result on 32-bit. Instead, check the upper and lower bounds of
      the segment separately.
      
      Change-Id: I6266aba7fd7de084268712a3d2a81424ead7aa06
      9fb80f71
    • John Koleszar's avatar
      improve average framerate calculation · f7e187d3
      John Koleszar authored
      Change Ice204e86 identified a problem with bitrate undershoot due to
      low precision in the timestamps passed to the library. This patch
      takes a different approach by calculating the duration of this frame
      and passing it to the library, rather than using a fixed duration
      and letting the library average it out with higher precision
      timestamps. This part of the fix only applies to vpxenc.
      
      This patch also attempts to fix the problem for generic applications
      that may have made the same mistake vpxenc did. Instead of
      calculating this frame's duration by the difference of this frame's
      and the last frame's start time, we use the end times instead. This
      allows the framerate calculation to scavenge "unclaimed" time from
      the last frame. For instance:
      
        start |  end  | calculated duration
        ======+=======+====================
          0ms    33ms   33ms
         33ms    66ms   33ms
         66ms    99ms   33ms
        100ms   133ms   34ms
      
      Change-Id: I92be4b3518e0bd530e97f90e69e75330a4c413fc
      f7e187d3
  11. 04 Nov, 2010 1 commit
    • Fritz Koenig's avatar
      postproc : Update visualizations. · 0e7b6061
      Fritz Koenig authored
      Change color reference frame to blend the macro block edge.
      This helps with layering of visualizations.
      
      Add block coloring for intra prediction modes.
      
      Change-Id: Icefe0e189e26719cd6937cebd6727efac0b4d278
      0e7b6061
  12. 02 Nov, 2010 1 commit
  13. 01 Nov, 2010 2 commits
  14. 29 Oct, 2010 1 commit
    • Scott LaVarnway's avatar
      Finding first label · dcee88ea
      Scott LaVarnway authored
      Using tables for the label count and label offset.
      
      Change-Id: Iac3d5b292c37341a881be0af282f5cac3b3e01eb
      dcee88ea
  15. 28 Oct, 2010 5 commits
    • Yunqing Wang's avatar
      Save XMM registers in asm functions · 6614563b
      Yunqing Wang authored
      XMM6/7 are used in these functions, and need to be saved.
      
      Change-Id: I3dfaddaf2a69cd4bf8e8735c7064b17bac5a14e5
      6614563b
    • Yunqing Wang's avatar
      Fix full-search SAD function crash in Visual Studio · 7e3a1e73
      Yunqing Wang authored
      Unlike GCC, Visual Studio compiler doesn't allocate SAD output
      array 16-byte aligned, which causes crash in visual studio.
      
      Change-Id: Ia755cf5a807f12929bda8db94032bb3c9d0c2362
      7e3a1e73
    • Timothy B. Terriberry's avatar
      Eliminate more warnings. · 97b766a4
      Timothy B. Terriberry authored
      This eliminates a large set of warnings exposed by the Mozilla build
       system (Use of C++ comments in ISO C90 source, commas at the end of
       enum lists, a couple incomplete initializers, and signed/unsigned
       comparisons).
      It also eliminates many (but not all) of the warnings expose by newer
       GCC versions and _FORTIFY_SOURCE (e.g., calling fread and fwrite
       without checking the return values).
      There are a few spurious warnings left on my system:
      
      ../vp8/encoder/encodemb.c:274:9: warning: 'sz' may be used
       uninitialized in this function
      gcc seems to be unable to figure out that the value shortcut doesn't
       change between the two if blocks that test it here.
      
      ../vp8/encoder/onyx_if.c:5314:5: warning: comparison of unsigned
       expression >= 0 is always true
      ../vp8/encoder/onyx_if.c:5319:5: warning: comparison of unsigned
       expression >= 0 is always true
      This is true, so far as it goes, but it's comparing against an enum,
       and the C standard does not mandate that enums be unsigned, so the
       checks can't be removed.
      
      Change-Id: Iead6cd561a2afaa3d801fd63f1d8d58953da7426
      97b766a4
    • Fritz Koenig's avatar
      postproc: Tweaks to line drawing and blending. · 6fda7668
      Fritz Koenig authored
      Turned down the blending level to make colored blocks obscure
      the video less.
      Not blending the entire block to give distinction to macro
      block edges.
      Added configuration so that macro block blending function can
      be optimized.
      Change to constrain line as to when dx and dy are computed.
      Now draw two lines to form an arrow.
      
      Change-Id: I986784e6abff65ea3e0d1437dfca7d06d44ede71
      6fda7668
    • Timothy B. Terriberry's avatar
      Eliminate more warnings. · c4d7e5e6
      Timothy B. Terriberry authored
      This eliminates a large set of warnings exposed by the Mozilla build
       system (Use of C++ comments in ISO C90 source, commas at the end of
       enum lists, a couple incomplete initializers, and signed/unsigned
       comparisons).
      It also eliminates many (but not all) of the warnings expose by newer
       GCC versions and _FORTIFY_SOURCE (e.g., calling fread and fwrite
       without checking the return values).
      There are a few spurious warnings left on my system:
      
      ../vp8/encoder/encodemb.c:274:9: warning: 'sz' may be used
       uninitialized in this function
      gcc seems to be unable to figure out that the value shortcut doesn't
       change between the two if blocks that test it here.
      
      ../vp8/encoder/onyx_if.c:5314:5: warning: comparison of unsigned
       expression >= 0 is always true
      ../vp8/encoder/onyx_if.c:5319:5: warning: comparison of unsigned
       expression >= 0 is always true
      This is true, so far as it goes, but it's comparing against an enum, and the C
       standard does not mandate that enums be unsigned, so the checks can't be
       removed.
      
      Change-Id: Iaf689ae3e3d0ddc5ade00faa474debe73b8d3395
      c4d7e5e6
  16. 27 Oct, 2010 7 commits
    • Fritz Koenig's avatar
      postproc: Tweaks to line drawing and blending. · a097e189
      Fritz Koenig authored
      Turned down the blending level to make colored blocks obscure
      the video less.
      Not blending the entire block to give distinction to macro
      block edges.
      Added configuration so that macro block blending function can
      be optimized.
      Change to constrain line as to when dx and dy are computed.
      Now draw two lines to form an arrow.
      
      Change-Id: Id3ef0fdeeab2949a6664b2c63e2a3e1a89503f6c
      a097e189
    • Yunqing Wang's avatar
      Full search SAD function optimization in SSE4.1 · 71ecb5d7
      Yunqing Wang authored
      Use mpsadbw, and calculate 8 sad at once. Function list:
      vp8_sad16x16x8_sse4
      vp8_sad16x8x8_sse4
      vp8_sad8x16x8_sse4
      vp8_sad8x8x8_sse4
      vp8_sad4x4x8_sse4
      
      (test clip: tulip)
      For best quality mode, this gave encoder a 5% performance boost.
      For good quality mode with speed=1, this gave encoder a 3%
      performance boost.
      
      Change-Id: I083b5a39d39144f88dcbccbef95da6498e490134
      71ecb5d7
    • John Koleszar's avatar
      Fix half-pixel variance RTCD functions · a0ae3682
      John Koleszar authored
      This patch fixes the system dependent entries for the half-pixel
      variance functions in both the RTCD and non-RTCD cases:
      
        - The generic C versions of these functions are now correct.
          Before all three cases called the hv code.
      
        - Wire up the ARM functions in RTCD mode
      
        - Created stubs for x86 to call the optimized subpixel functions
          with the correct parameters, rather than falling back to C
          code.
      
      Change-Id: I1d937d074d929e0eb93aacb1232cc5e0ad1c6184
      a0ae3682
    • Fritz Koenig's avatar
      vpxdec : Change --pp-debug-info to be a bit field. · cf127474
      Fritz Koenig authored
      This allows multiple post processor debug levels to be overlayed.
      i.e. can show colored reference blocks and visual motion vectors.
      
      Change-Id: Ic4a1df438445b9f5780fe73adb3126e803472e53
      cf127474
    • Johann's avatar
      fix implicit declarations · b90a072f
      Johann authored
      ARM used to explicitly remove this file from the build. With the RTCD
      changes, that's no longer possible. These errors also exist for x86 w/o
      RTCD, but that's not the default configuration
      
      Change-Id: I3e10e5553ddf3278e8d3c9365ca6fb84f52f5066
      b90a072f
    • Johann's avatar
      RTCD build is bringing old errors to light · abcf36c7
      Johann authored
      needs to be _recon_ not _recon_recon_
      
      Change-Id: I7a8b9ddcb4fb72c2b723c563932c9ea52ff15982
      abcf36c7
    • John Koleszar's avatar
      Add half-pixel variance RTCD functions · 209d82ad
      John Koleszar authored
      NEON has optimized 16x16 half-pixel variance functions, but they
      were not part of the RTCD framework. Add these functions to RTCD,
      so that other platforms can make use of this optimization in the
      future and special-case ARM code can be removed.
      
      A number of functions were taking two variance functions as
      parameters. These functions were changed to take a single
      parameter, a pointer to a struct containing all the variance
      functions for that block size. This provides additional flexibility
      for calling additional variance functions (the half-pixel special
      case, for example) and by initializing the table for all block sizes,
      we don't have to construct this function pointer table for each
      macroblock.
      
      Change-Id: I78289ff36b2715f9a7aa04d5f6fbe3d23acdc29c
      209d82ad
  17. 26 Oct, 2010 2 commits
    • Fritz Koenig's avatar
      postproc: Add mode and refrence frame visualizers. · a0ccc97d
      Fritz Koenig authored
      Post process option to color the block for either the mode
      of the macro block, or the frame that the macro block references.
      
      Change-Id: Ie498175497f2d20e3319924d352dc4ddc16f4134
      a0ccc97d
    • John Koleszar's avatar
      make vp8_recon16x16mb{,y} RTCD functions · d6c67f02
      John Koleszar authored
      ARM NEON has a platform specific version of vp8_recon16x16mb, though
      it's just a stub to extract the various parameters from the
      MACROBLOCKD struct and pass them to vp8_recon16x16mb_neon(). Using
      that function's prototype directly will be a better long term solution,
      but it's quite an invasive change.
      
      Change-Id: I04273149e2ade34749e2d09e7edb0c396e1dd620
      d6c67f02