Should reduce phase-related problems at low bitrate

This option disables psychoacoustic improvements that deliberately alter the
waveform (e.g. changing the phase) to improve quality. Although it should
never be used for normal mono or stereo recordings, it can be useful for
cases where matching the waveform is important, e.g. direct ambisonics
(family 2), where the phase changes the spatial location of sounds.

Thanks to Ray Essick

Marcus Asteborg authored 5 years ago and Ralph Giles committed 5 years ago

Signed-off-by: Ralph Giles <giles@thaumas.net>

Thanks to theislander on HA for reporting this.

Adding the OPUS_GET_IN_DTX() query

Marcus Asteborg authored 6 years ago and Jean-Marc Valin committed 6 years ago

If CMAKE_BUILD_TYPE is empty and CFlags are set then only use CFlags.
If None are set then use CMAKE_BUILD_TYPE by Release by default.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Marcus Asteborg authored 6 years ago and Jean-Marc Valin committed 6 years ago

Make release build default
Made CUSTOM_MODE an option with default off
Added missing buildflags for Linux and security.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Gustaf Ullberg authored 6 years ago and Jean-Marc Valin committed 6 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Broken by earlier ARM optimizations.

Marcus Asteborg authored 6 years ago and Jean-Marc Valin committed 6 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Reported in https://github.com/xiph/opus/issues/108

snprintf is not in C89.  Fixes opus-pedantic test failure introduced
in 59f8e5e4.

Copy the previous analysis data instead of flagging as invalid

The previous code would go out of sync in those cases.

logE[b] can end up slightly larger than tonal->highE[b] due to rounding

Thanks to Dmitriy for reporting this.

evpobr authored 6 years ago and Jean-Marc Valin committed 6 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Sorry, no doc for now

Janne Johansson authored 6 years ago and Jean-Marc Valin committed 6 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Addresses the rest of https://github.com/xiph/opus/pull/79

frame diration is only handled at the Opus layer. There's no change
in behaviour, just less puzzling code.

Thanks to Dmitriy <dmilvdv@gmail.com> for reporting this.

We're adding the ambisonics API

Pavel P authored 7 years ago and Jean-Marc Valin committed 6 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

As suggested in https://github.com/xiph/opus/pull/83

or "just" 1 year and 4 months for 10-ms frames.
The overflow can eventually cause a divide-by-zero when counter == -16

Thanks to Dmitry Malinin for reporting the bug.

Without that change, a very long (> 682 ms) illegal packet could trigger
a wrap-around in the test and be accepted as valid.

Only 16-bit architectures (e.g. TI C5x) were affected.