Skip to content
Snippets Groups Projects
Forked from Xiph.Org / Opus
Source project has a limited visibility.
  • Ralph Giles's avatar
    120800f8
    Rename '_FOO' to avoid potentional collisions with reserved identifiers. · 120800f8
    Ralph Giles authored and Jean-Marc Valin's avatar Jean-Marc Valin committed
    C reserves identifiers of the from _[A-Z]+ and we have a number of
    those in the code. This patch renames the various function arguments,
    MACROS and preprocessor symbols to avoid the reserved form.
    
    It also removes the CHANNELS() macro altogether. This was a
    minor optimization for TI DSP to force a mono-only build,
    as were the associated local 'const' versions. Since stereo
    support is manditory, it wasn't worth keeping.
    
    Thanks to John Ridges for raising the issue, and Jean-Marc Valin
    and Greg Maxwell for reviewing the changes.
    120800f8
    History
    Rename '_FOO' to avoid potentional collisions with reserved identifiers.
    Ralph Giles authored and Jean-Marc Valin's avatar Jean-Marc Valin committed
    C reserves identifiers of the from _[A-Z]+ and we have a number of
    those in the code. This patch renames the various function arguments,
    MACROS and preprocessor symbols to avoid the reserved form.
    
    It also removes the CHANNELS() macro altogether. This was a
    minor optimization for TI DSP to force a mono-only build,
    as were the associated local 'const' versions. Since stereo
    support is manditory, it wasn't worth keeping.
    
    Thanks to John Ridges for raising the issue, and Jean-Marc Valin
    and Greg Maxwell for reviewing the changes.