Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
Opus
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Alexander Traud
Opus
Commits
db5b1945
Commit
db5b1945
authored
11 years ago
by
Jean-Marc Valin
Browse files
Options
Downloads
Patches
Plain Diff
Fixes an initialization issue in SILK prefill found by Coverity
parent
1d72d383
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
silk/fixed/encode_frame_FIX.c
+4
-4
4 additions, 4 deletions
silk/fixed/encode_frame_FIX.c
silk/float/encode_frame_FLP.c
+4
-4
4 additions, 4 deletions
silk/float/encode_frame_FLP.c
with
8 additions
and
8 deletions
silk/fixed/encode_frame_FIX.c
+
4
−
4
View file @
db5b1945
...
...
@@ -302,10 +302,6 @@ opus_int silk_encode_frame_FIX(
silk_memmove
(
psEnc
->
x_buf
,
&
psEnc
->
x_buf
[
psEnc
->
sCmn
.
frame_length
],
(
psEnc
->
sCmn
.
ltp_mem_length
+
LA_SHAPE_MS
*
psEnc
->
sCmn
.
fs_kHz
)
*
sizeof
(
opus_int16
)
);
/* Parameters needed for next frame */
psEnc
->
sCmn
.
prevLag
=
sEncCtrl
.
pitchL
[
psEnc
->
sCmn
.
nb_subfr
-
1
];
psEnc
->
sCmn
.
prevSignalType
=
psEnc
->
sCmn
.
indices
.
signalType
;
/* Exit without entropy coding */
if
(
psEnc
->
sCmn
.
prefillFlag
)
{
/* No payload */
...
...
@@ -314,6 +310,10 @@ opus_int silk_encode_frame_FIX(
return
ret
;
}
/* Parameters needed for next frame */
psEnc
->
sCmn
.
prevLag
=
sEncCtrl
.
pitchL
[
psEnc
->
sCmn
.
nb_subfr
-
1
];
psEnc
->
sCmn
.
prevSignalType
=
psEnc
->
sCmn
.
indices
.
signalType
;
/****************************************/
/* Finalize payload */
/****************************************/
...
...
This diff is collapsed.
Click to expand it.
silk/float/encode_frame_FLP.c
+
4
−
4
View file @
db5b1945
...
...
@@ -294,10 +294,6 @@ opus_int silk_encode_frame_FLP(
silk_memmove
(
psEnc
->
x_buf
,
&
psEnc
->
x_buf
[
psEnc
->
sCmn
.
frame_length
],
(
psEnc
->
sCmn
.
ltp_mem_length
+
LA_SHAPE_MS
*
psEnc
->
sCmn
.
fs_kHz
)
*
sizeof
(
silk_float
)
);
/* Parameters needed for next frame */
psEnc
->
sCmn
.
prevLag
=
sEncCtrl
.
pitchL
[
psEnc
->
sCmn
.
nb_subfr
-
1
];
psEnc
->
sCmn
.
prevSignalType
=
psEnc
->
sCmn
.
indices
.
signalType
;
/* Exit without entropy coding */
if
(
psEnc
->
sCmn
.
prefillFlag
)
{
/* No payload */
...
...
@@ -305,6 +301,10 @@ opus_int silk_encode_frame_FLP(
return
ret
;
}
/* Parameters needed for next frame */
psEnc
->
sCmn
.
prevLag
=
sEncCtrl
.
pitchL
[
psEnc
->
sCmn
.
nb_subfr
-
1
];
psEnc
->
sCmn
.
prevSignalType
=
psEnc
->
sCmn
.
indices
.
signalType
;
/****************************************/
/* Finalize payload */
/****************************************/
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment