Mark Harris authored 10 years ago and Jean-Marc Valin committed 10 years ago

Avoid undefined behavior (signed arithmetic overflow) or
implementation-defined behavior (malloc(0)) on out-of-range arguments,
e.g. opus_multistream_encoder_create(48000, 2, 2147483647, 1, ...)
or opus_multistream_surround_encoder_create(48000, 3, 0, ...).

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Cameron Gutman authored 10 years ago and Tristan Matthews committed 10 years ago

Signed-off-by: Tristan Matthews <tmatth@videolan.org>

This is just a should, so we want to leave the RFC 6716 reference
to the second occurance, but using the same language ties them
together and to the later occurances.

The Opus RFC doesn't really say what to do beyond rejecting
a particular packet, but having the reference reinforces that
we're trying to leverage the same constraints in the specific
context of ogg encapsulation, and this isn't a new rule.

Suggestion from mark4o.

This avoids confusion with the number of frames being defined
by more than the first byte with code 3 packets.

Patch from mark4o.

The macros take arguments, they aren't just constants. Thanks to
mark4o for the report.

Add a limit of no more than 6 characters for these tags' values.

Based on http://vfrmaniac.fushizen.eu/contents/opus_in_isobmff.html

There is also no trailing whitespace.

xiangmingzhu authored 10 years ago and Jean-Marc Valin committed 10 years ago

1. Only for fixed point on x86 platform (32bit and 64bit, uses SIMD
   intrinsics up to SSE4.2)
2. Use "configure --enable-fixed-point --enable-intrinsics" to enable
   optimization, default is disabled.
3. Official test cases are verified and passed.

Signed-off-by: Timothy B. Terriberry <tterribe@xiph.org>

This is a quick script to download, rename and sanitize
Yusuke Nakamura's draft for opus in the ISO Base Media File Format.

Based on http://vfrmaniac.fushizen.eu/contents/opus_in_isobmff.html

SHOULD or SHOULD NOT. There is no attempt.

From the codec wg mailing list thread
https://www.ietf.org/mail-archive/web/codec/current/msg03107.html

Based on http://vfrmaniac.fushizen.eu/style.css

From http://vfrmaniac.fushizen.eu/contents/opus_in_isobmff.html

Based on http://vfrmaniac.fushizen.eu/contents/opus_in_isobmff.html

Considers the case where one stream would eat up all the remaining bytes,
including a 2-byte size that would then not leave enough for the even a PLC
packet in the next streams.

Limit now at 2*streams-1 and anything below that returns OPUS_BUFFER_TOO_SMALL
rather than OPUS_BAD_ARG

These are normative whether capitalized or not. Capitalize the ones
which make sense as normative requirements, and reword the rest.

We want to general guidelines for stream-level encapsulation to
apply to multiplexed as well as degenerate streams. 'Files' can
therefore specific to the mine-type discussion for unmultiplexed
Ogg physical streams.

These are the changes proposed in
 <http://www.ietf.org/mail-archive/web/codec/current/msg03058.html>,
 with some minor additions (see follow-up on the list).

cherry-picked from speexdsp 86779a06f6500d041573d6252d4971d3bfcb4b18

Promote the new tag definitions to a separate subsection,
balance tags, improve wording, and document our motivation
for the R128 tags.