This should prevent extreme dynalloc behaviour in cases where some
bands are heavily attenuated.

and use them more strictly in the rest of the text.

Comment from mark4o.

It wants a surname, and to show it as Surname, Initial.
This leaves an extra comma in the xml2rfc2 output, but
at least mentions wikipedia.

Marko was concerned that RFC 6716 section 3.2.1 narrowly describes
zero-length DTX frames _only_ for code 2 and 3 packets, and therefore
wanted this sentence to state clearly that code 0 and 1 can be used
with zero-byte frames as well. I've tried to do that.

There was some attempt to use LP/MDCT instead, to avoid confusion
of the Opus modes with the earlier codecs of the same name, but
Jean-Marc says they gave up on doing that in the Opus RFC, and in
particular the tables a reader would need to reference from RFC 6716
Section 3.2 mentions SILK and CELT, so I think it's important to use
the same terms here.

It's not hyphenated anywhere else.

I hope.  Now that it's been clarified for me what this originally meant
to say, it's tricky to know if this actually contains the missing clue
for other readers.  Hopefully it should be obvious to anyone actually
implementing it once they look at what modes they have to choose from.

Ron's suggestion. We think it's clear enough as is and
removing it avoids confusion about this specification
versus future extensions.

This is really the best implementations can do as far as we
understand the possibilies, so it's better to be straightforward.

Mark Harris authored 11 years ago and Jean-Marc Valin committed 11 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

We failed to do this before the 1.1 release, so that went out
still marked at 1.1 beta. The plan was to get rid of this file
but it's still used as a fallback by the msvc build.

Incorporate list feedback from Mark Harris, Tim and Jean-Marc
and try to improve clarity.

From http://www.ietf.org/mail-archive/web/codec/current/msg03030.html

In glib 2.17 the __malloc_ptr define was removed in favour
of using void* directly. Our declaration of mhook using this
type for the second argument therefore rightly generates a warning
on modern systems, since the type is assumed to be an int, which
is too narrow to hold a pointer on 64 bit architectures.

Since it was only ever a define we could use an #ifndef to define
__malloc_ptr ourselves. However we only use it once, so using void*
in the signature directly is cleaner. This should cause no problems
on older systems where it will match either the void* or the char*
(for non __STDC__ code) the define resolved to.

Mark Harris authored 11 years ago and Jean-Marc Valin committed 11 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Mark Harris authored 11 years ago and Jean-Marc Valin committed 11 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

This was causing pseudostack builds to fail because opus_demo uses a 2-second
buffer.